Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13065
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88755507
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -103,5 +109,192 @@ case class GenerateExec(
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88754155
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -113,4 +117,25 @@ class WholeStageCodegenSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88753306
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -103,5 +109,182 @@ case class GenerateExec(
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88740233
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -103,5 +109,182 @@ case class GenerateExec(
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88630739
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -113,4 +117,25 @@ class WholeStageCodegenSuite
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88581043
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -103,5 +109,182 @@ case class GenerateExec(
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88580906
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -113,4 +117,25 @@ class WholeStageCodegenSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88571483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -149,29 +167,52 @@ case class Stack(children:
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88550711
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -40,6 +42,10 @@ private[execution] sealed case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88548955
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -40,6 +42,10 @@ private[execution] sealed case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88525819
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -103,5 +109,182 @@ case class GenerateExec(
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88525329
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -149,29 +167,52 @@ case class Stack(children:
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88524027
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -40,6 +42,10 @@ private[execution] sealed case class
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88523492
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -103,5 +109,182 @@ case class GenerateExec(
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88139065
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/MiscBenchmark.scala
---
@@ -124,12 +124,124 @@ class MiscBenchmark extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88098625
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -144,29 +162,52 @@ case class Stack(children:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88098485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec(
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r86424146
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec(
}
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r87041036
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/MiscBenchmark.scala
---
@@ -124,12 +124,124 @@ class MiscBenchmark extends
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r86423636
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec(
}
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r86423199
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -63,6 +65,21 @@ trait Generator extends Expression {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r87040958
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/MiscBenchmark.scala
---
@@ -124,12 +124,124 @@ class MiscBenchmark extends
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r86423011
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -144,29 +162,52 @@ case class Stack(children:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r82944265
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec(
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r76835824
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec(
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r76835067
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec(
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r76834689
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -63,6 +65,21 @@ trait Generator extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r76834077
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r76831153
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -63,6 +65,21 @@ trait Generator extends Expression {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r76830307
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec(
}
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r76830089
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec(
}
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r76829591
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec(
}
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r76829166
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -63,6 +65,21 @@ trait Generator extends Expression {
34 matches
Mail list logo
