[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-31 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/spark/pull/14568 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-17 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r75151883 --- Diff: python/pyspark/sql/functions.py --- @@ -426,6 +426,29 @@ def monotonically_increasing_id(): return Column(sc._jvm.functions.monotonically_inc

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-17 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r75151089 --- Diff: python/pyspark/sql/functions.py --- @@ -426,6 +426,29 @@ def monotonically_increasing_id(): return Column(sc._jvm.functions.monotonicall

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-15 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74801826 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -81,3 +91,12 @@ case class Monoton

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-14 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74710318 --- Diff: python/pyspark/sql/functions.py --- @@ -426,6 +426,29 @@ def monotonically_increasing_id(): return Column(sc._jvm.functions.monotonically_inc

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-14 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74710145 --- Diff: python/pyspark/sql/functions.py --- @@ -426,6 +426,29 @@ def monotonically_increasing_id(): return Column(sc._jvm.functions.monotonically_inc

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74709735 --- Diff: python/pyspark/sql/functions.py --- @@ -426,6 +426,29 @@ def monotonically_increasing_id(): return Column(sc._jvm.functions.monotonically_incr

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-11 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74484517 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -81,3 +93,12 @@ case class Monotonicall

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74463138 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -81,3 +93,12 @@ case class Monoton

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-11 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74460557 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -81,3 +93,12 @@ case class Monotonicall

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74442456 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -40,13 +42,23 @@ import org.apache

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74437337 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -40,13 +42,23 @@ import org.apache

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74436746 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -81,3 +93,12 @@ case class Monoton

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74434465 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -40,13 +42,23 @@ import org.apache

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74145985 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -40,13 +40,14 @@ import org.apache.spark

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74145557 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -993,12 +993,31 @@ object functions { * This expression would return

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74140971 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -40,13 +40,14 @@ import org.apache

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-09 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74138850 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -40,13 +40,14 @@ import org.apache.spar

[GitHub] spark pull request #14568: [SPARK-10868] monotonicallyIncreasingId() support...

2016-08-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14568#discussion_r74137649 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala --- @@ -40,13 +40,14 @@ import org.apache