[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77384493 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,297 @@ object JdbcUtils extends

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77384218 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -546,33 +281,33 @@ private[jdbc] class JDBCRDD(

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14907 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77377425 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,297 @@ object JdbcUtils extends

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77377079 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,288 @@ object JdbcUtils extends

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77375713 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -546,33 +281,33 @@ private[jdbc] class JDBCRDD(

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77283758 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,297 @@ object JdbcUtils extends

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77279354 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,297 @@ object JdbcUtils extends

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77278500 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,297 @@ object JdbcUtils extends

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77277642 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,297 @@ object JdbcUtils extends

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77277372 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,297 @@ object JdbcUtils extends

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77100063 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,288 @@ object JdbcUtils extends

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77099971 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,288 @@ object JdbcUtils extends

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77099874 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -546,33 +281,33 @@ private[jdbc] class JDBCRDD(

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77099804 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,195 +237,15 @@ private[jdbc] class JDBCRDD(

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77099720 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,195 +237,15 @@ private[jdbc] class JDBCRDD(

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77099616 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -322,195 +237,15 @@ private[jdbc] class JDBCRDD(

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/14907 [SPARK-17351] Refactor JDBCRDD to expose ResultSet -> Seq[Row] utility methods This patch refactors the internals of the JDBC data source in order to allow some of its code to be re-used in an