Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15857
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87998688
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation exte
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87998196
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation exte
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87983673
--- Diff: sql/core/src/test/resources/sql-tests/results/group-by.sql.out ---
@@ -131,3 +131,11 @@ FROM testData
struct
-- !query 13 output
-
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87934920
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala
---
@@ -118,14 +118,30 @@ class FoldableProp
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87932854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation exten
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87932789
--- Diff: sql/core/src/test/resources/sql-tests/results/group-by.sql.out ---
@@ -131,3 +131,11 @@ FROM testData
struct
-- !query 13 output
-0
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87932636
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala
---
@@ -118,14 +118,30 @@ class FoldablePropa
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87932525
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation exte
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87932494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation exten
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87865899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation exte
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87865485
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala
---
@@ -118,14 +118,30 @@ class FoldableProp
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87865434
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation exte
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87862736
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala
---
@@ -118,14 +118,30 @@ class FoldableProp
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87861276
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation exte
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87809078
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala
---
@@ -118,14 +118,30 @@ class FoldableProp
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87809029
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation exte
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87746263
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -449,7 +452,7 @@ object FoldablePropagation ext
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87743162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -449,7 +452,7 @@ object FoldablePropagation extends
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/15857
[SPARK-18300][SQL] Do not apply foldable propagation with expand as a child.
## What changes were proposed in this pull request?
The `FoldablePropagation` optimizer rule, pulls foldable value
20 matches
Mail list logo
