Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15996
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r94008071
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -134,146 +133,38 @@ case class CreateDataSou
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r94006226
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -373,39 +378,50 @@ final class DataFrameWriter[T] private[sql](ds:
Da
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r94005331
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -289,4 +180,29 @@ case class CreateDataSourc
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93730700
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -643,6 +644,14 @@ class DataFrameReaderWriterSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93723071
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala
---
@@ -195,12 +195,25 @@ class PartitionProviderCom
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93723027
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -635,4 +638,13 @@ class DataFrameReaderWriterSuite ext
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93722426
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala
---
@@ -195,12 +195,25 @@ class PartitionProviderCom
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93722334
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -140,153 +140,55 @@ case class CreateDataSour
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93722277
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -363,48 +365,125 @@ final class DataFrameWriter[T] private[sql](ds:
Da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93722231
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -364,48 +366,162 @@ final class DataFrameWriter[T] private[sql](ds:
Da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93722074
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -364,48 +366,162 @@ final class DataFrameWriter[T] private[sql](ds:
Da
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93720714
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala
---
@@ -195,12 +195,25 @@ class PartitionProviderCompati
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93720687
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala
---
@@ -195,12 +195,25 @@ class PartitionProviderCompati
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93720630
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala
---
@@ -195,12 +195,25 @@ class PartitionProviderCompati
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93720613
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala
---
@@ -195,12 +195,25 @@ class PartitionProviderCompati
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93720521
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -140,153 +140,55 @@ case class CreateDataSourceTa
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93720313
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -363,48 +365,125 @@ final class DataFrameWriter[T] private[sql](ds:
Datase
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93720195
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -364,48 +366,162 @@ final class DataFrameWriter[T] private[sql](ds:
Datase
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93719938
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -364,48 +366,162 @@ final class DataFrameWriter[T] private[sql](ds:
Datase
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93719624
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -635,4 +638,13 @@ class DataFrameReaderWriterSuite extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93718921
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -635,4 +638,13 @@ class DataFrameReaderWriterSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93387828
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -364,48 +366,157 @@ final class DataFrameWriter[T] private[sql](ds:
D
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r93298271
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -364,48 +365,149 @@ final class DataFrameWriter[T] private[sql](ds:
D
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r92598769
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -363,48 +365,125 @@ final class DataFrameWriter[T] private[sql](ds:
Da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r92597757
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -363,48 +365,125 @@ final class DataFrameWriter[T] private[sql](ds:
Da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r92597284
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -363,48 +365,125 @@ final class DataFrameWriter[T] private[sql](ds:
Da
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r92547533
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -363,48 +364,120 @@ final class DataFrameWriter[T] private[sql](ds:
D
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r92526424
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -363,48 +364,120 @@ final class DataFrameWriter[T] private[sql](ds:
D
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r92526260
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -363,48 +364,120 @@ final class DataFrameWriter[T] private[sql](ds:
Da
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15996#discussion_r92254810
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -363,48 +364,120 @@ final class DataFrameWriter[T] private[sql](ds:
D
31 matches
Mail list logo
