[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16480 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94872466 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -339,11 +344,13 @@ final class OneVsRest @Since("1.4.0") (

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94872199 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala --- @@ -76,6 +77,18 @@ private[ml] trait ValidatorParams extends HasSeed wi

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94871938 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala --- @@ -76,6 +77,18 @@ private[ml] trait ValidatorParams extends HasSeed wi

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user sueann commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94870250 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala --- @@ -85,9 +86,27 @@ private[spark] class Instrumentation[E <: Estimator[_]]

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94860281 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -344,6 +344,10 @@ final class OneVsRest @Since("1.4.0") (

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94861991 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala --- @@ -85,9 +86,27 @@ private[spark] class Instrumentation[E <: Estimator[_]

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94860863 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -344,6 +344,10 @@ final class OneVsRest @Since("1.4.0") (

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94860559 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -344,6 +344,10 @@ final class OneVsRest @Since("1.4.0") (

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94861932 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala --- @@ -85,9 +86,27 @@ private[spark] class Instrumentation[E <: Estimator[_]

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94861192 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -344,6 +344,10 @@ final class OneVsRest @Since("1.4.0") (

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94862191 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala --- @@ -85,9 +86,27 @@ private[spark] class Instrumentation[E <: Estimator[_]

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94861627 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala --- @@ -116,13 +116,17 @@ class TrainValidationSplit @Since("1.5.0")

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

GitHub user sueann opened a pull request: https://github.com/apache/spark/pull/16480 [SPARK-18194][ML] Log instrumentation in OneVsRest, CrossValidator, TrainValidationSplit ## What changes were proposed in this pull request? Added instrumentation logging for OneVsRest clas

[GitHub] spark pull request #16480: [SPARK-18194][ML] Log instrumentation in OneVsRes...

Github user sueann commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94859428 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala --- @@ -344,6 +344,10 @@ final class OneVsRest @Since("1.4.0") (