Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16844
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r101592592
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -698,7 +698,7 @@ public boolean append(Object kbase, long koff, int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r101435816
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -742,7 +742,7 @@ public boolean append(Object kbase, long koff, int
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r101360777
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -742,7 +742,7 @@ public boolean append(Object kbase, long koff, int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100532958
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100518427
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100493999
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100478225
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100473254
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100461137
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100404374
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100387863
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100385423
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100383151
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -741,14 +741,6 @@ public boolean append(Object kbase, long koff, int
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100381544
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100378935
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100318189
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100313174
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -741,14 +741,6 @@ public boolean append(Object kbase, long koff, int
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100170698
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100170278
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r8291
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -742,7 +742,7 @@ public boolean append(Object kbase, long koff, int
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/16844
[SPARK-19500] [SQL] Fix off-by-one bug in BytesToBytesMap
## What changes were proposed in this pull request?
Radix sort require that half of array as free (as temporary space), so we
use
22 matches
Mail list logo
