Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17001
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r105565416
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -907,3 +936,97 @@ object SPARK_18989_DESC_TABLE {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r105565378
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -907,3 +936,97 @@ object SPARK_18989_DESC_TABLE {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r105565256
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -907,3 +936,97 @@ object SPARK_18989_DESC_TABLE {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r105565132
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -907,3 +936,97 @@ object SPARK_18989_DESC_TABLE {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r105565041
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -907,3 +936,97 @@ object SPARK_18989_DESC_TABLE {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r105564983
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -907,3 +936,97 @@ object SPARK_18989_DESC_TABLE {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r105564912
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -907,3 +936,97 @@ object SPARK_18989_DESC_TABLE {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r104111279
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -74,7 +88,17 @@ abstract class ExternalCatalog
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r104101806
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -905,3 +934,91 @@ object SPARK_18989_DESC_TABLE {
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103891244
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103889802
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103865522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103865312
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103863975
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103863070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103862862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103861521
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103861355
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -74,7 +77,19 @@ abstract class ExternalCatalog
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103605667
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -74,7 +77,19 @@ abstract class ExternalCatalog
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103420821
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -74,7 +77,19 @@ abstract class ExternalCatalog
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103419380
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -74,7 +77,19 @@ abstract class ExternalCatalog
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103067748
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,15 @@ private[spark] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103046202
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,15 @@ private[spark] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103045973
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,15 @@ private[spark] class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102873675
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,13 @@ private[spark] class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102871210
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,13 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102870703
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,13 @@ private[spark] class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102870643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -193,7 +193,16 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102870494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -193,7 +193,16 @@ class SessionCatalog(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102870072
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,13 @@ private[spark] class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102866593
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,13 @@ private[spark] class
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102865566
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -193,7 +193,16 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102784103
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,13 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102783506
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,13 @@ private[spark] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102781147
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,13 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102778675
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +408,13 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102778417
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -193,7 +193,16 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102778093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -193,7 +193,16 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102777281
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -193,7 +193,16 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102776886
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -193,7 +193,16 @@ class SessionCatalog(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102650536
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -339,10 +340,17 @@ private[hive] class HiveClientImpl(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102648988
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -339,10 +340,17 @@ private[hive] class HiveClientImpl(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102642601
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -339,10 +340,17 @@ private[hive] class HiveClientImpl(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102625694
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -339,10 +340,15 @@ private[hive] class HiveClientImpl(
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102622702
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedWriteSuite.scala
---
@@ -92,7 +92,8 @@ abstract class BucketedWriteSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102619806
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedWriteSuite.scala
---
@@ -92,7 +92,8 @@ abstract class BucketedWriteSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102619596
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -339,10 +340,15 @@ private[hive] class HiveClientImpl(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102619396
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedWriteSuite.scala
---
@@ -92,7 +92,8 @@ abstract class BucketedWriteSuite extends
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102392451
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -311,11 +313,12 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r102387112
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -311,11 +313,12 @@ private[hive] class HiveClientImpl(
51 matches
Mail list logo