[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-27 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r108103956 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java --- @@ -169,6 +173,36 @@ public void write(Iterator> records)

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-26 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r108061417 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java --- @@ -169,6 +173,36 @@ public void write(Iterator> records

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-25 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r108052804 --- Diff: core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleWriter.scala --- @@ -72,6 +72,27 @@ private[spark] class SortShuffleWriter[K, V, C](

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-25 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r108052849 --- Diff: core/src/main/scala/org/apache/spark/executor/ShuffleReadMetrics.scala --- @@ -80,13 +86,15 @@ class ShuffleReadMetrics private[spark] () extends

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-25 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r108052758 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java --- @@ -228,6 +230,36 @@ void closeAndWriteOutput() throws IOException {

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-25 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r108052747 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java --- @@ -169,6 +173,36 @@ public void write(Iterator> records)

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-25 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r108052753 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java --- @@ -169,6 +173,36 @@ public void write(Iterator> records)

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-21 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r107156339 --- Diff: core/src/main/scala/org/apache/spark/executor/ShuffleWriteMetrics.scala --- @@ -17,8 +17,12 @@ package org.apache.spark.executor

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-21 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r107158475 --- Diff: core/src/main/scala/org/apache/spark/executor/ShuffleReadMetrics.scala --- @@ -80,13 +92,17 @@ class ShuffleReadMetrics private[spark] () extends

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-21 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r107161810 --- Diff: core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleWriter.scala --- @@ -72,6 +72,18 @@ private[spark] class SortShuffleWriter[K, V, C](

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-21 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r107157788 --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala --- @@ -164,6 +164,8 @@ private[spark] class HighlyCompressedMapStatus private (

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-21 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r107157471 --- Diff: core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleWriter.scala --- @@ -72,6 +72,18 @@ private[spark] class SortShuffleWriter[K, V, C](

[GitHub] spark pull request #17276: [SPARK-19937] Collect metrics of block sizes when...

2017-03-21 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r107160710 --- Diff: core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleWriter.scala --- @@ -72,6 +72,18 @@ private[spark] class SortShuffleWriter[K, V, C](