[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-08-09 Thread zhengruifeng
Github user zhengruifeng closed the pull request at: https://github.com/apache/spark/pull/17995 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-07-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r125606256 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -136,6 +137,14 @@ private[ml] object Param { s"${this.getCla

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-07-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r125564145 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala --- @@ -187,12 +188,12 @@ class NaiveBayes @Since("1.5.0") (

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-07-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r125606191 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -229,6 +238,16 @@ object ParamValidators { def arrayLengthGt[T](lowerB

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-07-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r125642693 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -93,8 +93,8 @@ private[classification] trait LogisticR

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-07-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r125647745 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -199,7 +199,7 @@ private[regression] trait Gener

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-07-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r125648566 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -460,7 +463,7 @@ object LinearRegression extends DefaultPara

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-07-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r125605206 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala --- @@ -83,19 +85,16 @@ class BinaryClassificationEval

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-07-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r125605561 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala --- @@ -106,4 +105,13 @@ object BinaryClassificationEv

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123931580 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala --- @@ -81,7 +83,8 @@ private[classification] t

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123921193 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala --- @@ -81,7 +83,8 @@ private[classification] tra

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123920923 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -313,7 +313,11 @@ class GeneralizedLinearRegressi

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123919667 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -128,7 +130,8 @@ private[feature] trait ChiSqSelectorParams extends

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123919494 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala --- @@ -48,10 +50,11 @@ final class RegressionEvaluator @Since("

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123888757 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala --- @@ -46,11 +48,10 @@ class BinaryClassificationEval

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123920437 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -45,7 +47,7 @@ private[feature] trait ImputerParams extends Params with H

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123919458 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluator.scala --- @@ -44,12 +46,10 @@ class MulticlassClassifica

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123920352 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala --- @@ -70,6 +71,10 @@ class BinaryClassificationEvalu

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-05-15 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/17995 [SPARK-20762][ML]Make String Params Case-Insensitive ## What changes were proposed in this pull request? Make String Params Case-Insensitive ## How was this patch tested? exist