Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121391953
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -644,7 +644,7 @@ class ColumnarBatchSuite
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121336668
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -518,19 +519,13 @@ private void
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121311872
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -518,19 +519,13 @@ private void
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121311563
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -43,14 +43,12 @@
private byte[] byteData;
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121307879
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -42,15 +42,13 @@
// Array for each type.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121307570
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -366,55 +364,22 @@ public double getDouble(int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121306993
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -42,15 +42,13 @@
// Array for each type.
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121306979
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -42,15 +42,13 @@
// Array for each type.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121306584
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -42,15 +42,13 @@
// Array for each type.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121303857
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -438,10 +401,8 @@ public void
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121303697
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -438,10 +401,8 @@ public void
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121298160
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -659,18 +659,18 @@ class ColumnarBatchSuite
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121297255
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -438,10 +401,9 @@ public void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121296861
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -366,55 +364,23 @@ public double getDouble(int
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121296826
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -438,10 +401,9 @@ public void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121296821
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -366,55 +364,23 @@ public double getDouble(int
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121296775
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -438,10 +401,9 @@ public void
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121296265
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -366,55 +364,23 @@ public double getDouble(int
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121296069
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -366,55 +364,23 @@ public double getDouble(int
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121295792
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -438,10 +401,9 @@ public void
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121295725
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -42,6 +42,8 @@
// Array for each type.
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121295705
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -34,6 +34,8 @@
// The data stored in
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121285736
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -518,19 +519,13 @@ private void
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121279634
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -518,19 +519,13 @@ private void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121265353
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -366,55 +362,23 @@ public double getDouble(int
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121265343
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -518,19 +519,13 @@ private void
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121253872
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -518,19 +519,13 @@ private void
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121253796
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -366,55 +362,23 @@ public double getDouble(int
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121253769
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -518,19 +519,13 @@ private void
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/18260
[SPARK-21046][SQL] simplify the array offset and length in ColumnVector
## What changes were proposed in this pull request?
Currently when a `ColumnVector` stores array type elements, we
31 matches
Mail list logo
