Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18388
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128882147
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -130,11 +143,25 @@ private void
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128881079
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -130,11 +143,25 @@ private void
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128879751
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -130,11 +143,25 @@ private void
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128879607
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -96,18 +103,23 @@ public ManagedBuffer
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128879502
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -122,6 +134,7 @@ public void
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128879315
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -53,9 +56,13 @@
// that the
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128879045
--- Diff: docs/configuration.md ---
@@ -1809,6 +1809,14 @@ Apart from these, the following properties are also
available, and may be useful
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128878875
--- Diff: docs/configuration.md ---
@@ -1809,6 +1809,14 @@ Apart from these, the following properties are also
available, and may be useful
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128878596
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -130,11 +143,25 @@ private void
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128878556
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -118,6 +124,13 @@ private void
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128878335
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,7 @@ public Properties cryptoConf() {
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128794455
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/StreamManager.java
---
@@ -83,4 +83,16 @@ public void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128755064
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/StreamManager.java
---
@@ -83,4 +83,16 @@ public void
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128688973
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,11 @@ public Properties cryptoConf() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128526865
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -145,7 +172,12 @@ private void
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128519475
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -145,7 +172,12 @@ private void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128503793
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,7 @@ public Properties cryptoConf() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128502814
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -145,7 +172,12 @@ private void
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128498015
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,7 @@ public Properties cryptoConf() {
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128497296
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -145,7 +172,12 @@ private void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128485815
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,7 @@ public Properties cryptoConf() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128485755
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -145,7 +172,12 @@ private void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128484701
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -53,9 +56,13 @@
// that the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128259951
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -139,6 +153,32 @@ public void
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128217700
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -25,6 +25,9 @@
import
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128217450
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -139,6 +153,32 @@ public void
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128217046
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -53,9 +56,13 @@
// that the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128151097
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -25,6 +25,9 @@
import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128151076
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -139,6 +153,32 @@ public void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r128149914
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -53,9 +56,13 @@
// that the
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r125068210
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124963673
--- Diff: docs/configuration.md ---
@@ -614,6 +614,34 @@ Apart from these, the following properties are also
available, and may be useful
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124795947
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124790635
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf() {
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124749907
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf() {
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124749254
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124744067
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf() {
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124723237
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf() {
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124722541
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/PooledByteBufAllocatorWithMetrics.java
---
@@ -0,0 +1,69 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124717582
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandlerSuite.java
---
@@ -147,4 +154,21 @@ public
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124716883
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/OpenBlocksFailed.java
---
@@ -0,0 +1,84 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124715952
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
---
@@ -90,16 +96,28 @@ protected void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124715302
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124715080
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/PooledByteBufAllocatorWithMetrics.java
---
@@ -0,0 +1,69 @@
+/*
+ *
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124554250
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf()
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124510372
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf() {
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124503201
--- Diff:
core/src/main/scala/org/apache/spark/deploy/ExternalShuffleService.scala ---
@@ -54,13 +54,16 @@ class ExternalShuffleService(sparkConf:
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124502658
--- Diff:
core/src/main/scala/org/apache/spark/deploy/ExternalShuffleService.scala ---
@@ -54,13 +54,16 @@ class ExternalShuffleService(sparkConf:
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124502044
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
---
@@ -90,16 +96,28 @@ protected void
Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124501943
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf() {
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124494282
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
---
@@ -90,16 +96,28 @@ protected
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124475648
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf()
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124476064
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf()
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124498255
--- Diff:
core/src/main/scala/org/apache/spark/deploy/ExternalShuffleService.scala ---
@@ -54,13 +54,16 @@ class ExternalShuffleService(sparkConf:
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124475712
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf()
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18388#discussion_r124476066
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -257,4 +257,31 @@ public Properties cryptoConf()
GitHub user jinxing64 opened a pull request:
https://github.com/apache/spark/pull/18388
[SPARK-21175] Reject OpenBlocks when memory shortage on shuffle service.
## What changes were proposed in this pull request?
A shuffle service can serves blocks from multiple apps/tasks.
58 matches
Mail list logo
