Github user rdblue closed the pull request at:
https://github.com/apache/spark/pull/19568
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user rdblue reopened a pull request:
https://github.com/apache/spark/pull/19568
SPARK-22345: Fix sort-merge joins with conditions and codegen.
## What changes were proposed in this pull request?
This adds a joined row to sort-merge join codegen. That joined row is
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r147471530
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/InnerJoinSuite.scala
---
@@ -124,7 +125,8 @@ class InnerJoinSuite extends
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r147471054
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/InnerJoinSuite.scala
---
@@ -228,6 +230,27 @@ class InnerJoinSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r147470946
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/InnerJoinSuite.scala
---
@@ -124,7 +125,8 @@ class InnerJoinSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r147470383
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/InnerJoinSuite.scala
---
@@ -228,6 +230,27 @@ class InnerJoinSuite extends
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r14733
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -585,21 +585,26 @@ case class SortMergeJoinExec(
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r146975643
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -585,21 +585,26 @@ case class SortMergeJoinExec(
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r146974005
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -585,21 +585,26 @@ case class SortMergeJoinExec(
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r146970055
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -615,6 +620,7 @@ case class SortMergeJoinExec(
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r146928894
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -585,21 +585,26 @@ case class SortMergeJoinExec(
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r146928318
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -615,6 +620,7 @@ case class SortMergeJoinExec(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r146757237
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -585,21 +585,26 @@ case class SortMergeJoinExec(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r146756914
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -585,21 +585,26 @@ case class SortMergeJoinExec(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r146755690
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -615,6 +620,7 @@ case class SortMergeJoinExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r146743704
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -615,6 +620,7 @@ case class SortMergeJoinExec(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19568#discussion_r146720363
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -615,6 +620,7 @@ case class SortMergeJoinExec(
GitHub user rdblue opened a pull request:
https://github.com/apache/spark/pull/19568
SPARK-22345: Fix sort-merge joins with conditions and codegen.
## What changes were proposed in this pull request?
This adds a joined row to sort-merge join codegen. That joined row is used
18 matches
Mail list logo
