[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19698 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150655624 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala --- @@ -66,13 +66,8 @@ private[spark] class AppStatusStore(store: KVStore) {

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150654983 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1036,8 +1006,13 @@ private[ui] class TaskDataSource( shuffleRead,

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150648166 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala --- @@ -182,173 +185,183 @@ private[ui] class JobPage(parent: JobsTab) extends

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150648236 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1036,8 +1006,13 @@ private[ui] class TaskDataSource( shuffleRead,

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150637980 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobsTab.scala --- @@ -19,35 +19,52 @@ package org.apache.spark.ui.jobs import

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150622074 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala --- @@ -182,173 +185,183 @@ private[ui] class JobPage(parent: JobsTab) extends

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150631869 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -856,22 +832,24 @@ private[ui] class TaskTableRowData( val logs:

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150632556 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1036,8 +1006,13 @@ private[ui] class TaskDataSource( shuffleRead,

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150626334 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/PoolPage.scala --- @@ -17,50 +17,49 @@ package org.apache.spark.ui.jobs +import

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150622874 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala --- @@ -182,173 +185,183 @@ private[ui] class JobPage(parent: JobsTab) extends

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150564678 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -23,19 +23,21 @@ import javax.servlet.http.HttpServletRequest

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19698#discussion_r150573812 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -285,106 +272,120 @@ private[ui] class AllJobsPage(parent: JobsTab) extends

[GitHub] spark pull request #19698: [SPARK-20648][core] Port JobsTab and StageTab to ...

2017-11-08 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/19698 [SPARK-20648][core] Port JobsTab and StageTab to the new UI backend. This change is a little larger because there's a whole lot of logic behind these pages, all really tied to internal types and