Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r224969136
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -64,7 +64,8 @@ case class InMemoryRelation(
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20560
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r181272920
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -733,6 +735,17 @@ object EliminateSorts extends
Github user henryr commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r181253369
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -733,6 +735,17 @@ object EliminateSorts extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180716400
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -169,4 +169,6 @@ case class InMemoryRelation(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180716173
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -22,10 +22,11 @@ import org.apache.spark.sql.{execution, Row}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180716049
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -169,4 +169,6 @@ case class InMemoryRelation(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180715118
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -733,6 +735,17 @@ object EliminateSorts extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180714835
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -274,3 +279,7 @@ abstract class BinaryNode
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180664857
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -733,6 +735,17 @@ object EliminateSorts extends
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180664561
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -274,3 +279,7 @@ abstract class BinaryNode
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180664594
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -22,10 +22,11 @@ import org.apache.spark.sql.{execution, Row}
Github user henryr commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r179003707
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -274,3 +279,7 @@ abstract class BinaryNode
Github user henryr commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180601594
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -733,6 +735,17 @@ object EliminateSorts extends
Github user henryr commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180592716
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -22,10 +22,11 @@ import org.apache.spark.sql.{execution, Row}
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180397806
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -522,6 +524,8 @@ case class Range(
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180390907
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -197,6 +198,19 @@ class PlannerSuite extends SharedSQLContext {
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180389105
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantSortsSuite.scala
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180389667
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -733,6 +735,17 @@ object EliminateSorts extends
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180390730
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
@@ -197,6 +198,19 @@ class PlannerSuite extends SharedSQLContext {
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180390139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -522,6 +524,8 @@ case class Range(
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180389285
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantSortsSuite.scala
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r179120037
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -43,11 +43,12 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r179044224
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -867,6 +871,11 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r179043920
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -43,11 +43,12 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r179043789
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -733,6 +735,17 @@ object EliminateSorts extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r179043661
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -733,6 +735,17 @@ object EliminateSorts extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r178327617
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -219,6 +219,11 @@ abstract class LogicalPlan
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r178327166
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -219,6 +219,11 @@ abstract class LogicalPlan
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r178328886
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -733,6 +735,17 @@ object EliminateSorts extends
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/20560
[SPARK-23375][SQL] Eliminate unneeded Sort in Optimizer
## What changes were proposed in this pull request?
Added a new rule to remove Sort operation when its child is already sorted.
31 matches
Mail list logo
