Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22959
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22959#discussion_r237587099
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -112,125 +72,139 @@ private[spark] case c
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22959#discussion_r237313976
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -112,125 +72,139 @@ private[spark] case
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22959#discussion_r234774528
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/HadoopConfExecutorFeatureStep.scala
---
@@ -28,21 +26,15
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22959#discussion_r234775406
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala
---
@@ -16,40 +16,45
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22959#discussion_r234773869
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -85,7 +83,7 @@ pri
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22959#discussion_r234773904
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -124,7 +122,7 @@ p
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22959#discussion_r234774586
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/HadoopSparkUserExecutorFeatureStep.scala
---
@@ -16,28 +
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22959#discussion_r234774673
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala
---
@@ -16,40 +16,45
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22959#discussion_r231838596
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -112,125 +72,139 @@ private[spark] case c
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/22959
[SPARK-25876][k8s] Simplify kubernetes configuration types.
There are a few issues with the current configuration types used in
the kubernetes backend:
- they use type parameters for rol
11 matches
Mail list logo
