beliefer commented on PR #43958:
URL: https://github.com/apache/spark/pull/43958#issuecomment-1849916583
Merged to Master.
@cloud-fan Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
beliefer closed pull request #43958: [SPARK-45649][SQL] Unify the prepare
framework for OffsetWindowFunctionFrame
URL: https://github.com/apache/spark/pull/43958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421875728
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -230,7 +242,9 @@ class FrameLessOffsetWindowFunctionFrame(
//
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421871101
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -230,7 +242,9 @@ class FrameLessOffsetWindowFunctionFrame(
//
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421686370
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -230,7 +242,9 @@ class FrameLessOffsetWindowFunctionFrame(
//
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421675231
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -176,6 +179,31 @@ abstract class OffsetWindowFunctionFrameBase(
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421674337
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -284,7 +307,9 @@ class FrameLessOffsetWindowFunctionFrame(
}
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421504478
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -284,7 +307,9 @@ class FrameLessOffsetWindowFunctionFrame(
}
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421504291
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -176,6 +179,31 @@ abstract class OffsetWindowFunctionFrameBase(
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421503302
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -284,7 +307,9 @@ class FrameLessOffsetWindowFunctionFrame(
}
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421503302
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -284,7 +307,9 @@ class FrameLessOffsetWindowFunctionFrame(
}
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421502414
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -176,6 +179,31 @@ abstract class OffsetWindowFunctionFrameBase(
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421502414
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -176,6 +179,31 @@ abstract class OffsetWindowFunctionFrameBase(
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1405787265
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -175,6 +178,23 @@ abstract class OffsetWindowFunctionFrameBase(
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421411335
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -317,34 +342,24 @@ class UnboundedOffsetWindowFunctionFrame(
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421410047
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -284,7 +307,9 @@ class FrameLessOffsetWindowFunctionFrame(
}
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421397347
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -196,24 +225,19 @@ class FrameLessOffsetWindowFunctionFrame(
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421258729
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -317,34 +342,24 @@ class UnboundedOffsetWindowFunctionFrame(
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421255750
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -284,7 +307,9 @@ class FrameLessOffsetWindowFunctionFrame(
}
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421255704
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -196,24 +225,19 @@ class FrameLessOffsetWindowFunctionFrame(
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1421255497
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -196,24 +225,19 @@ class FrameLessOffsetWindowFunctionFrame(
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1413464275
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -317,32 +339,17 @@ class UnboundedOffsetWindowFunctionFrame(
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1413423471
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -317,32 +339,17 @@ class UnboundedOffsetWindowFunctionFrame(
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1413422198
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -196,24 +225,16 @@ class FrameLessOffsetWindowFunctionFrame(
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1413421839
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -196,24 +225,16 @@ class FrameLessOffsetWindowFunctionFrame(
beliefer commented on PR #43958:
URL: https://github.com/apache/spark/pull/43958#issuecomment-1837895892
In fact, not only can it reduce code, but it can also reuse code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
beliefer commented on PR #43958:
URL: https://github.com/apache/spark/pull/43958#issuecomment-1836985636
> I don't see much value of this refactor. It doesn't reduce the code size
much, and doesn't make the code more readable to me.
OK. This PR also suppose to add two test cases. We
cloud-fan commented on PR #43958:
URL: https://github.com/apache/spark/pull/43958#issuecomment-1836129316
I don't see much value of this refactor. It doesn't reduce the code size
much, and doesn't make the code more readable to me.
--
This is an automated message from the Apache Git
beliefer commented on PR #43958:
URL: https://github.com/apache/spark/pull/43958#issuecomment-1828916353
The GA failure is unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1405787265
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -175,6 +178,23 @@ abstract class OffsetWindowFunctionFrameBase(
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1405543679
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -196,24 +216,15 @@ class FrameLessOffsetWindowFunctionFrame(
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1405543679
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -196,24 +216,15 @@ class FrameLessOffsetWindowFunctionFrame(
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1405407470
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -196,24 +216,15 @@ class FrameLessOffsetWindowFunctionFrame(
beliefer commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1405397072
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -175,6 +178,23 @@ abstract class OffsetWindowFunctionFrameBase(
cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1405122383
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -175,6 +178,23 @@ abstract class OffsetWindowFunctionFrameBase(
beliefer commented on PR #43958:
URL: https://github.com/apache/spark/pull/43958#issuecomment-1825562137
> Can you explain what gets fixed in this new attempt?
I added some description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
cloud-fan commented on PR #43958:
URL: https://github.com/apache/spark/pull/43958#issuecomment-1824445121
Can you explain what gets fixed in this new attempt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
beliefer opened a new pull request, #43958:
URL: https://github.com/apache/spark/pull/43958
### What changes were proposed in this pull request?
Currently, the implementation of the `prepare` of all the
`OffsetWindowFunctionFrame` have the same code logic show below.
```
override
cloud-fan commented on code in PR #43507:
URL: https://github.com/apache/spark/pull/43507#discussion_r1400162514
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -196,24 +224,15 @@ class FrameLessOffsetWindowFunctionFrame(
cloud-fan commented on PR #43507:
URL: https://github.com/apache/spark/pull/43507#issuecomment-1820405407
This has been reverted. See the reason in
https://issues.apache.org/jira/browse/SPARK-45649
--
This is an automated message from the Apache Git Service.
To respond to the message,
beliefer commented on PR #43507:
URL: https://github.com/apache/spark/pull/43507#issuecomment-1783758706
@cloud-fan Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cloud-fan closed pull request #43507: [SPARK-45649][SQL] Unify the prepare
framework for `OffsetWindowFunctionFrame`
URL: https://github.com/apache/spark/pull/43507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cloud-fan commented on PR #43507:
URL: https://github.com/apache/spark/pull/43507#issuecomment-1782942277
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
beliefer commented on code in PR #43507:
URL: https://github.com/apache/spark/pull/43507#discussion_r1374123448
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -175,6 +178,23 @@ abstract class OffsetWindowFunctionFrameBase(
cloud-fan commented on code in PR #43507:
URL: https://github.com/apache/spark/pull/43507#discussion_r1374095537
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -284,7 +293,7 @@ class FrameLessOffsetWindowFunctionFrame(
}
cloud-fan commented on code in PR #43507:
URL: https://github.com/apache/spark/pull/43507#discussion_r1374093866
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -175,6 +178,23 @@ abstract class OffsetWindowFunctionFrameBase(
beliefer commented on code in PR #43507:
URL: https://github.com/apache/spark/pull/43507#discussion_r1374004543
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -284,7 +293,7 @@ class FrameLessOffsetWindowFunctionFrame(
}
cloud-fan commented on code in PR #43507:
URL: https://github.com/apache/spark/pull/43507#discussion_r1373100286
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -284,7 +293,7 @@ class FrameLessOffsetWindowFunctionFrame(
}
beliefer commented on PR #43507:
URL: https://github.com/apache/spark/pull/43507#issuecomment-1780978940
The GA failure is unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
beliefer commented on code in PR #43507:
URL: https://github.com/apache/spark/pull/43507#discussion_r1372717736
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -284,7 +293,7 @@ class FrameLessOffsetWindowFunctionFrame(
}
cloud-fan commented on code in PR #43507:
URL: https://github.com/apache/spark/pull/43507#discussion_r1372650267
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -284,7 +293,7 @@ class FrameLessOffsetWindowFunctionFrame(
}
cloud-fan commented on code in PR #43507:
URL: https://github.com/apache/spark/pull/43507#discussion_r1372646818
##
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##
@@ -175,6 +176,23 @@ abstract class OffsetWindowFunctionFrameBase(
beliefer commented on PR #43507:
URL: https://github.com/apache/spark/pull/43507#issuecomment-1778923842
ping @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
beliefer commented on PR #43507:
URL: https://github.com/apache/spark/pull/43507#issuecomment-1778721347
The GA failure is unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
beliefer opened a new pull request, #43507:
URL: https://github.com/apache/spark/pull/43507
### What changes were proposed in this pull request?
Currently, the implementation of the `prepare` of all the
`OffsetWindowFunctionFrame` have the same code logic show below.
```
override
55 matches
Mail list logo
