cloud-fan closed pull request #46618: [SPARK-48159][SQL] Extending support for
collated strings on datetime expressions
URL: https://github.com/apache/spark/pull/46618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
cloud-fan commented on PR #46618:
URL: https://github.com/apache/spark/pull/46618#issuecomment-2135727861
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
nebojsa-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1610009218
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1587,237 @@ class CollationSQLExpressionsSuite
})
}
+ t
uros-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1606726766
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1587,237 @@ class CollationSQLExpressionsSuite
})
}
+ test
nebojsa-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1606703312
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1587,237 @@ class CollationSQLExpressionsSuite
})
}
+ t
uros-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1606554130
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1587,237 @@ class CollationSQLExpressionsSuite
})
}
+ test
uros-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1604620097
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1584,234 @@ class CollationSQLExpressionsSuite
})
}
+ test
uros-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1604614789
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1584,234 @@ class CollationSQLExpressionsSuite
})
}
+ test
uros-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1604612518
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1584,234 @@ class CollationSQLExpressionsSuite
})
}
+ test
uros-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1604611590
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1584,234 @@ class CollationSQLExpressionsSuite
})
}
+ test
uros-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1604609258
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1584,234 @@ class CollationSQLExpressionsSuite
})
}
+ test
uros-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1604608546
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1584,234 @@ class CollationSQLExpressionsSuite
})
}
+ test
nebojsa-db commented on PR #46618:
URL: https://github.com/apache/spark/pull/46618#issuecomment-2115535153
@cloud-fan Please review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
mihailom-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1603211716
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1584,240 @@ class CollationSQLExpressionsSuite
})
}
+
mihailom-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1603210909
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala:
##
@@ -2938,20 +2940,20 @@ case class Extract(field: Expression,
mihailom-db commented on code in PR #46618:
URL: https://github.com/apache/spark/pull/46618#discussion_r1603212139
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1584,6 +1584,240 @@ class CollationSQLExpressionsSuite
})
}
+
nebojsa-db commented on PR #46618:
URL: https://github.com/apache/spark/pull/46618#issuecomment-2115033658
Please take a look @nikolamand-db @stefankandic @uros-db @mihailom-db
@dbatomic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nebojsa-db opened a new pull request, #46618:
URL: https://github.com/apache/spark/pull/46618
### What changes were proposed in this pull request?
This PR introduces changes that will allow for collated strings to be passed
to various datetime expressions or return value as collated strin
18 matches
Mail list logo
