Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-18 Thread via GitHub
HyukjinKwon closed pull request #45931: [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec URL: https://github.com/apache/spark/pull/45931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-18 Thread via GitHub
HyukjinKwon commented on PR #45931: URL: https://github.com/apache/spark/pull/45931#issuecomment-2063164089 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-16 Thread via GitHub
guixiaowen commented on PR #45931: URL: https://github.com/apache/spark/pull/45931#issuecomment-2060168379 > Could you add one test case like `EXPLAIN ... LIMIT ... OFFSET ... ORDER BY ...` at https://github.com/apache/spark/blob/master/sql/core/src/test/resources/sql-tests/inputs/explain.s

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-16 Thread via GitHub
guixiaowen commented on code in PR #45931: URL: https://github.com/apache/spark/pull/45931#discussion_r1567621607 ## sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala: ## @@ -358,7 +358,8 @@ case class TakeOrderedAndProjectExec( val orderByString = truncate

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-16 Thread via GitHub
guixiaowen commented on PR #45931: URL: https://github.com/apache/spark/pull/45931#issuecomment-2059429386 > Could you add one test case like `EXPLAIN ... LIMIT ... OFFSET ... ORDER BY ...` at https://github.com/apache/spark/blob/master/sql/core/src/test/resources/sql-tests/inputs/explain.s

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-16 Thread via GitHub
beliefer commented on PR #45931: URL: https://github.com/apache/spark/pull/45931#issuecomment-2059030991 Could you add one test case like `EXPLAIN ... LIMIT ... OFFSET ... ORDER BY ...` int `explain.sql` ? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-16 Thread via GitHub
beliefer commented on code in PR #45931: URL: https://github.com/apache/spark/pull/45931#discussion_r1567314958 ## sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala: ## @@ -358,7 +358,8 @@ case class TakeOrderedAndProjectExec( val orderByString = truncatedS

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-16 Thread via GitHub
beliefer commented on code in PR #45931: URL: https://github.com/apache/spark/pull/45931#discussion_r1567304723 ## sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala: ## @@ -358,7 +358,8 @@ case class TakeOrderedAndProjectExec( val orderByString = truncatedS

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-16 Thread via GitHub
guixiaowen commented on code in PR #45931: URL: https://github.com/apache/spark/pull/45931#discussion_r1567204208 ## sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala: ## @@ -358,7 +358,8 @@ case class TakeOrderedAndProjectExec( val orderByString = truncate

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-16 Thread via GitHub
beliefer commented on code in PR #45931: URL: https://github.com/apache/spark/pull/45931#discussion_r1567035887 ## sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala: ## @@ -358,7 +358,8 @@ case class TakeOrderedAndProjectExec( val orderByString = truncatedS

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-15 Thread via GitHub
guixiaowen commented on code in PR #45931: URL: https://github.com/apache/spark/pull/45931#discussion_r1566636044 ## sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala: ## @@ -358,7 +358,9 @@ case class TakeOrderedAndProjectExec( val orderByString = truncate

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-15 Thread via GitHub
amaliujia commented on code in PR #45931: URL: https://github.com/apache/spark/pull/45931#discussion_r1566291325 ## sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala: ## @@ -358,7 +358,9 @@ case class TakeOrderedAndProjectExec( val orderByString = truncated

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-15 Thread via GitHub
guixiaowen commented on code in PR #45931: URL: https://github.com/apache/spark/pull/45931#discussion_r1566011613 ## sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala: ## @@ -358,7 +358,8 @@ case class TakeOrderedAndProjectExec( val orderByString = truncate

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-09 Thread via GitHub
guixiaowen commented on code in PR #45931: URL: https://github.com/apache/spark/pull/45931#discussion_r1558776883 ## sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala: ## @@ -358,7 +358,8 @@ case class TakeOrderedAndProjectExec( val orderByString = truncate

Re: [PR] [SPARK-47767][SQL] Show offset value in TakeOrderedAndProjectExec [spark]

2024-04-08 Thread via GitHub
HyukjinKwon commented on code in PR #45931: URL: https://github.com/apache/spark/pull/45931#discussion_r1556759763 ## sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala: ## @@ -358,7 +358,8 @@ case class TakeOrderedAndProjectExec( val orderByString = truncat