[GitHub] spark pull request #20700: [SPARK-23546][SQL] Refactor stateless methods/val...

2018-03-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20700#discussion_r171774915 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -833,8 +669,8 @@ class CodegenContext {

[GitHub] spark issue #20715: [SPARK-23434][SQL][BRANCH-2.2] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87874/ Test PASSed. ---

[GitHub] spark pull request #20700: [SPARK-23546][SQL] Refactor stateless methods/val...

2018-03-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20700#discussion_r171773544 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -537,13 +537,38 @@ class CodegenContext {

[GitHub] spark pull request #20700: [SPARK-23546][SQL] Refactor stateless methods/val...

2018-03-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20700#discussion_r171774581 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -734,23 +734,26 @@ case class Cast(child: Expression, data

[GitHub] spark issue #20715: [SPARK-23434][SQL][BRANCH-2.2] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20715 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20713 **[Test build #87875 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87875/testReport)** for PR 20713 at commit [`fd538ca`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87875/ Test PASSed. ---

[GitHub] spark issue #20713: [SPARK-23434][SQL][BRANCH-2.3] Spark should not warn `me...

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20713 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

<    2   3   4   5   6   7