Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20774
**[Test build #88346 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88346/testReport)**
for PR 20774 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20774
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20851
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88344/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20774
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88346/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20851
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175281445
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2063,4 +2063,178 @@ class JsonSuite extends
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175281373
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2063,4 +2063,178 @@ class JsonSuite extends
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175281468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -85,6 +85,12 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175281525
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2063,4 +2063,178 @@ class JsonSuite extends
GitHub user misutoth opened a pull request:
https://github.com/apache/spark/pull/20853
[SPARK-23729][SS] Glob resolution is done without the fragment part which
is meant to be the remote name
## What changes were proposed in this pull request?
Firstly, glob resolution will
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20774
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1584/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1585/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88347 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88347/testReport)**
for PR 20850 at commit
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175280808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -85,6 +85,12 @@ private[sql] class JSONOptions(
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175281238
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2063,4 +2063,178 @@ class JsonSuite extends
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175281528
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2063,4 +2063,178 @@ class JsonSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20853
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20853
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20774
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20774
**[Test build #88346 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88346/testReport)**
for PR 20774 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88347 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88347/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88347/
Test FAILed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175281365
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -85,6 +85,12 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175281639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -85,6 +85,12 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175281659
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2063,4 +2063,178 @@ class JsonSuite extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20686
Thanks. For branch testing, I was confused with maven testing. Since you
create a PR against `branch-2.3`, it looks okay.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20852
Hi, @yanboliang and @jkbradley .
`branch-2.3` is broken. Could you review this PR?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20742
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88358/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20742
**[Test build #88358 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88358/testReport)**
for PR 20742 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20742
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ConeyLiu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20844#discussion_r175315224
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -396,9 +396,11 @@ case class RangeExec(range:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20774
cc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20851#discussion_r175320790
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -353,6 +353,12 @@ object SQLConf {
.booleanConf
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20827
**[Test build #88361 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88361/testReport)**
for PR 20827 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88361/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175332253
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -342,8 +349,8 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175332620
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -1251,18 +1251,40 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175332237
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -125,29 +125,36 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175332723
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql ---
@@ -39,3 +43,4 @@ select 2.0 <= '2.2';
select 0.5 <= '1.5';
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20798#discussion_r175332763
--- Diff: python/pyspark/sql/functions.py ---
@@ -2155,6 +2155,8 @@ def udf(f=None, returnType=StringType()):
in boolean expressions and it
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175332743
--- Diff: docs/sql-programming-guide.md ---
@@ -2289,6 +2289,13 @@ Spark SQL supports the vast majority of Hive
features, such as:
* `MAP<>`
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175334948
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql ---
@@ -39,3 +43,4 @@ select 2.0 <= '2.2';
select 0.5 <= '1.5';
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20847
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20847
@mgaido91 would you please create a JIRA to track all the UT failures.
Hopes someone familiar with that part could fix them.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20847
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1599/
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r175334935
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20847
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r175336924
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -155,6 +155,7 @@ class QueryExecution(val sparkSession:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20806
@WeichenXu123 As the discussion with @cloud-fan at
https://github.com/apache/spark/pull/20806#discussion_r174277864, I'd like to
see some performance gain it, but I need to run benchmark to see if
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20856
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20856
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20856
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1597/
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/20699
cc @hvanhovell , @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20856
I think that this problem does not depend on data. Can you create a test
case by modifying the query slightly with different column names?
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20827
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20827
The fix looks good to me. Since it changes the external name, could you add
it to the migration guide?
---
-
To unsubscribe,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20846
We do not allow users to change the table column type. Currently, only the
column comments are allowed to change if users issue the command through Spark.
However, users still can change it
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20856
What is the test case?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r175330576
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175333760
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -479,6 +479,15 @@ object SQLConf {
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20830
@BryanCutler, could I have the very first PR merged by you as a new fresh
committer :-)?
I personally think it might be good to merge to branch-2.3 if it doesn't
have conflicts. If it
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r175336329
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -155,6 +155,7 @@ class QueryExecution(val sparkSession:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20856
**[Test build #88362 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88362/testReport)**
for PR 20856 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20719#discussion_r175321399
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -170,6 +171,13 @@ private[evaluation] abstract class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20856
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88362/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20856
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r175324999
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20851
cc @michal-databricks @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20827
**[Test build #88363 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88363/testReport)**
for PR 20827 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1598/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175333714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -479,6 +479,15 @@ object SQLConf {
Github user henryr commented on the issue:
https://github.com/apache/spark/pull/20687
@gatorsmile thank you for the reviews! Are there specific test cases you'd
like to see? I've checked correlated and uncorrelated subqueries, various
flavours of join, aggregates with HAVING clauses,
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20845
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20845
@caneGuy it is not necessary to create a JIRA for such tiny fix.
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20795
Please ping me if this is ready to review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1596/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20827
**[Test build #88361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88361/testReport)**
for PR 20827 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20851#discussion_r175317152
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -50,6 +51,15 @@ private[parquet] object
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20856
**[Test build #88362 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88362/testReport)**
for PR 20856 at commit
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/20845
@jiangxb1987 @Ngone51 Thanks! Any more comments?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20827
ok, I'll update soon.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user manku-timma commented on a diff in the pull request:
https://github.com/apache/spark/pull/20851#discussion_r175327686
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -72,6 +82,15 @@ private[parquet]
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20798#discussion_r175332547
--- Diff: docs/sql-programming-guide.md ---
@@ -1799,6 +1799,12 @@ different than a Pandas timestamp. It is recommended
to use Pandas time series f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20847
**[Test build #88364 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88364/testReport)**
for PR 20847 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175335072
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -479,6 +479,15 @@ object SQLConf {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175335261
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -479,6 +479,15 @@ object SQLConf {
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20687
@henryr Please try to add the test cases that matter in your opinion. I
will also submit a follow-up PR to add more test cases after this PR is merged.
---
101 - 193 of 193 matches
Mail list logo
