Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23017#discussion_r233959468
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile ---
@@ -53,5 +54,9 @@ COPY data /opt/spark/data
ENV SPARK_HOME
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23017#discussion_r233960280
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala
---
@@
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98872/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23017
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23049
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98876/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23049
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23040
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98878/
Test PASSed.
---
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23049
The reason why it mentioned `spark-env-sh` is because that is a script that
is loaded by `load-spark-env.sh` and is user-defined. From that script:
```
if [ -f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98880/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23041
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23041
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22875
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22875
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98874/
Test PASSed.
---
Github user squito commented on the issue:
https://github.com/apache/spark/pull/23041
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23050
**[Test build #98886 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98886/testReport)**
for PR 23050 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23049
**[Test build #98879 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98879/testReport)**
for PR 23049 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
**[Test build #98880 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98880/testReport)**
for PR 22911 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23034
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rvesse commented on the issue:
https://github.com/apache/spark/pull/23013
@srowen I'm happy with it
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23034
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98871/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23017
**[Test build #98872 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98872/testReport)**
for PR 23017 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23026
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23026
LGTM. Will leave it up for a while in case anyone wants to comment.
Also will re-trigger tests... not sure why integration tests didn't run.
---
Github user uzadude commented on a diff in the pull request:
https://github.com/apache/spark/pull/23042#discussion_r233972629
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -138,6 +138,11 @@ object TypeCoercion {
Github user j-baker commented on the issue:
https://github.com/apache/spark/pull/22946
Hm, it seems that we consider this behaviour to be a feature, and there is
a test for this specific thing. This PR would additionally break the code:
```sql
CREATE TABLE t5(i1 INT, t5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23026
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23026
**[Test build #98883 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98883/testReport)**
for PR 23026 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23026
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98883/
Test PASSed.
---
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/22911
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/23050
[SPARK-26079][sql] Ensure listener event delivery in
StreamingQueryListenersConfSuite.
Events are dispatched on a separate thread, so need to wait for them to be
actually delivered before
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23031#discussion_r233987571
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -17,6 +17,8 @@ displayTitle: Spark SQL Upgrading Guide
- The `ADD JAR` command previously
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23049#discussion_r234003620
--- Diff: bin/load-spark-env.sh ---
@@ -42,19 +42,20 @@ fi
# Setting SPARK_SCALA_VERSION if not already set.
if [ -z "$SPARK_SCALA_VERSION"
GitHub user MaxGekk opened a pull request:
https://github.com/apache/spark/pull/23052
[SPARK-26081][SQL] Prevent empty files for empty partitions in Text
datasources
## What changes were proposed in this pull request?
In the PR, I propose to postpone creation of
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23026
**[Test build #98883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98883/testReport)**
for PR 23026 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/23041
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22598
**[Test build #98873 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98873/testReport)**
for PR 22598 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
**[Test build #98885 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98885/testReport)**
for PR 22911 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23044
**[Test build #98875 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98875/testReport)**
for PR 23044 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23031#discussion_r233986989
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala
---
@@ -154,5 +154,9 @@ class RuntimeConfig private[sql](sqlConf: SQLConf = new
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23052
**[Test build #98887 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98887/testReport)**
for PR 23052 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98884/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23041
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23041
**[Test build #98884 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98884/testReport)**
for PR 23041 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/23041
failure from another flaky, SPARK-24153
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23041
**[Test build #4427 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4427/testReport)**
for PR 23041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23037
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23037
**[Test build #98889 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98889/testReport)**
for PR 23037 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23037
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98889/
Test PASSed.
---
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23038#discussion_r234034325
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -63,6 +63,7 @@ case class ApplicationAttemptInfo private[spark](
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98882/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22598
**[Test build #98890 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98890/testReport)**
for PR 22598 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23017
**[Test build #98882 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98882/testReport)**
for PR 23017 at commit
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r234037129
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala ---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23039
How about the following?
```
Move `truncatedString` to `sql/catalyst` and add
`spark.sql.debug.maxToStringFields` conf
```
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23050
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23050
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98886/
Test PASSed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23034
Also, @BryanCutler, I think we can talk about locations of
`testing/...util.py` later when we finished to split the tests. Moving utils
would probably cause less conflicts and should be good
Github user ramaddepally commented on the issue:
https://github.com/apache/spark/pull/23053
@vanzin .. can you please review this change?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23053
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23026
**[Test build #9 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/9/testReport)**
for PR 23026 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23026
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/23024
Thank you @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23037
This is fine, but please file a bug.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23037
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/23026
> if such a list exists it should be the same list that triggers regular
tests.
I differ that to @shaneknapp
---
-
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23038#discussion_r234032510
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -63,6 +63,7 @@ case class ApplicationAttemptInfo private[spark](
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23038#discussion_r234032990
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -63,6 +63,7 @@ case class ApplicationAttemptInfo private[spark](
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
**[Test build #98885 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98885/testReport)**
for PR 22911 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23053
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user ramaddepally opened a pull request:
https://github.com/apache/spark/pull/23053
[SPARK-25957][K8S] Add ability to skip building optional k8s docker iâ¦
â¦mages
## What changes were proposed in this pull request?
bin/docker-image-tool.sh tries to build all docker
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23053
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23052
@MaxGekk, actually this is kind of important behaviour change. This
basically means we're unable to read the empty files back. Similar changes were
proposed in Parquet few years ago (by me) and
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23026
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23026
if such a list exists it should be the same list that triggers regular
tests.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23037
**[Test build #98889 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98889/testReport)**
for PR 23037 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23045#discussion_r234037904
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala
---
@@ -46,12 +46,20 @@ object TypeUtils {
if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23017
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r234040048
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala ---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r234043117
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala ---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23034
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23034
@BryanCutler, should be ready to work on ML and MLlib as well.
---
-
To unsubscribe, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23034
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/23026
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23026
**[Test build #9 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/9/testReport)**
for PR 23026 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23026
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/9/
Test PASSed.
---
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22999
cc @gatorsmile @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/23026
@vanzin, I added you to the admin list for triggering the
`testing-k8s-prb-make-spark-distribution-unified`
---
-
To
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23038#discussion_r234028545
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -63,6 +63,7 @@ case class ApplicationAttemptInfo private[spark](
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/23037
> This is fine, but please file a bug.
Okay, as such, @AzureQ could you add an integration test to
`ClientModeTestsSuite`
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23050
**[Test build #98886 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98886/testReport)**
for PR 23050 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98885/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23047
Merged to branch-2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23052
**[Test build #98887 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98887/testReport)**
for PR 23052 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23052
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98887/
Test PASSed.
---
101 - 200 of 453 matches
Mail list logo
