Github user dbtsai closed the pull request at:
https://github.com/apache/spark/pull/1518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7037#discussion_r33546141
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -82,6 +82,15 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7037#issuecomment-117831062
@holdenk Cool. I'll work on this tonight. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7080#discussion_r33752237
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -292,20 +317,51 @@ class LogisticRegressionSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7080#discussion_r33749927
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -98,6 +98,15 @@ class LogisticRegression(override val uid
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/7245
[SPARK-8845] [ML] ML use of Breeze optimization: use adjustedValue instead
of value
In LinearRegression and LogisticRegression, we use Breeze's optimizers
(LBFGS and OWLQN). We check
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r33988929
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -194,10 +203,15 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r33999324
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -194,10 +203,15 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r34002394
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -212,12 +230,139 @@ class LinearRegressionModel private[ml
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r34002320
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -140,7 +142,16 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30955127
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -363,4 +370,36 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30955123
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -160,8 +165,8 @@ class LogisticRegression(override val uid
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30955096
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -106,6 +106,11 @@ class LogisticRegression(override val uid
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30955188
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -106,6 +106,11 @@ class LogisticRegression(override val uid
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30955674
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -363,4 +370,34 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30955191
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -363,4 +370,36 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30958988
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -363,4 +370,34 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30996105
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -363,4 +370,34 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30996268
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -160,8 +168,8 @@ class LogisticRegression(override val uid
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30996185
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -100,12 +100,20 @@ class LogisticRegression(override val
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30996190
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -100,12 +100,20 @@ class LogisticRegression(override val
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r30996184
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -100,12 +100,20 @@ class LogisticRegression(override val
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r34015538
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -212,12 +230,139 @@ class LinearRegressionModel private[ml
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7099#issuecomment-119107982
In general, the losses returned from optimizer are for debugging purpose,
and users can see how well the optimizer works. The reason is the real
statistical metrics
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r34015350
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -212,12 +230,139 @@ class LinearRegressionModel private[ml
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/7884
[SPARK-7685][ML] Apply weights to different samples in Logistic Regression
In fraud detection dataset, almost all the samples are negative while only
couple of them are positive. This type of high
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8079#issuecomment-130084832
Then the most easy way is probably just overwriting the other when one is
set. :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7518#issuecomment-132003927
Thanks. Merged into master and 1.5 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-134246783
Hello @jkbradley @mengxr, this is ready to be reviewed. Do you have a
chance to have a pass on this PR? Thanks.
---
If your project is set up for it, you can reply
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/7080
[SPARK-8700][ML] Disable feature scaling in Logistic Regression
All compressed sensing applications, and some of the regression use-cases
will have better result by turning the feature scaling off
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7080#discussion_r33532097
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -208,8 +208,11 @@ class LogisticRegressionSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7080#discussion_r33532011
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -534,27 +554,39 @@ private class LogisticCostFun
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7080#issuecomment-116955865
Jenkins, please test again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7080#issuecomment-117001396
Jenkins, please test again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6946#issuecomment-117022967
Merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/7875
[SPARK-8601][ML] Add an option to disable standardization for linear
regression
All compressed sensing applications, and some of the regression use-cases
will have better result by turning
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7875#discussion_r36154117
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -85,6 +85,18 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36162497
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -114,20 +114,40 @@ class LogisticRegression(override val
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36162580
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -451,11 +471,14 @@ private class LogisticAggregator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36162455
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -114,20 +114,40 @@ class LogisticRegression(override val
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36164446
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -114,20 +114,40 @@ class LogisticRegression(override val
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127463103
@jkbradley Sounds fair. I will also add tests now. BTW, can you merge
https://github.com/apache/spark/pull/7875/files which is already ready to be
merged. I will have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127505014
This is very useful for us as well. Our training samples will have
exponential decay weight as time goes by. I am trying to use it now, and it
seems work well
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36162618
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -451,11 +471,14 @@ private class LogisticAggregator
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7875#issuecomment-127461865
cc @jkbradley Can you help me to code review this PR? This one is pretty
much the same as
https://github.com/apache/spark/commit/57221934e0376e5bb8421dc35d4bf91db4deeca1
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7722#issuecomment-127462789
Please add the unit tests. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127507930
Jenkins, please test again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7722#issuecomment-126522448
I will have them in the same `LinearRegression` codebase as @mengxr said.
Almost 90% of the code is the same, and it will be hard to maintain. BTW, I can
take over
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126519222
Are we going to have `invert` or `unapply` in the `Transformer` trait? In
scala, there is an extractor pattern
http://docs.scala-lang.org/tutorials/tour/extractor
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127849756
@rotationsymmetry Please help to create the JIRA. For `LinearRegression`,
that should be smilier to this one. Once this one is merged, we can start to
port
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7875#discussion_r36049732
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -85,6 +85,18 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7875#discussion_r36049752
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -85,6 +85,18 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7875#discussion_r36049772
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -456,6 +480,7 @@ class LinearRegressionSummary private[regression
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7722#issuecomment-126524084
We also need the unit-tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7722#discussion_r35935046
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RobustRegression.scala ---
@@ -0,0 +1,609 @@
+/*
+ * Licensed to the Apache Software
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8079#discussion_r36717291
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -43,36 +42,60 @@ import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8013#discussion_r36719346
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -645,3 +658,80 @@ private class LeastSquaresCostFun
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8013#discussion_r36718311
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -325,4 +325,21 @@ private[ml] trait HasStepSize extends Params
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8079#discussion_r36717693
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -43,36 +42,60 @@ import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8079#discussion_r36717774
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -310,10 +336,12 @@ class LogisticRegressionModel private[ml
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8013#discussion_r36718480
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -325,4 +325,21 @@ private[ml] trait HasStepSize extends Params
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8013#discussion_r36719832
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -505,4 +505,455 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8013#discussion_r36718509
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -123,6 +123,14 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8079#issuecomment-129739762
LGTM except few comments. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8013#discussion_r36718958
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -645,3 +658,80 @@ private class LeastSquaresCostFun
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8013#discussion_r36719632
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -645,3 +658,80 @@ private class LeastSquaresCostFun
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8079#discussion_r36785940
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -43,36 +42,76 @@ import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8079#discussion_r36785932
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -43,36 +42,76 @@ import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8079#discussion_r36786380
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -43,36 +42,76 @@ import
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128289808
Jenkins, please test again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7875#issuecomment-127797035
++1 for refactoring the code so LoR and LiR can share the duplicated code.
I would like to work on it post 1.5.
---
If your project is set up for it, you can reply
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127771793
@jkbradley and @mengxr I had `weightCol` as empty as default in my local
branch. Sorry for confusion. This PR is meant to be WIP to see if we have
enough time to make
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128445677
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128460615
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36226698
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -114,20 +114,40 @@ class LogisticRegression(override val
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36236527
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -88,6 +88,23 @@ private[ml] trait HasLabelCol extends Params
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36237450
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -250,6 +267,23 @@ private[ml] trait HasStandardization extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8013#issuecomment-128749989
Still a lot of duplication. We're adding new features into LiR now, and it
will be hard to maintain. Is it possible that you just add the objective
function, and use
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7518#discussion_r37106956
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala ---
@@ -44,6 +46,9 @@ class LassoModel (
weightMatrix.toBreeze.dot
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7518#discussion_r37106911
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/IsotonicRegression.scala
---
@@ -155,6 +170,9 @@ class IsotonicRegressionModel
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7518#discussion_r37106989
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala ---
@@ -51,8 +56,14 @@ class LassoModel (
override protected def
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7518#discussion_r37106979
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala ---
@@ -51,8 +56,14 @@ class LassoModel (
override protected def
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7518#discussion_r37106918
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/IsotonicRegression.scala
---
@@ -200,6 +218,9 @@ object IsotonicRegressionModel extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7518#discussion_r37106850
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/IsotonicRegression.scala
---
@@ -148,6 +160,9 @@ class IsotonicRegressionModel
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7518#discussion_r37107029
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/RegressionModel.scala ---
@@ -24,6 +24,9 @@ import org.apache.spark.api.java.JavaRDD
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7518#discussion_r37107050
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/RidgeRegression.scala ---
@@ -45,6 +47,9 @@ class RidgeRegressionModel
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7518#discussion_r37107057
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/RidgeRegression.scala ---
@@ -52,8 +57,14 @@ class RidgeRegressionModel (
override
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7518#discussion_r37107067
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/RidgeRegression.scala ---
@@ -52,8 +57,14 @@ class RidgeRegressionModel (
override
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8216#issuecomment-131323524
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-130212953
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8079#issuecomment-130408674
LGTM. Waiting for tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128295310
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128295375
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128302571
@jkbradley and @mengxr This PR is ready for review. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7371#issuecomment-120994938
@mengxr Sure. I will take over. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7553#discussion_r35068701
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -55,6 +56,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7553#issuecomment-123151544
LGTM except minor styling issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7553#discussion_r35068725
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -55,6 +56,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7553#issuecomment-123163210
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/5503#issuecomment-123187717
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
401 - 500 of 1777 matches
Mail list logo
