Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12353#issuecomment-211783888
Now, the followings are updated.
- `maxCaseBranches` is renamed to `maxCaseBranchesForCodegen`.
- object `CaseWhenCodegen` is removed.
- CaseWhen has
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12353#discussion_r60192015
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -864,6 +866,16 @@ object SimplifyConditionals
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12353#issuecomment-209669387
Hi, @rxin .
Now, this PR is ready to be review.
Could you review this please?
---
If your project is set up for it, you can reply to this email and have
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12376
[SPARK-14614] Add `bround` function
## What changes were proposed in this pull request?
This PR aims to add `bound` function (aka Banker's round) by extending
current `round
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59759998
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -529,6 +530,11 @@ object LikeSimplification
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59760094
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -529,6 +530,11 @@ object LikeSimplification
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210078145
I updated to use `pattern`, `prefix`, `postfix`, and **`infix`** (as a
similar manner).
---
If your project is set up for it, you can reply to this email
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210775563
Now, `assert_true` uses implicit type casts. Code is much cleaner.
Also, during reviews, I fixed my critical bug: I missed adding generated
child code
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210762099
I see. I'll use `with ImplicitCastInputTypes`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12353#issuecomment-210762825
Oh, sorry. I didn't say explicitly. I thought updating `private[spark]
trait CodegenConf` into `trait CodegenConf` because CatalystConf changed like
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12376#issuecomment-210780699
Hi, @marmbrus , @davies , @markhamstra .
I'm not sure what to do next for this PR. If I am supposed to do something,
please let me know.
---
If your project
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12535
[SPARK-14765][BUILD] Jenkins should run tests only based on the PR contents
## What changes were proposed in this pull request?
**Background**
Yesterday, when I exposed
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12535#issuecomment-212555720
Thank you for review, @srowen .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12535#issuecomment-212556368
Currently, rebasing needs confidential information. Could you recommend
some?
---
If your project is set up for it, you can reply to this email and have your
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12980#issuecomment-217736741
Thank you for review, @srowen .
I'm not sure the root cause of that. According to the github log, it was
created, [disabled
(HOTFIX)](https://github.com
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12980#issuecomment-217744521
Hi, @srowen . I added `test-compile`, too. You can see the result here.
https://travis-ci.org/dongjoon-hyun/spark/builds/128708372
For your
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-215545987
Hi, @gatorsmile and @cloud-fan .
Could you take a look at this PR when you have some time?
I think you are the best persons to review this PR
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-215547799
Thank you so much, @gatorsmile !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12719#discussion_r62420393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -617,6 +618,77 @@ object NullPropagation extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12719#discussion_r62421170
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -617,6 +618,77 @@ object NullPropagation extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12719#discussion_r62420476
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -617,6 +618,77 @@ object NullPropagation extends
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12980#issuecomment-217683635
Hi, @rxin and @andrewor14 .
I think this is the only way to re-enable Java linter.
---
If your project is set up for it, you can reply to this email and have
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12980#issuecomment-217690316
Definitely, the failure is not related to this PR since this PR just adds
`.travis.yml` file.
```
[error] (mllib/test:test) sbt.TestsFailedException
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-217679449
Since `CleanupAliases` already handles all the corner cases safely,
`FoldablePropagate` optimizer becomes now amazingly simple with one rule:
`AttributeReference
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12980
[SPARK-15207][BUILD] Use Travis CI for Java/Scala/Python Linter and JDK7/8
compilation test
## What changes were proposed in this pull request?
Currently, Java Linter is disabled
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12980#issuecomment-217683609
Travis CI passed. It took less than 25 minutes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12719#issuecomment-217673741
This is the example of DDL command failures: PartitionColumn [a#0] is
replaced with [1 AS a#3].
```
InsertIntoHadoopFsRelation
file:/private/var/folders
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64462691
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -100,8 +118,11 @@ private class
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/13282
[SPARK-15512][CORE] repartition(0) should raise IllegalArgumentException
## What changes were proposed in this pull request?
Previously, SPARK-8893 added the constraints on positive
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/13294
[MINOR][CORE] Fix a HadoopRDD log message and remove unused imports in rdd
files.
## What changes were proposed in this pull request?
This PR fixes the following typos in log
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13294#issuecomment-221635222
Thank you for review, @srowen .
Yep. Those are all I've seen in `core/src/main/scala/../rdd`.
---
If your project is set up for it, you can reply
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/14355
[SPARK-16726][SQL] Improve error message for `Union` queries for
incompatible types
## What changes were proposed in this pull request?
Currently, `UNION` queries on incompatible
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/14353
[SPARK-16714][SQL] `array` should create a decimal array from decimals with
different precisions and scales
## What changes were proposed in this pull request?
In Spark 2.0, we
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14257
Hi, @liancheng and @rxin .
It's not ready for review again.
Thank you always!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r72178111
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,49 @@ class Analyzer
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
Hi, @junyangq .
Could you give me some pointer to understand the current context? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
Thank you, @junyangq .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
Oh, let me try this time. Thank you for double-checking, @junyangq .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
Never. I did that in order to make it sure. I don't do it frequently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14353#discussion_r72185905
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -33,13 +33,24 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14353#discussion_r72186040
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -33,13 +33,24 @@ case class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
```r
> collect(describe(read.json('examples/src/main/resources/people.json')))
summaryagename
1 count 2 3
2m
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
In fact, `count`, `min`, and `max` is supported officially for
Scala/Python/R.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14307
Thank you so much for review and merging, @rxin , @hvanhovell , and
@jaceklaskowski !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
I see. Which version is it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14257#discussion_r72182312
--- Diff: sql/hive/src/test/resources/sqlgen/predicate_subquery.sql ---
@@ -1,4 +1,4 @@
-- This file is automatically generated
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
@junyangq . Currently, you are at the most recent master build, right?
And, SparkR does not show the `name` column as a result of `describe`
command.
I'm wondering the result of `spark
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14307
Hi, @rxin .
Could you merge this PR please?
Since this PR uses `checkSQL`, it will conflict with `Generate stable SQLs
in SQLBuilder`(https://github.com/apache/spark/pull/14257
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14353#discussion_r72185372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -33,13 +33,24 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14257#discussion_r72181359
--- Diff: sql/hive/src/test/resources/sqlgen/predicate_subquery.sql ---
@@ -1,4 +1,4 @@
-- This file is automatically generated
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14353#discussion_r72182807
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -33,13 +33,24 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14353#discussion_r72185594
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -33,13 +33,24 @@ case class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
Hi, @shivaram.
Sorry, but what is the problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
String columns works for `min` and `max` summarization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
Hi, @shivaram .
It's due to the branch difference.
The PR is merged to the master only 17 days ago.
> Thanks - merging in master.
---
If your project is set up for it, you
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r72182414
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,49 @@ class Analyzer
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
I think you did something wrong. :)
Could you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
Actually, you can see the Jenkins log, too. There is no problem with the
current R testsuite.
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62858/consoleFull
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14353#discussion_r72186016
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -33,13 +33,24 @@ case class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
If you use `-fdx`, it removes IDE like Intellij settings, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
It's my pleasure. See you later around Apache Spark. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
I see. That seems 2.0 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14357
At the most recent master build, I did the following things and all tests
are passed.
```
$ git clean -fdx
$ ./build/sbt -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive-thriftserver
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14373
Oops. I added a useless comment and removed it. Sorry. Never mind that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14353#discussion_r72375060
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -33,13 +33,24 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14373#discussion_r72352218
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -608,7 +608,8 @@ private[execution] final class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14374
Hi, @biglobster .
You had better make a Jira for this and update the title of this PR
accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14116
Hi, @rxin .
I implemented the full feature.
Could you review INFORMATION_SCHEMA PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14086
Hi, @srowen .
I'm looking at your advice more. Here is my summary so far in general.
**SaveMode.TRUNCATE**
- Truncate the content only, not a structure of existing data source
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70525213
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -86,6 +86,7 @@ class Analyzer
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14132
I'm back. I'll resolve them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14132
So far, I couldn't do the following two advices. I just inform you that I'm
still working these. :)
- `HINT_PREFIX`
- `| hintName=identifier '(' parameters+=identifier parameters
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14116
Spark temporary views (tables) are included, too. When you specify any
databases, `show tables` also returns the tables of the database and the Spark
temporary table.
---
If your project
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14116
Actually, this PR makes that test more robust generally.
But, at the final commit of this PR, if this is not required, I will revert
the change on R side in order to make PR smaller
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14199
Thank you, @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14132
Hi, @rxin and @hvanhovell .
Could you review this `HINT` PR when you have some time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14184
Oh, thank you, @liancheng !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14195
Great. This is in 2.0!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70867113
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -399,7 +402,16 @@ class AstBuilder extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14132
I see. Sorry for misunderstanding. Let me summary again. The following is
the final decision, right?
```
SELECT /*+ MAPJOIN(t) */ * FROM t JOIN u ON t.id = u.id
SELECT /*+ MAPJOIN
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14132
Now, both the code and description of this PR is updated. Locally, it
passed `sql/catalyst` and `sql/core`.
---
If your project is set up for it, you can reply to this email and have your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14132
Thank you for confirming!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70883389
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -509,6 +512,23 @@ class AstBuilder extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70876188
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -399,7 +402,16 @@ class AstBuilder extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70883834
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -509,6 +512,23 @@ class AstBuilder extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14132
Thank you for all comments, @hvanhovell and @rxin . I'll update soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70869241
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,39 @@ class Analyzer
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14132
Oh, I see. No problem. Thank you for guide. Then, could you update the JIRA
too? I added this for the following comments.
> For more information, please see the attached document. One n
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70872438
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -399,7 +402,16 @@ class AstBuilder extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70882759
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -509,6 +512,23 @@ class AstBuilder extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70882932
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -945,8 +955,12 @@ SIMPLE_COMMENT
: '--' ~[\r\n
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70884912
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -945,8 +955,12 @@ SIMPLE_COMMENT
: '--' ~[\r\n
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70885529
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,34 @@ class Analyzer
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70889621
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,34 @@ class Analyzer
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r70885361
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -347,6 +347,15 @@ querySpecification
windows
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14132
The following is updated.
- Add more descriptions and test cases (about finding closest table and
nested hint).
- Support no parameter hint like `/*+ INDEX */`.
- Generalize
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71756744
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +443,46 @@ class SQLBuilder(logicalPlan: LogicalPlan
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71756794
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -162,6 +162,9 @@ class SQLBuilder(logicalPlan: LogicalPlan
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71756590
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +449,44 @@ class SQLBuilder(logicalPlan: LogicalPlan
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/14307
[SPARK-16672][SQL] SQLBuilder should not raise exceptions on EXISTS queries
## What changes were proposed in this pull request?
Currently, `SQLBuilder` raises `empty.reduceLeft
1301 - 1400 of 7331 matches
Mail list logo
