Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21359
Oh, thank you, @gatorsmile !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21331#discussion_r18946
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
---
@@ -85,6 +87,14 @@ object Canonicalize
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21331#discussion_r189411395
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
---
@@ -85,6 +87,14 @@ object Canonicalize
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21331#discussion_r189413304
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
---
@@ -85,6 +87,14 @@ object Canonicalize
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21331#discussion_r189413969
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
---
@@ -85,6 +87,14 @@ object Canonicalize
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21368#discussion_r189421121
--- Diff:
repl/scala-2.12/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -37,7 +37,14 @@ class SparkILoop(in0: Option[BufferedReader
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/21372
[SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4
## What changes were proposed in this pull request?
ORC 1.4.4 includes [nine fixes like
ORC-301](https://issues.apache.org/jira
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21299
Hi, @cloud-fan.
This seems to cause a build failure. Could you take a look?
cc @gatorsmile
---
-
To
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
The master branch failure is due to
https://github.com/apache/spark/pull/21299 .
---
-
To unsubscribe, e-mail: reviews
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21299
@viirya and @mgaido91 are working on the build failure, but there seem to
be test failures, too.
Maybe, we had better revert this first to unblock all the PRs
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21374
Hi, @kiszk and @felixcheung .
Unfortunately, the master branch build is broken by
https://github.com/apache/spark/pull/21299
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/21372
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user dongjoon-hyun reopened a pull request:
https://github.com/apache/spark/pull/21372
[SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4
## What changes were proposed in this pull request?
ORC 1.4.4 includes [nine fixes like
ORC-301](https://issues.apache.org/jira
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21372#discussion_r189472897
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnVector.java
---
@@ -136,7 +136,7 @@ public int getInt(int
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21331#discussion_r189483055
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
---
@@ -85,6 +87,14 @@ object Canonicalize
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
Sure, @maropu . In addition, I reviewed the nine patches, almost trivial
ones. I'll update the PR description
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21288#discussion_r189638131
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala
---
@@ -0,0 +1,437
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21372#discussion_r189673786
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnVector.java
---
@@ -136,7 +136,7 @@ public int getInt(int
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21372#discussion_r189674371
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnVector.java
---
@@ -136,7 +136,7 @@ public int getInt(int
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21368#discussion_r189674768
--- Diff:
repl/scala-2.12/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -37,7 +37,14 @@ class SparkILoop(in0: Option[BufferedReader
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20887#discussion_r189707806
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2792,4 +2793,40 @@ class SQLQuerySuite extends QueryTest with
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21372#discussion_r189720311
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnVector.java
---
@@ -136,7 +136,7 @@ public int getInt(int
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20887#discussion_r189740429
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2792,4 +2793,40 @@ class SQLQuerySuite extends QueryTest with
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r189952391
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2408,4 +2409,53 @@ class JsonSuite extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
@HyukjinKwon . Could you review this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21399
This is the one? Finally, nice! @HyukjinKwon .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21295#discussion_r189957937
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala
---
@@ -879,6 +879,18 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21295#discussion_r189960120
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
---
@@ -147,7 +147,8
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r189961165
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1256,8 +1256,18 @@ object SQLConf {
"i
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r189964186
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2408,4 +2409,53 @@ class JsonSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21384#discussion_r189965983
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala
---
@@ -356,6 +356,22 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21372#discussion_r190042175
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnVector.java
---
@@ -136,7 +136,7 @@ public int getInt(int
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
@gatorsmile .
Basically, ORC-301 will reduce the change of ORC file leakage in some
cases. I made that patch and merged it long time ago, but it's released at this
release. Also, OR
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
For file leakage issues, we have been monitoring the flakiness of
SPARK-23458 and SPARK-23390 in our Jenkins environment. Until now, I couldn't
reproduce it lo
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
For Timestamp issue, I'm trying to find some example.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apach
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
For me, those three lines do not throws exceptions. Do you mean another
lines?
```
OrcProto.PostScript ps;
OrcProto.FileTail.Builder fileTailBuilder = OrcProto.FileTail.newBuilder
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
I didn't say ORC-301 resolves the issue of SPARK-23458 and SPARK-23390.
SPARK-23458 and SPARK-23390 reports open file leakages in some unknown
situations, doesn
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21372#discussion_r190073105
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -169,6 +170,14 @@ abstract class
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/21404
[SPARK-24360][SQL] Support Hive 3.0 metastore
## What changes were proposed in this pull request?
Hive 3.0 is released. This PR aims to support Hive 3.0 metastore.
## How
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21404#discussion_r190088876
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala ---
@@ -79,7 +79,12 @@ package object client {
exclusions
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20208
Sorry for the delay. I updated the PR according to the comments,
@gatorsmile .
Could you review this once more
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21404#discussion_r190101719
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -1148,3 +1149,128 @@ private[client] class Shim_v2_1 extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21404
The failures some from `ClassNotFoundException:
org.apache.logging.log4j.util.Strings`.
---
-
To unsubscribe, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21404
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
The failure is irrelevant to this PR.
```
org.apache.spark.sql.execution.datasources.csv.UnivocityParserSuite.(It is
not a test it is a sbt.testing.SuiteSelector
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r190130347
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
---
@@ -89,6 +89,8 @@ class OrcFileFormat
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
It's weird. `UnivocityParserSuite` is still complaining.
```
Error Message
java.lang.IllegalStateException: LiveListenerBus is stopped.
Stack
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
Thank you for review, @cloud-fan . Sure, if possible.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21372#discussion_r190382953
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -169,6 +170,14 @@ abstract class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21372#discussion_r190383386
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -169,6 +170,14 @@ abstract class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21404
I'm investigating timing issue here. Spark loads Hive Metastore class
lazily. Here, Spark is trying to access Hive metastore tables like `DBS` before
it'
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21416#discussion_r190399106
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala ---
@@ -397,6 +399,68 @@ class ColumnExpressionSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21416#discussion_r190407851
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -219,7 +219,11 @@ object
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
Yep. Both JIRA and PR description is updated.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
Finally! Could you review this again, @HyukjinKwon , @gatorsmile ,
@cloud-fan ?
---
-
To unsubscribe, e-mail: reviews
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21295
Congratulation, @rdblue ! :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21372
Thank you, @cloud-fan , @gatorsmile , @HyukjinKwon .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21416#discussion_r190717637
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -219,7 +219,11 @@ object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21416#discussion_r190722260
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -220,6 +219,7 @@ object OptimizeIn extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21416#discussion_r190759741
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -220,6 +219,7 @@ object OptimizeIn extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21416
+1, LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/21446
[SPARK-19613][SS][TEST] Random.nextString is not safe for directory
namePrefix
## What changes were proposed in this pull request?
`Random.nextString` is good for generating random
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21446
Thank you for reviewing, @felixcheung and @HeartSaVioR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21446
Thank you for review and merging, @HyukjinKwon . Thank you all!
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21458
Thank you for working on this, @dbtsai ! :D
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20276
Hi, @cloud-fan . If this PR is still valid, could you resolve the conflicts?
---
-
To unsubscribe, e-mail: reviews
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192309419
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2696,16 +2687,6 @@ class SQLQuerySuite extends QueryTest with
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21495
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21495#discussion_r193919141
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoopInterpreter.scala
---
@@ -21,8 +21,22 @@ import scala.collection.mutable
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21495#discussion_r193920472
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoopInterpreter.scala
---
@@ -21,8 +21,22 @@ import scala.collection.mutable
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21495#discussion_r193935371
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoopInterpreter.scala
---
@@ -21,8 +21,22 @@ import scala.collection.mutable
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21495#discussion_r193936286
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoopInterpreter.scala
---
@@ -21,8 +21,22 @@ import scala.collection.mutable
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21495#discussion_r193942643
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoopInterpreter.scala
---
@@ -21,8 +21,22 @@ import scala.collection.mutable
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20887#discussion_r194321737
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2792,4 +2793,40 @@ class SQLQuerySuite extends QueryTest with
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21501
Congratulation, @dongjinleekr ! :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20846
Right, @gatorsmile .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20852
Thank you, @jkbradley and @attilapiros .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20847
The ML bug is fixed. I'll retrigger this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.or
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20847
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20208
Of course! Those command are an illustration of use case of schema
evolution in Hive-side in general.
This PR aims to provide *schema evolution* test coverage in Spark-side. As
you
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20208#discussion_r175579537
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaEvolutionTest.scala
---
@@ -0,0 +1,406
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20208
Which document do you have in mind? A section in
`docs/sql-programming-guide.md`?
---
-
To unsubscribe, e-mail: reviews
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20847
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20851#discussion_r176302394
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -353,6 +353,13 @@ object SQLConf {
.booleanConf
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20851#discussion_r176302671
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -50,6 +59,11 @@ private[parquet
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20851#discussion_r176304057
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -313,6 +315,49 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176306901
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -908,11 +912,39 @@ private[hive] object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176307074
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HiveDelegationTokenProvider.scala
---
@@ -78,6 +78,7 @@ private[security] class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176307526
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -908,11 +912,39 @@ private[hive] object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176307892
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -908,11 +912,39 @@ private[hive] object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176308454
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HiveDelegationTokenProvider.scala
---
@@ -92,8 +93,8 @@ private[security] class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176309717
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HiveDelegationTokenProvider.scala
---
@@ -92,8 +93,8 @@ private[security] class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20851#discussion_r176310447
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -313,6 +315,49 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20803#discussion_r176313767
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,7 +637,8 @@ class SparkSession private(
* @since 2.0.0
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20803#discussion_r176313994
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,7 +637,8 @@ class SparkSession private(
* @since 2.0.0
1401 - 1500 of 7376 matches
Mail list logo
