Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11635#issuecomment-204437861
@gatorsmile is this PR still a wip? Or ready for Review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204461425
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11991#issuecomment-204460100
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307367
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307357
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58308055
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58308046
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12137#issuecomment-204940667
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12134#issuecomment-204958652
@gatorsmile good catch!
Let me try to explain why this happens. All `visit*` functions in the
ANTLR4 generated visitor use
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58308802
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12137#issuecomment-204977847
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307196
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -238,16 +238,20 @@ class SparkSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307277
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307310
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58308017
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307336
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12125#discussion_r58307908
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -759,6 +761,7 @@ SNAPSHOT: 'SNAPSHOT';
READ: 'READ
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307250
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307226
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -93,6 +93,23 @@ class SparkSqlAstBuilder extends AstBuilder
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307261
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12125#issuecomment-204934257
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12125#issuecomment-204994567
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58315454
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -316,8 +316,7 @@ class SparkSqlAstBuilder extends AstBuilder
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58315200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -133,6 +133,33 @@ object UnresolvedAttribute
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205024763
@yhuai what do you want to do with the composed expressions, i.e.: `!=`,
`<>` & `between`? `case` is more of a keyword.
---
If your project is set up f
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58314666
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,54 @@ case class ShowDatabasesCommand
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58315281
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -272,10 +272,7 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58330212
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -134,6 +134,18 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58330509
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -332,6 +332,9 @@ private[sql] abstract class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58330946
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -134,6 +134,18 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58334684
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -332,6 +332,9 @@ private[sql] abstract class
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12147#issuecomment-205166586
@xwu0226 this look interesting. I will try to get to this in the next
couple of days.
The thing I am really worried about is performance. Could you please
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12147#issuecomment-205166619
cc @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12144#issuecomment-205181169
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12144#issuecomment-205181236
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58317039
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/functionResources.scala
---
@@ -0,0 +1,56 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58317032
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/functionResources.scala
---
@@ -0,0 +1,56 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58318012
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -133,6 +133,16 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58317969
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -133,6 +133,16 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58317991
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -133,6 +133,16 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58317331
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -363,7 +363,11 @@ class
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205051607
@yongtang can you see if you can hardcode the descriptions for the composed
function into the `DecribeFunction` command? See:
https://github.com/apache/spark/blob
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58317947
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -133,6 +133,16 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58375653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -411,11 +412,12 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58375731
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -183,6 +185,20 @@ class SparkSqlAstBuilder extends
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12133#issuecomment-205675459
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58493351
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -351,7 +364,8 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58494680
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -351,7 +364,8 @@ class AstBuilder extends
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12156#issuecomment-205672374
@bomeng `DISTRIBUTE` `UNSET` have been defined as one rule, so we cannot
use them as identifiers. This will fail for instance: `select unset from x`
whereas `select
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12169#discussion_r58493735
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -75,17 +75,17 @@ statement
| ALTER TABLE
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12134#issuecomment-205678954
LGTM - pending rebase/merge and jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12128#discussion_r58492366
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -213,8 +213,8 @@ class SQLQuerySuite extends QueryTest
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12134#issuecomment-205723972
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57787998
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -70,12 +70,28 @@ class SparkSqlAstBuilder extends AstBuilder
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57786921
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -107,7 +107,8 @@ statement
| DROP TEMPORARY
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57787715
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -70,12 +70,28 @@ class SparkSqlAstBuilder extends AstBuilder
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57789745
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -350,6 +354,34 @@ case class ShowTablesCommand
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57800827
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -107,7 +107,8 @@ statement
| DROP TEMPORARY
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57801096
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -70,12 +70,28 @@ class SparkSqlAstBuilder extends AstBuilder
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12040#discussion_r57887314
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -937,6 +944,14 @@ private[execution] object AggregateProcessor
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12040#discussion_r57887488
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -885,9 +886,15 @@ private[execution] object AggregateProcessor
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12040#issuecomment-203432548
Two minor suggestions. LGTM pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58136464
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -122,9 +122,10 @@ class SparkSqlAstBuilder extends
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12099#issuecomment-204154130
@dongjoon-hyun I left a few small comments. Looks pretty solid overall.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12099#discussion_r58136340
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -576,7 +576,7 @@ frameBound
explainOption
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204154484
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12040#discussion_r58083676
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -937,6 +945,12 @@ private[execution] object AggregateProcessor
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12086#issuecomment-204016040
@bomeng could you add the SQL tag to the PR title. This makes it easier for
others to scan the PR queue.
Overall this looks pretty solid. Could you rebase
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r58062792
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -510,16 +513,22 @@ class SparkSqlAstBuilder extends
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12086#issuecomment-203965549
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203965085
One minor comment. LGTM pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11361#discussion_r58171387
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
---
@@ -426,4 +428,68 @@ class PlanParserSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11361#discussion_r58171624
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -1114,6 +1114,91 @@ class HiveQuerySuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11361#discussion_r58181875
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
---
@@ -426,4 +428,68 @@ class PlanParserSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11361#discussion_r58171562
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -1114,6 +1114,91 @@ class HiveQuerySuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12086#discussion_r58119934
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1811,4 +1811,18 @@ class SQLQuerySuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12086#discussion_r58119832
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -158,5 +159,22 @@ class DDLSuite extends QueryTest
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12040#discussion_r58123254
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -920,7 +931,7 @@ private[execution] object AggregateProcessor
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204128122
Yeah that is a bit funny. I triggered another build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12040#discussion_r58115026
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -885,11 +886,21 @@ private[execution] object AggregateProcessor
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12040#discussion_r58120586
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -920,7 +931,7 @@ private[execution] object AggregateProcessor
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12040#discussion_r58127160
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -920,7 +931,7 @@ private[execution] object AggregateProcessor
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12040#discussion_r58114426
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -920,7 +931,7 @@ private[execution] object AggregateProcessor
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11991#issuecomment-204128228
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58278714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -453,28 +464,80 @@ class SessionCatalog
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12125#issuecomment-204795260
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11635#issuecomment-204381732
@gatorsmile could you rebase this one. I'll have a look in the next few
days.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12125#discussion_r58299737
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -759,6 +761,7 @@ SNAPSHOT: 'SNAPSHOT';
READ: 'READ
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58299767
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -272,6 +272,22 @@ class SessionCatalog
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58299861
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -93,6 +93,23 @@ class SparkSqlAstBuilder extends AstBuilder
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12147#discussion_r58430735
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -721,16 +791,37 @@ private[execution] final class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58437665
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
@@ -47,18 +47,38 @@ case class AnalyzeTable(tableName: String
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12147#discussion_r58429851
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -262,19 +270,82 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58430037
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveQlSuite.scala ---
@@ -201,6 +202,31 @@ class HiveQlSuite extends SparkFunSuite
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12134#issuecomment-205451553
@gatorsmile we are getting there. Two minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58438576
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
@@ -47,18 +47,38 @@ case class AnalyzeTable(tableName: String
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12134#discussion_r58430408
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -398,11 +412,15 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12147#discussion_r58429510
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -713,6 +719,9 @@ PRECEDING: 'PRECEDING';
FOLLOWING
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58436969
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -113,7 +113,10 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58438731
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
@@ -47,18 +47,38 @@ case class AnalyzeTable(tableName: String
1001 - 1100 of 4165 matches
Mail list logo
