Also note that any of my above points can be addressed later, they're not
things preventing this PR from merging, in my opinion, as it's good enough just
as is, especially now that we're about to start the releasing.
--
Reply to this email directly or view it on GitHub:
OK, it's not the prettiest piece of code but it does the job, at least for the
foreseeable future, in case somebody finds a more elegant solution :smile:
Just two questions:
* Is there any use of having the man and apidocs archives separate? We remove
both afterwards, anyway, so they won't be
... and the same test passes on the very same VM that the CI job ran on (I've
checked manually using the SSH feature in Semaphore). Seems like we've got a
new random false negative in our test suite... :cry:
--
Reply to this email directly or view it on GitHub:
It's this error in test 423 (Dependency generation 3), has anyone seen this
before?
```
error: Illegal char '*' (0x2a) in: *
```
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2469#issuecomment-1497698026
You are receiving this because
Hmm, so the CI failure doesn't seem to have anything to do with this commit.
The same podman image passes just fine for me locally...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2469#issuecomment-1497696590
You are receiving this
I'm not entirely sure about the `#include ` vs. `#include "lua.h"` thing
here. It does seem more appropriate and consistent to use the bracket style for
external libraries. Let me know your thoughts, I can drop that part from the
commit if needed :smile:
--
Reply to this email directly or
While many distros ship a pkg-config file for Lua downstream, the upstream
source tree does not, and so we shouldnt rely on it. Turns out, CMake
provides a native Lua package, so just use that.
Unfortunately, the package doesnt define any IMPORTED target, it only does
the LUA_LIBRARIES and
This fixes a regression from automake where we also didnt use pkg-config
for libmagic.
Fixes: #2246
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2468
-- Commit Summary --
* Dont rely on pkg-config for libmagic just yet
See commits for the wonky details, this gets pretty weird in places.
Fixes #2465
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2467
-- Commit Summary --
* Include pre-built API docs and man pages in dist tarballs
*
