Re: [Rails-core] How does ActiveRecord::TestFixtures::ClassMethods#run_in_transaction? work?

2015-03-10 Thread Brandon Weiss
Aha! I hadn't thought to look on `TestCase`. Thanks! On Sunday, March 8, 2015 at 4:37:15 PM UTC-7, Matt jones wrote: > > > On Mar 6, 2015, at 12:59 AM, Brandon Weiss > wrote: > > Here's the method: > > def run_in_transaction? > use_transactional_fixtures

Re: [Rails-core] Rename transactional fixtures to something clearer and more descriptive

2015-03-10 Thread Brandon Weiss
Awesome! I made a pull request <https://github.com/rails/rails/pull/19282> :) On Tuesday, March 10, 2015 at 11:57:49 AM UTC-7, Rafael Mendonça França wrote: > > Seems good to me. > > On Fri, Mar 6, 2015 at 4:04 AM Brandon Weiss > wrote: > >> I think the name

[Rails-core] Re: How does ActiveRecord::TestFixtures::ClassMethods#run_in_transaction? work?

2015-03-06 Thread Brandon Weiss
Argh, I meant if `use_transactional_fixtures` is true I get the error. On Thursday, March 5, 2015 at 11:04:43 PM UTC-8, Brandon Weiss wrote: > > Here's the method: > > def run_in_transaction? > use_transactional_fixtures && > !self.class.uses_transaction?(m

[Rails-core] How does ActiveRecord::TestFixtures::ClassMethods#run_in_transaction? work?

2015-03-05 Thread Brandon Weiss
Here's the method: def run_in_transaction? use_transactional_fixtures && !self.class.uses_transaction?(method_name) end I'm super confused. What is `method_name`? And where does it come from? It's not a local variable. I can find two instances of `def method_name` in the repo and neither

[Rails-core] Rename transactional fixtures to something clearer and more descriptive

2015-03-05 Thread Brandon Weiss
I think the name "transactional fixtures" is a little misleading and confusing, because (as far as I can tell) it doesn't really have anything to do with fixtures. This is pretty embarrassing, but I've been using Rails almost since 1.0 and I had no idea that transactional fixtures were runnin

[Rails-core] Pull request 6215 still not in 3-2-stable

2013-02-11 Thread Brandon Mathis
Hi guys! I'm not familiar with the acceptance policy of pull requests being accepted into stable versions of rails. I'm curious as to why https://github.com/rails/rails/pull/6215 is not yet included in a release of rails despite the merge happening over 9 months ago? Is there one last step that

[Rails-core] Re: Coffeescript in the default generator?

2011-04-14 Thread Brandon
I really don't see what the fuss is about. If you don't like coffee- script then just write JavaScript. Right? On Apr 13, 4:24 pm, Andrew Kaspick wrote: > I prefer LESS over SASS, but I see SASS has improved since the last > time I used it and taken some much needed pointers from LESS.  I > didn'

[Rails-core] Re: Looking for maintainers of Rails plugins

2011-02-04 Thread Brandon
I will take a crack at scaffolding https://github.com/KeysetTS/scaffolding -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email

[Rails-core] Ruby 1.9 and array params

2010-02-14 Thread Brandon Keepers
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2999 I've submitted a patch for this bug that raises an exception anytime there is an Array in the request parameters with Ruby 1.9. I'd appreciate if one of the core members could check it out and apply it. Thank

[Rails-core] Re: Multibye chars eql?

2009-03-08 Thread Brandon Keepers
. I understand your desire for it to be symmetric with String#eql?, but I think that is a separate issue. I don't feel strongly about it one way or the other. At a minimum, #eql? and #hash should behave properly when compared to another Chars object. Brandon On Mar 8, 2009, at 2:38 P

[Rails-core] Multibye chars eql?

2009-03-07 Thread Brandon Keepers
patch incorporating the suggestion. http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1496 I'd appreciate it if someone could check it out and apply it for 2.3. Thanks, Brandon --~--~-~--~~~---~--~~ You received this message because you are subsc

[Rails-core] donations?

2009-01-09 Thread Brandon Keepers
some other project in honor of Rails Thanks, Brandon PGP.sig Description: This is a digitally signed message part

[Rails-core] Re: [PATCH] OrderedHash keys

2009-01-04 Thread Brandon Keepers
Anything else needed to get this patch applied? On Thu, Jan 1, 2009 at 4:08 PM, Frederick Cheung wrote: > Looks sane to me! > On 31 Dec 2008, at 15:54, Brandon Keepers wrote: > >> >> I've posted a patch that fixes some issues with OrderedHash doing >> weird thin

[Rails-core] [PATCH] OrderedHash keys

2008-12-31 Thread Brandon Keepers
I've posted a patch that fixes some issues with OrderedHash doing weird things with keys. I'd appreciate it if someone could check it out and apply it. http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1676-orderedhash-mishandles-keys Thank

[Rails-core] Re: require 'application' loads it twice

2008-07-11 Thread Brandon Keepers
to submit it upstream :) http://rspec.lighthouseapp.com/projects/5645/tickets/440-before-filter-are-executed-twice Thanks Koz. Brandon PGP.sig Description: This is a digitally signed message part

[Rails-core] require 'application' loads it twice

2008-07-11 Thread Brandon Keepers
e path of the filename, so simply requiring application would still re-load it. I'm also wondering if #require_dependency is necessary in the dispatcher. Would simply using #require do the trick? I'm willing to pursue a patch to fix this, I just wanted to see if anyone had

[Rails-core] Re: Associations' dynamic finders fail with :order depends on :include

2008-05-31 Thread Brandon Keepers
On Sat, May 31, 2008 at 1:57 PM, Brandon Keepers <[EMAIL PROTECTED]> wrote: > I wanted to point out a bug in Trac that was opened a couple months ago. > When using dynamic finders on an association, the eager loading is ignored, > which raises an error if the eagerly-loaded asso

[Rails-core] Associations' dynamic finders fail with :order depends on :include

2008-05-31 Thread Brandon Keepers
rails. Please review and apply. http://dev.rubyonrails.org/ticket/11562 Brandon PGP.sig Description: This is a digitally signed message part

[Rails-core] #10567 sqlite - renaming and removing indexed columns

2007-12-20 Thread Brandon Keepers
I've added a patch to fix sqlite with renaming and removing columns that have an index. Please check it out an add your +1s or suggestions. http://dev.rubyonrails.org/ticket/10576 Thanks, Brandon --~--~-~--~~~---~--~~ You received this message because yo

[Rails-core] #7334: FIXTURES_DIR for db:fixtures:load

2007-11-06 Thread Brandon Keepers
;s to the ticket or give constructive criticism. Thanks, Brandon --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@goog

[Rails-core] Re: refactoring ActionView

2007-10-23 Thread Brandon Keepers
On Oct 23, 2007, at 11:42 AM, Josh Peek wrote: > On Sep 30, 4:13 pm, Brandon Keepers <[EMAIL PROTECTED]> wrote: >> I'm up for trying to tackle it if anyone wants to pitch in. > > Did you make any progress? Just wondering because I was going give it > a try. Not

[Rails-core] Re: #9746: Range extensions

2007-10-02 Thread Brandon Keepers
On Oct 1, 2007, at 4:33 PM, Piyush Ranjan wrote: > +1 > Totally useful Want to add that to the ticket? ;) > On 10/1/07, Brandon Keepers <[EMAIL PROTECTED]> wrote: > > http://dev.rubyonrails.org/ticket/9746 > Brandon --~--~-~--~~~---~--

[Rails-core] #9746: Range extensions

2007-09-30 Thread Brandon Keepers
ges. :-) The patch also adds support for #step without a block, which will just return an array: (0..60).step(15) #=> [0,15,30,45,60] Add your +1's if you think it is a worthy patch. Thanks, Brandon --~--~-~--~~~---~--~~ You received this message becaus

[Rails-core] Re: refactoring ActionView

2007-09-30 Thread Brandon Keepers
x27;s just a > refactoring (no API changes), then it could make 2.1. > Otherwise, it > can be scheduled for 3.0. Rails 2.x is not going to be the last, ever > release of the framework ;). Whew...that's a relief. ;-) Brandon --~--~-~--~~~---~--

[Rails-core] refactoring ActionView

2007-09-30 Thread Brandon Keepers
t too late for a major change like that for 2.0? Brandon --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com

[Rails-core] Re: has_many :through and access to the the through record

2007-09-19 Thread Brandon Keepers
On Sep 19, 2007, at 5:13 PM, foomanchoo wrote: > >> The :through part of those associations is really just an >> optimisation >> to avoid having to write: >> >> @tag.taggings.map(&:post) >> >> If you need access to the tagging instances, just use @tag.taggings >> instead of @tag.posts > > True

[Rails-core] #7453 - altering tables without a primary key in sqlite

2007-09-14 Thread Brandon Keepers
Could I get some reviewers for #7453? sqlite fails when trying to modify tables without a primary key (join tables). The patch is a simple 2 line fix with a test. http://dev.rubyonrails.org/ticket/7453 Thanks, Brandon --~--~-~--~~~---~--~~ You received

[Rails-core] Re: 7315

2007-09-11 Thread Brandon Keepers
On Sep 11, 2007, at 11:41 AM, Brandon Keepers wrote: http://dev.rubyonrails.org/changeset/7315 caused some interesting behavior with attributes marked with attr_protected. See http:// pastie.caboo.se/96099, specifically line 19. It looks like attributes are cached and not cleared when

[Rails-core] 7315

2007-09-11 Thread Brandon Keepers
but I would appreciate any pointers (koz) as I try to dig through the define_read_method, which is where I suspect the bug is coming from. Thanks, Brandon --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby

[Rails-core] partial layouts + content_tag_for

2007-08-07 Thread Brandon Keepers
Would the ideal solution to this be to make capture work with nested calls? Brandon PGP.sig Description: This is a digitally signed message part

[Rails-core] Re: respond_to forces template format

2007-07-07 Thread Brandon Keepers
epts header has "text/javascript; text/html", it would look for rjs, then html? Brandon --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send

[Rails-core] Re: respond_to forces template format

2007-07-06 Thread Brandon Keepers
format doesn't exist, I think it should use the Accepts header to determine other template formats. I'm looking into a patch for this. Brandon --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "R

[Rails-core] respond_to forces template format

2007-07-05 Thread Brandon Keepers
. In my option, it should use the order of the Accepts header to give preference to template formats just like it does with choosing the format for the respond_to block. What are your thoughts? Brandon --~--~-~--~~~---~--~~ You received this message because yo

[Rails-core] Re: DRYing link_to with a symbol

2007-06-28 Thread Brandon Keepers
On Jun 28, 2007, at 7:50 AM, Geoff B wrote: > Hi, I just put in a patch that allows you to DRY up this: > > <%= link_to @company.name, @company %> > > to this: > > <%= link_to :name, @company %> > > The symbol indicates the method to be called on the object passed in > the link_to options. > > h

[Rails-core] Re: ticket #4245 - Fix rake/generators for symlinked plugins

2006-12-11 Thread Brandon Keepers
On Dec 11, 2006, at 11:47 AM, eclaymoore wrote: > > Brandon, > > I am a Rails user in practice and do not presume to know enough to > touch the internal code, but I am concerned by your patch to allow for > symlinked plugins. > > You are suggesting to change li

[Rails-core] ticket #4245 - Fix rake/generators for symlinked plugins

2006-12-08 Thread Brandon Keepers
would apply this patch since Rails partially works with symlinked plugins (it loads them), but the plugins generators and rake tasks won't work. Thanks, Brandon [1] http://dev.rubyonrails.org/attachment/ticket/4245/ symlinked_plugins.patch --~--~-~--~~~---~--~