I've updated the LH ticket with another patch - finishing off the
changes to actually parse from the IO (instead of converting to a
string first) for the rexml, libxml and nokogiri backends.
Should this be in another ticket?
-Brian
On May 17, 9:54 am, brianmario wrote:
> Thanks for committing t
Thanks for committing that, but what was the reason you removed the
yajl JSON backend and updated JSON test?
I should have noted somewhere that the JSON test and yajl.rb backend
were originally written by Rick Olson, and I made modifications to
support the ability to be passed an IO.
-Brian
On M
Done:
https://rails.lighthouseapp.com/projects/8994/tickets/2659-paramsparser-and-request-body-streams#ticket-2659-3
Let me know if you need anything else.
-Brian
On May 16, 7:22 pm, Joshua Peek wrote:
> Yeah, create a LH patch and assign it to me plz
>
>
>
>
>
> On Sat, May 16, 2009 at 6:01
Yeah, create a LH patch and assign it to me plz
On Sat, May 16, 2009 at 6:01 PM, brianmario wrote:
>
> Ok I forked and patched the ParamsParser to just pass request.body to
> the parsers. I did it for JSON, XML and YAML (using YAML.load_stream
> instead of just load).
> I also patched the XmlMin
Ok I forked and patched the ParamsParser to just pass request.body to
the parsers. I did it for JSON, XML and YAML (using YAML.load_stream
instead of just load).
I also patched the XmlMini and JSON decoders for parsing from an IO,
in addition to a string. And as a result (like you said), I didn't
On Sat, May 16, 2009 at 09:54, brianmario wrote:
>
> Exactly.
>
> What's the next step here?
> I can fork Rails and work on a patch, though I'm unsure how many/which
> tests will need to be refactored.
I don't think existing tests need changes. New tests have to be added:
1. that JSON parse
Exactly.
What's the next step here?
I can fork Rails and work on a patch, though I'm unsure how many/which
tests will need to be refactored.
On May 15, 10:40 pm, Michael Koziarski wrote:
> > I guess the real patch would allow "ActiveSupport::JSON.decode" to
> > accept an IO object as well. Then
> I guess the real patch would allow "ActiveSupport::JSON.decode" to
> accept an IO object as well. Then we could just pass that directly in.
yeah, ideally both the JSON and XML parsers would accept an IO, and
the 'read into a string' logic would live in the implementations which
don't support st
On Fri, May 15, 2009 at 6:59 PM, brianmario wrote:
>
> The problem is that the ParamsParser reads the entire body into a
> string (from what I can tell by the line "body = request.raw_post")
> before handing it to the parsing backend. My suggestion is that it
> hand the IO object (env['rack.input
The problem is that the ParamsParser reads the entire body into a
string (from what I can tell by the line "body = request.raw_post")
before handing it to the parsing backend. My suggestion is that it
hand the IO object (env['rack.input'] I assume?) to the parser
instead. This way the parser can e
Check out how the current ParamsParser middleware works.
You can use whatever parser to extract the request params in your
middleware and Rails will be fooled into using that instead.
On Fri, May 15, 2009 at 1:31 PM, brianmario wrote:
>
> Hey everyone,
> I was wondering what the possability was
> Comments?
This sounds like a great idea to me, without much in the way of downsides.
So give it a go and see what breaks.
--
Cheers
Koz
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups "Ruby
on Rails: Core" gr
12 matches
Mail list logo
