Re: [sage-combinat-devel] Re: coxeter groups category

2012-04-10 Thread Christian Stump
>> Should I modify Christian's patch file directly? >> I assume this means that I just delete that hunk from his >> patch file. > > Yes, that's what I would do. Just remove that piece directly from the > patch in /sage-combinat/.hg/patches as long as Christian does not have > any local modification

Re: [sage-combinat-devel] Re: coxeter groups category

2012-04-10 Thread Anne Schilling
Hi Mark, > Should I modify Christian's patch file directly? > I assume this means that I just delete that hunk from his > patch file. Yes, that's what I would do. Just remove that piece directly from the patch in /sage-combinat/.hg/patches as long as Christian does not have any local modification

Re: [sage-combinat-devel] Re: coxeter groups category

2012-04-10 Thread mshimo
Christian and Nicolas, Thanks for all the info. >> > If not I will delete apply_demazure_simple_reflection >> > and use apply_simple_projection instead, with the renamed >> > option length_increasing. When I did this (including deprecation stuff) I got a very mild conflict with Christian's trac_

Re: [sage-combinat-devel] Re: coxeter groups category

2012-04-10 Thread Nicolas M. Thiery
Hi Mark, On Tue, Apr 10, 2012 at 08:03:44AM +0200, Christian Stump wrote: > > The queue applies now :) Cool! > > Yes. I never looked at this method because it sounds different > > than what I was doing. I want to change the option > > "toward_max" to "length_increasing". Will anyone be b

Re: [sage-combinat-devel] Re: coxeter groups category

2012-04-09 Thread Christian Stump
On Tue, Apr 10, 2012 at 2:12 AM, wrote: > Nicolas, > > The queue applies now :) > >> I am about to push another reviewer's patch which fixes some little >> documentation compilation errors. > > I'll fold it in. Thanks! > >> By the way: ``apply_demazure_simple_reflection`` does the same as >> ``ap

Re: [sage-combinat-devel] Re: coxeter groups category

2012-04-09 Thread mshimo
Nicolas, The queue applies now :) > I am about to push another reviewer's patch which fixes some little > documentation compilation errors. I'll fold it in. Thanks! > By the way: ``apply_demazure_simple_reflection`` does the same as > ``apply_simple_projection``, right? Yes. I never looked at

Re: [sage-combinat-devel] Re: coxeter groups category

2012-04-09 Thread Nicolas M. Thiery
Hi Mark! On Mon, Apr 02, 2012 at 10:14:03AM +0200, Nicolas M. Thiery wrote: > ... About trac_12774-coxeter-ms.patch I am about to push another reviewer's patch which fixes some little documentation compilation errors. You can fold it in your patch by issuing: hg qfold trac_12774-

Re: [sage-combinat-devel] Re: coxeter groups category

2012-04-02 Thread mshimo
>> I've hit this kind of coercion/conversion problem several times >> already (Thanks, Simon, for explanations). I want to define an >> operation "over integers". But it is only directly defined "over >> rationals". But I have a proof that the answer is "integral". I'd >> like to have a way to a

Re: [sage-combinat-devel] Re: coxeter groups category

2012-04-02 Thread Nicolas M. Thiery
On Mon, Apr 02, 2012 at 09:29:26AM -0700, Mark Shimozono wrote: > > One issue: the method `weyl_action`, and many others in > > RootLatticeRealizations, will generalize right away to the geometric > > realization of any Coxeter group. Granted, RootLatticeRealizations is > > a misnomer since the roo

[sage-combinat-devel] Re: coxeter groups category

2012-04-02 Thread Mark Shimozono
Nicolas, Thanks for your speedy response! I made the requested modifications and pushed. > One issue: the method `weyl_action`, and many others in > RootLatticeRealizations, will generalize right away to the geometric > realization of any Coxeter group. Granted, RootLatticeRealizations is > a mis

Re: [sage-combinat-devel] Re: coxeter groups category

2012-04-02 Thread Nicolas M. Thiery
On Sun, Apr 01, 2012 at 05:17:39PM -0700, Mark Shimozono wrote: > Could you please have a look at the brand-new version > on the sage-combinat server, of trac_12774-coxeter-ms.patch > sage/combinat/root_system/root_lattice_realizations.py > line 1759, method weyl_action? (Particularly the way I try

[sage-combinat-devel] Re: coxeter groups category

2012-04-01 Thread Mark Shimozono
Nicolas, Could you please have a look at the brand-new version on the sage-combinat server, of trac_12774-coxeter-ms.patch sage/combinat/root_system/root_lattice_realizations.py line 1759, method weyl_action? (Particularly the way I try to do the type checking that is needed due to the easier-to-u

Re: [sage-combinat-devel] Re: coxeter groups category

2012-03-29 Thread Nicolas M. Thiery
On Thu, Mar 29, 2012 at 07:30:14AM +, Simon King wrote: > > «change the status of the ticket to *needs review* and change the milestone > > to sage-duplictate/invalid/wontfix. > > You should also comment on the ticket, explaining why it should be closed.» > > Really "needs review"?? I was tol

[sage-combinat-devel] Re: coxeter groups category

2012-03-29 Thread Simon King
Hi Nicolas! On 2012-03-29, Nicolas M. Thiery wrote: > On Thu, Mar 29, 2012 at 12:01:26AM -0400, msh...@math.vt.edu wrote: >> I added the comment on #11122 but don't know how to change its >> status to "already done" or whatever it should be. > > From: > http://www.sagemath.org/doc/developer/trac