[sage-devel] Re: How many changes are reasonable for a reviewer to ask on one ticket?

2010-09-08 Thread Niles
On Sep 7, 6:28 pm, Dr. David Kirkby david.kir...@onetel.net wrote: On 09/ 7/10 02:57 PM, Jason Grout wrote: This is a problem faced throughout software engineering, of course. I think of the many times in my CS degree where we talked about the necessity of drawing up specs (i.e.,

[sage-devel] Re: How many changes are reasonable for a reviewer to ask on one ticket?

2010-09-07 Thread Nathann Cohen
Sorry to answer to such an exhaustively documented message with a simple line David, but I honestly think that beginning to write down rules about how Sage developpers should deal with each other is the end of natural/good mood/pleasure in participating It's a bit like life... You work with

[sage-devel] Re: How many changes are reasonable for a reviewer to ask on one ticket?

2010-09-07 Thread kcrisman
On Sep 7, 8:02 am, Nathann Cohen nathann.co...@gmail.com wrote: Sorry to answer to such an exhaustively documented message with a simple line David, but I honestly think that beginning to write down rules about how Sage developpers should deal with each other is the end of natural/good

[sage-devel] Re: How many changes are reasonable for a reviewer to ask on one ticket?

2010-09-07 Thread Jason Grout
On 9/7/10 5:55 AM, Dr. David Kirkby wrote: [snip] Do we have any guidelines on these sorts of issues? If not, I'd propose that any changes outside the original scope of the ticket that will take the author less than 30 minutes to address, would be quite reasonable. But if the changes are

Re: [sage-devel] Re: How many changes are reasonable for a reviewer to ask on one ticket?

2010-09-07 Thread Dr. David Kirkby
On 09/ 7/10 02:57 PM, Jason Grout wrote: On 9/7/10 5:55 AM, Dr. David Kirkby wrote: [snip] Do we have any guidelines on these sorts of issues? If not, I'd propose that any changes outside the original scope of the ticket that will take the author less than 30 minutes to address, would be