svn commit: samba r14232 - branches/SAMBA_3_0/source/rpc_parse trunk/source/rpc_parse

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 10:44:19 + (Sun, 12 Mar 2006) New Revision: 14232 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14232 Log: Fix Coverity Bug # 218 Modified: branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c

svn commit: samba r14233 - branches/SAMBA_3_0/source/rpc_server trunk/source/rpc_server

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 10:47:02 + (Sun, 12 Mar 2006) New Revision: 14233 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14233 Log: Fix Coverity bug # 206 Modified: branches/SAMBA_3_0/source/rpc_server/srv_spoolss_nt.c

svn commit: samba r14234 - branches/SAMBA_3_0/source/libsmb trunk/source/libsmb

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 10:52:56 + (Sun, 12 Mar 2006) New Revision: 14234 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14234 Log: Fix Coverity bug # 93 Modified: branches/SAMBA_3_0/source/libsmb/libsmbclient.c trunk/source/libsmb/libsmbclient.c

svn commit: samba r14236 - branches/SAMBA_3_0/source/libsmb trunk/source/libsmb

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 11:00:06 + (Sun, 12 Mar 2006) New Revision: 14236 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14236 Log: Fix Coverity bug # 90 Modified: branches/SAMBA_3_0/source/libsmb/libsmbclient.c trunk/source/libsmb/libsmbclient.c

svn commit: samba r14237 - in branches/SAMBA_4_0/source/build/smb_build: .

2006-03-12 Thread metze
Author: metze Date: 2006-03-12 13:10:26 + (Sun, 12 Mar 2006) New Revision: 14237 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14237 Log: fix the summary output (step 1) metze Modified: branches/SAMBA_4_0/source/build/smb_build/summary.pm Changeset:

svn commit: samba r14238 - in branches/SAMBA_4_0/source/librpc/rpc: .

2006-03-12 Thread mimir
Author: mimir Date: 2006-03-12 13:11:46 + (Sun, 12 Mar 2006) New Revision: 14238 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14238 Log: This is not needed anymore, as the state structure is zeroed right after allocation. rafal Modified:

svn commit: samba r14239 - in branches/SAMBA_4_0/source/libcli/composite: .

2006-03-12 Thread mimir
Author: mimir Date: 2006-03-12 13:14:21 + (Sun, 12 Mar 2006) New Revision: 14239 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14239 Log: Fix indentation. rafal Modified: branches/SAMBA_4_0/source/libcli/composite/composite.c Changeset: Modified:

svn commit: samba r14240 - in branches/SAMBA_4_0/source: build/smb_build lib/popt lib/replace ntvfs/posix

2006-03-12 Thread metze
Author: metze Date: 2006-03-12 13:36:08 + (Sun, 12 Mar 2006) New Revision: 14240 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14240 Log: fix summary output (step 2) we now need to explicit enable external libraries in *.m4 files again... metze Modified:

svn commit: samba r14241 - branches/SAMBA_3_0/source/libsmb trunk/source/libsmb

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 17:18:26 + (Sun, 12 Mar 2006) New Revision: 14241 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14241 Log: Fix Coverity bug # 146 Modified: branches/SAMBA_3_0/source/libsmb/libsmbclient.c trunk/source/libsmb/libsmbclient.c

svn commit: samba r14242 - branches/SAMBA_3_0/source/client trunk/source/client

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 17:24:10 + (Sun, 12 Mar 2006) New Revision: 14242 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14242 Log: Fix Coverity bug # 82 Modified: branches/SAMBA_3_0/source/client/clitar.c trunk/source/client/clitar.c Changeset:

svn commit: samba r14243 - branches/SAMBA_3_0/source/rpc_client trunk/source/rpc_client

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 17:26:56 + (Sun, 12 Mar 2006) New Revision: 14243 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14243 Log: Fix Coverity bug # 143 Modified: branches/SAMBA_3_0/source/rpc_client/cli_spoolss.c

svn commit: samba r14244 - branches/SAMBA_3_0/source/rpc_client trunk/source/rpc_client

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 17:29:42 + (Sun, 12 Mar 2006) New Revision: 14244 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14244 Log: Okay, had not seen that this happened twice. Fix Coverity bug # 142. Volker Modified:

svn commit: samba r14245 - branches/SAMBA_3_0/source/rpcclient trunk/source/rpcclient

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 17:44:00 + (Sun, 12 Mar 2006) New Revision: 14245 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14245 Log: We've dereferenced argv before, no point in checking. Fix Coverity bug # 144. Volker Modified:

svn commit: samba r14246 - branches/SAMBA_3_0/source/client trunk/source/client

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 17:48:51 + (Sun, 12 Mar 2006) New Revision: 14246 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14246 Log: Fix Coverity bug # 85 Modified: branches/SAMBA_3_0/source/client/clitar.c trunk/source/client/clitar.c Changeset:

svn commit: samba r14247 - branches/SAMBA_3_0/source/registry trunk/source/registry

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 17:53:57 + (Sun, 12 Mar 2006) New Revision: 14247 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14247 Log: Fix Coverity bug # 136 Modified: branches/SAMBA_3_0/source/registry/reg_db.c trunk/source/registry/reg_db.c

svn commit: samba r14248 - branches/SAMBA_3_0/source/client trunk/source/client

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 17:57:05 + (Sun, 12 Mar 2006) New Revision: 14248 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14248 Log: Fix Coverity bug # 84 Modified: branches/SAMBA_3_0/source/client/clitar.c trunk/source/client/clitar.c Changeset:

svn commit: samba r14249 - branches/SAMBA_3_0/source/lib trunk/source/lib

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-12 18:01:36 + (Sun, 12 Mar 2006) New Revision: 14249 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14249 Log: We've dereferenced the_acl before, no point in checking. Fix Coverity bug # 128. Volker Modified:

svn commit: samba r14250 - in branches/SAMBA_3_0/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-12 19:16:45 + (Sun, 12 Mar 2006) New Revision: 14250 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14250 Log: Fix coverity bug #107. Resource leak on error path. Jeremy. Modified: branches/SAMBA_3_0/source/rpc_server/srv_spoolss_nt.c

svn commit: samba r14251 - in trunk/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-12 19:16:57 + (Sun, 12 Mar 2006) New Revision: 14251 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14251 Log: Fix coverity bug #107. Resource leak on error path. Jeremy. Modified: trunk/source/rpc_server/srv_spoolss_nt.c Changeset:

svn commit: samba r14252 - branches/SAMBA_3_0/source/libads trunk/source/libads

2006-03-12 Thread jmcd
Author: jmcd Date: 2006-03-12 19:56:10 + (Sun, 12 Mar 2006) New Revision: 14252 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14252 Log: Fix Coverity #72: free alloc'ed storage before return. Also found one more that coverity didn't find from asprintf.

svn commit: samba r14253 - in trunk/source: include param web

2006-03-12 Thread idra
Author: idra Date: 2006-03-12 21:28:11 + (Sun, 12 Mar 2006) New Revision: 14253 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14253 Log: fix trunk ! revert jpeach's patch Modified: trunk/source/include/smb.h trunk/source/param/loadparm.c

svn commit: samba r14254 - in trunk/source: include passdb

2006-03-12 Thread idra
Author: idra Date: 2006-03-12 21:40:53 + (Sun, 12 Mar 2006) New Revision: 14254 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14254 Log: Some more pdb_ldap talloc-ification Simo. Modified: trunk/source/include/smbldap.h trunk/source/passdb/pdb_ldap.c

svn commit: samba r14255 - in branches/SAMBA_3_0/source: include param web

2006-03-12 Thread jpeach
Author: jpeach Date: 2006-03-12 22:27:01 + (Sun, 12 Mar 2006) New Revision: 14255 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14255 Log: Revert r14204 which was horribly broken. Modified: branches/SAMBA_3_0/source/include/smb.h

Re: svn commit: samba r14253 - in trunk/source: include param web

2006-03-12 Thread James Peach
On Sun, 2006-03-12 at 21:28 +, [EMAIL PROTECTED] wrote: Author: idra Date: 2006-03-12 21:28:11 + (Sun, 12 Mar 2006) New Revision: 14253 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14253 Log: fix trunk ! revert jpeach's patch Sorry about that.

svn commit: samba r14257 - in trunk/source/passdb: .

2006-03-12 Thread idra
Author: idra Date: 2006-03-12 23:09:31 + (Sun, 12 Mar 2006) New Revision: 14257 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14257 Log: commit some fixes to the previous patch as Volker pointed out some flaws. Modified: trunk/source/passdb/pdb_ldap.c

Re: svn commit: samba r14173 - (fnum and smb_file change)

2006-03-12 Thread Stefan (metze) Metzmacher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [EMAIL PROTECTED] schrieb: I'd much rather go back to the old structures, although it might be OK to change uint16_t fnum to smb_handle fnum, and make smb_handle be a union of uint16 and a smb2_handle. I'm not certain that is a good idea though,

Re: svn commit: samba r14257 - in trunk/source/passdb: .

2006-03-12 Thread Jeremy Allison
On Sun, Mar 12, 2006 at 11:09:32PM +, [EMAIL PROTECTED] wrote: Author: idra Date: 2006-03-12 23:09:31 + (Sun, 12 Mar 2006) New Revision: 14257 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14257 Log: commit some fixes to the previous patch as

Build status as of Mon Mar 13 00:00:02 2006

2006-03-12 Thread build
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2006-03-12 00:00:23.0 + +++ /home/build/master/cache/broken_results.txt 2006-03-13 00:00:04.0 + @@ -1,17 +1,17 @@ -Build status as of Sun Mar 12 00:00:02 2006 +Build status as of Mon Mar

svn commit: samba r14258 - in trunk/source/client: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:00:46 + (Mon, 13 Mar 2006) New Revision: 14258 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14258 Log: This file is very out-of-sync with 3.0. Steve, looks like the SAMBA_3_0 branch is more current. Please keep these up to date.

svn commit: samba r14259 - in branches/SAMBA_3_0/source/nsswitch: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:05:47 + (Mon, 13 Mar 2006) New Revision: 14259 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14259 Log: Fix coverity #42. Ensure contact_domain can't be null derefed in error code path. Jeremy. Modified:

svn commit: samba r14260 - in trunk/source/nsswitch: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:05:52 + (Mon, 13 Mar 2006) New Revision: 14260 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14260 Log: Fix coverity #42. Ensure contact_domain can't be null derefed in error code path. Jeremy. Modified:

svn commit: samba r14261 - in branches/SAMBA_3_0/source/libmsrpc: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:08:39 + (Mon, 13 Mar 2006) New Revision: 14261 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14261 Log: Fix coverity #38. No null deref. Jeremy. Modified: branches/SAMBA_3_0/source/libmsrpc/cac_winreg.c Changeset: Modified:

svn commit: samba r14262 - in trunk/source/libmsrpc: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:08:44 + (Mon, 13 Mar 2006) New Revision: 14262 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14262 Log: Fix coverity #38. No null deref. Jeremy. Modified: trunk/source/libmsrpc/cac_winreg.c Changeset: Modified:

svn commit: samba r14263 - in trunk/source/passdb: .

2006-03-12 Thread idra
Author: idra Date: 2006-03-13 00:10:40 + (Mon, 13 Mar 2006) New Revision: 14263 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14263 Log: We should simply not talloc_free(0 here at all as now the memory context is not managed by this function. Remove also

Re: svn commit: samba r14257 - in trunk/source/passdb: .

2006-03-12 Thread simo
On Sun, 2006-03-12 at 15:48 -0800, Jeremy Allison wrote: On Sun, Mar 12, 2006 at 11:09:32PM +, [EMAIL PROTECTED] wrote: Author: idra Date: 2006-03-12 23:09:31 + (Sun, 12 Mar 2006) New Revision: 14257 WebSVN:

Re: svn commit: samba r14257 - in trunk/source/passdb: .

2006-03-12 Thread Jeremy Allison
On Sun, Mar 12, 2006 at 07:12:03PM -0500, simo wrote: On Sun, 2006-03-12 at 15:48 -0800, Jeremy Allison wrote: On Sun, Mar 12, 2006 at 11:09:32PM +, [EMAIL PROTECTED] wrote: Author: idra Date: 2006-03-12 23:09:31 + (Sun, 12 Mar 2006) New Revision: 14257 WebSVN:

Re: svn commit: samba r14257 - in trunk/source/passdb: .

2006-03-12 Thread simo
On Sun, 2006-03-12 at 16:18 -0800, Jeremy Allison wrote: On Sun, Mar 12, 2006 at 07:12:03PM -0500, simo wrote: On Sun, 2006-03-12 at 15:48 -0800, Jeremy Allison wrote: On Sun, Mar 12, 2006 at 11:09:32PM +, [EMAIL PROTECTED] wrote: Author: idra Date: 2006-03-12 23:09:31 +

svn commit: samba r14264 - in branches/SAMBA_3_0/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:23:17 + (Mon, 13 Mar 2006) New Revision: 14264 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14264 Log: Fix coverity #207. Resource leak on error path. Jeremy. Modified: branches/SAMBA_3_0/source/rpc_server/srv_spoolss_nt.c

svn commit: samba r14265 - in trunk/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:23:22 + (Mon, 13 Mar 2006) New Revision: 14265 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14265 Log: Fix coverity #207. Resource leak on error path. Jeremy. Modified: trunk/source/rpc_server/srv_spoolss_nt.c Changeset:

svn commit: samba r14266 - in branches/SAMBA_3_0/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:25:04 + (Mon, 13 Mar 2006) New Revision: 14266 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14266 Log: Fix coverity #205. Resource leak on error path. Jeremy. Modified: branches/SAMBA_3_0/source/rpc_server/srv_spoolss_nt.c

svn commit: samba r14267 - in trunk/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:25:10 + (Mon, 13 Mar 2006) New Revision: 14267 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14267 Log: Fix coverity #205. Resource leak on error path. Jeremy. Modified: trunk/source/rpc_server/srv_spoolss_nt.c Changeset:

svn commit: samba r14268 - in branches/SAMBA_3_0/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:26:38 + (Mon, 13 Mar 2006) New Revision: 14268 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14268 Log: Fix coverity error #204. Resource leak on error path. Jeremy. Modified:

svn commit: samba r14269 - in trunk/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:26:42 + (Mon, 13 Mar 2006) New Revision: 14269 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14269 Log: Fix coverity error #204. Resource leak on error path. Jeremy. Modified: trunk/source/rpc_server/srv_spoolss_nt.c

svn commit: samba r14270 - in branches/SAMBA_3_0/source/nsswitch: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:30:18 + (Mon, 13 Mar 2006) New Revision: 14270 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14270 Log: Fix coverity #203. Ensure we free on error exit. Jeremy. Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_group.c

svn commit: samba r14271 - in trunk/source/nsswitch: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:30:23 + (Mon, 13 Mar 2006) New Revision: 14271 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14271 Log: Fix coverity #203. Ensure we free on error exit. Jeremy. Modified: trunk/source/nsswitch/winbindd_group.c Changeset:

Re: svn commit: samba r14257 - in trunk/source/passdb: .

2006-03-12 Thread Jeremy Allison
On Sun, Mar 12, 2006 at 07:22:18PM -0500, simo wrote: Yes, I'm following the streams of patches. Do you know what I thought when I saw it? That would not have happened if we had a talloc hierarchy. A talloc hierarchy hung off random pointers is a poor man's C++ (IMHO). It can be horribly

svn commit: samba r14272 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-12 Thread jmcd
Author: jmcd Date: 2006-03-13 00:35:33 + (Mon, 13 Mar 2006) New Revision: 14272 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14272 Log: Fix Coverity # 81: free alloc'ed storage before returning Modified: branches/SAMBA_3_0/source/utils/smbcacls.c

Re: svn commit: samba r14257 - in trunk/source/passdb: .

2006-03-12 Thread simo
On Sun, 2006-03-12 at 16:32 -0800, Jeremy Allison wrote: On Sun, Mar 12, 2006 at 07:22:18PM -0500, simo wrote: Yes, I'm following the streams of patches. Do you know what I thought when I saw it? That would not have happened if we had a talloc hierarchy. A talloc hierarchy hung off

svn commit: samba r14273 - in branches/SAMBA_3_0/source/printing: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:37:57 + (Mon, 13 Mar 2006) New Revision: 14273 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14273 Log: Fix coverity bug #202. Memory leak on error path. Jeremy. Modified: branches/SAMBA_3_0/source/printing/nt_printing.c

svn commit: samba r14274 - in trunk/source/printing: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 00:38:03 + (Mon, 13 Mar 2006) New Revision: 14274 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14274 Log: Fix coverity bug #202. Memory leak on error path. Jeremy. Modified: trunk/source/printing/nt_printing.c Changeset:

svn commit: samba r14275 - in branches/SAMBA_3_0/source/nsswitch: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 01:08:27 + (Mon, 13 Mar 2006) New Revision: 14275 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14275 Log: Shut-up coverity false positive (bug #199) by making an assertion explicit. Jeremy. Modified:

svn commit: samba r14276 - in trunk/source/nsswitch: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 01:08:34 + (Mon, 13 Mar 2006) New Revision: 14276 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14276 Log: Shut-up coverity false positive (bug #199) by making an assertion explicit. Jeremy. Modified:

svn commit: samba r14277 - in trunk/source/passdb: .

2006-03-12 Thread idra
Author: idra Date: 2006-03-13 01:32:30 + (Mon, 13 Mar 2006) New Revision: 14277 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14277 Log: talloc_free() - TALLOC_FREE() Modified: trunk/source/passdb/pdb_ldap.c Changeset: Modified:

svn commit: samba r14278 - branches/SAMBA_3_0/source/utils trunk/source/utils

2006-03-12 Thread jmcd
Author: jmcd Date: 2006-03-13 01:32:30 + (Mon, 13 Mar 2006) New Revision: 14278 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14278 Log: Remainder of fix for Coverity #79,80,81: only allow GROUP or OWNER to be specified once in an ACL, so it can be allocated a

svn commit: samba r14279 - branches/SAMBA_3_0/source/libsmb trunk/source/libsmb

2006-03-12 Thread jmcd
Author: jmcd Date: 2006-03-13 01:42:40 + (Mon, 13 Mar 2006) New Revision: 14279 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14279 Log: Fix coverity #86, 87, 88, 89: Free grp_sid and owner_sid before returning. Also, only allow one group or owner. Modified:

svn commit: samba r14280 - branches/SAMBA_3_0/source/lib trunk/source/lib

2006-03-12 Thread jmcd
Author: jmcd Date: 2006-03-13 01:49:01 + (Mon, 13 Mar 2006) New Revision: 14280 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14280 Log: Fix Coverity #129 and 130: check before dereferencing a pointer. This was especially silly as we checked immediately _after_

svn commit: samba r14281 - in branches/SAMBA_4_0/source: . build/m4 build/smb_build heimdal/lib/asn1 intl lib/util script

2006-03-12 Thread jelmer
Author: jelmer Date: 2006-03-13 02:05:39 + (Mon, 13 Mar 2006) New Revision: 14281 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14281 Log: Pull apart LIBDIR and MODULESDIR Move architecture-independent data to DATADIR (was LIBDIR) Modified:

svn commit: samba r14282 - in branches/SAMBA_3_0/source/nsswitch: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 03:50:26 + (Mon, 13 Mar 2006) New Revision: 14282 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14282 Log: Change centry_string to only use talloc. Should quieten coverity bug #194 (which I think is a false positive). Jeremy.

svn commit: samba r14283 - in trunk/source/nsswitch: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 03:50:28 + (Mon, 13 Mar 2006) New Revision: 14283 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14283 Log: Change centry_string to only use talloc. Should quieten coverity bug #194 (which I think is a false positive). Jeremy.

svn commit: samba r14285 - in trunk/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 03:56:29 + (Mon, 13 Mar 2006) New Revision: 14285 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14285 Log: Fix coverity bug #103. Make code clearer - probably not a real issue but this code is easier to read. Jeremy. Modified:

svn commit: samba r14284 - in branches/SAMBA_3_0/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 03:56:24 + (Mon, 13 Mar 2006) New Revision: 14284 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14284 Log: Fix coverity bug #103. Make code clearer - probably not a real issue but this code is easier to read. Jeremy. Modified:

svn commit: samba r14287 - in trunk/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 03:59:58 + (Mon, 13 Mar 2006) New Revision: 14287 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14287 Log: Similar clarifiction fix for coverity #102. Jeremy. Modified: trunk/source/rpc_server/srv_spoolss_nt.c Changeset:

svn commit: samba r14288 - in branches/SAMBA_4_0/source/lib/talloc: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 04:04:38 + (Mon, 13 Mar 2006) New Revision: 14288 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14288 Log: - make the snprintf call in talloc portable to older solaris boxes - fixed an error found sing the beam analyser

svn commit: samba r14289 - in branches/SAMBA_3_0/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 04:05:47 + (Mon, 13 Mar 2006) New Revision: 14289 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14289 Log: Fix coverity #101, resource leak on error code path. Jeremy. Modified:

svn commit: samba r14290 - in trunk/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 04:05:51 + (Mon, 13 Mar 2006) New Revision: 14290 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14290 Log: Fix coverity #101, resource leak on error code path. Jeremy. Modified: trunk/source/rpc_server/srv_spoolss_nt.c

svn commit: samba r14291 - in trunk/source/lib: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 04:27:47 + (Mon, 13 Mar 2006) New Revision: 14291 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14291 Log: Janitor for tridge (samba3 talloc is almost identical to Samba4 talloc). Jeremy - make the snprintf call in talloc portable

svn commit: samba r14292 - in branches/SAMBA_3_0/source/lib: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 04:27:53 + (Mon, 13 Mar 2006) New Revision: 14292 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14292 Log: Janitor for tridge (samba3 talloc is almost identical to Samba4 talloc). Jeremy - make the snprintf call in talloc portable

svn commit: samba r14293 - in branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 05:00:45 + (Mon, 13 Mar 2006) New Revision: 14293 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14293 Log: fixed some errors found with beam Modified: branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/password_hash.c

svn commit: samba r14294 - in branches/SAMBA_4_0/source/include: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 05:01:34 + (Mon, 13 Mar 2006) New Revision: 14294 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14294 Log: conditionally define _PUBLIC_, so you can disable it easily with -D_PUBLIC_= Modified:

svn commit: samba r14295 - in branches/SAMBA_4_0/source/lib/registry: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 05:01:58 + (Mon, 13 Mar 2006) New Revision: 14295 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14295 Log: make sure we return a valid data blob Modified: branches/SAMBA_4_0/source/lib/registry/reg_backend_nt4.c Changeset:

svn commit: samba r14296 - in branches/SAMBA_4_0/source/lib/util: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 05:02:30 + (Mon, 13 Mar 2006) New Revision: 14296 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14296 Log: added an abort() to SMB_ASSERT() so that static analysers know it doesn't return Modified:

svn commit: samba r14297 - in branches/SAMBA_4_0/source/libcli/dgram: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 05:02:49 + (Mon, 13 Mar 2006) New Revision: 14297 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14297 Log: make sure we can go through the loop for than once Modified: branches/SAMBA_4_0/source/libcli/dgram/mailslot.c

svn commit: samba r14298 - branches/SAMBA_3_0/source/rpc_parse trunk/source/rpc_parse

2006-03-12 Thread vlendec
Author: vlendec Date: 2006-03-13 06:44:10 + (Mon, 13 Mar 2006) New Revision: 14298 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14298 Log: The other half of Coverity # 217 Modified: branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c

svn commit: samba r14299 - in branches/SAMBA_3_0/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 06:48:41 + (Mon, 13 Mar 2006) New Revision: 14299 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14299 Log: Fix coverity #225. In a loop we were forgetting to free resources on error exit path. Jeremy. Modified:

svn commit: samba r14300 - in trunk/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 06:48:48 + (Mon, 13 Mar 2006) New Revision: 14300 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14300 Log: Fix coverity #225. In a loop we were forgetting to free resources on error exit path. Jeremy. Modified:

svn commit: samba r14301 - in branches/SAMBA_3_0/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 06:50:33 + (Mon, 13 Mar 2006) New Revision: 14301 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14301 Log: Fix coverity #224. In a loop we were forgetting to free resources on error exit path. Jeremy. Modified:

svn commit: samba r14302 - in trunk/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 06:50:40 + (Mon, 13 Mar 2006) New Revision: 14302 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14302 Log: Fix coverity #224. In a loop we were forgetting to free resources on error exit path. Jeremy. Modified:

svn commit: samba r14303 - in branches/SAMBA_3_0/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 06:52:03 + (Mon, 13 Mar 2006) New Revision: 14303 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14303 Log: Fix coverity #223. In a loop we were forgetting to free resources on error exit path. Jeremy. Modified:

svn commit: samba r14304 - in trunk/source/rpc_server: .

2006-03-12 Thread jra
Author: jra Date: 2006-03-13 06:52:09 + (Mon, 13 Mar 2006) New Revision: 14304 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14304 Log: Fix coverity #223. In a loop we were forgetting to free resources on error exit path. Jeremy. Modified:

svn commit: samba r14305 - in branches/SAMBA_4_0/source/auth: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 06:56:07 + (Mon, 13 Mar 2006) New Revision: 14305 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14305 Log: fixed a memory leak and a break error Modified: branches/SAMBA_4_0/source/auth/auth_unix.c Changeset: Modified:

svn commit: samba r14306 - in branches/SAMBA_4_0/source/auth/kerberos: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 06:56:31 + (Mon, 13 Mar 2006) New Revision: 14306 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14306 Log: fixed two break errors Modified: branches/SAMBA_4_0/source/auth/kerberos/krb5_init_context.c Changeset: Modified:

svn commit: samba r14307 - in branches/SAMBA_4_0/source/lib/socket: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 06:57:11 + (Mon, 13 Mar 2006) New Revision: 14307 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14307 Log: fixed dereference of my_address-addr when NULL Modified: branches/SAMBA_4_0/source/lib/socket/socket_unix.c

svn commit: samba r14308 - in branches/SAMBA_4_0/source/lib/util: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 06:58:09 + (Mon, 13 Mar 2006) New Revision: 14308 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14308 Log: fixed an out of range shift and an uninitialised error Modified: branches/SAMBA_4_0/source/lib/util/idtree.c

svn commit: samba r14309 - in branches/SAMBA_4_0/source/lib/util: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 06:58:32 + (Mon, 13 Mar 2006) New Revision: 14309 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14309 Log: make sure ret is initialised Modified: branches/SAMBA_4_0/source/lib/util/module.c Changeset: Modified:

svn commit: samba r14310 - in branches/SAMBA_4_0/source/librpc/ndr: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 06:58:51 + (Mon, 13 Mar 2006) New Revision: 14310 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14310 Log: length needs to be initialised Modified: branches/SAMBA_4_0/source/librpc/ndr/ndr_basic.c Changeset: Modified:

svn commit: samba r14311 - in branches/SAMBA_4_0/source/librpc/rpc: .

2006-03-12 Thread tridge
Author: tridge Date: 2006-03-13 06:59:06 + (Mon, 13 Mar 2006) New Revision: 14311 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=14311 Log: canon needs to be initialised Modified: branches/SAMBA_4_0/source/librpc/rpc/dcerpc_sock.c Changeset: Modified:

Re: svn commit: samba r14173 - (fnum and smb_file change)

2006-03-12 Thread tridge
Metze, are you ok with r14256? The structures are definately better, but it seems to be failing quite a few tests :-) for example, RAW-UNLINK is failing. I'm pretty sure it was this patch that causes it, but I haven't worked out how yet. the idea with this is that I'll later add struct

Re: svn commit: samba r14173 - (fnum and smb_file change)

2006-03-12 Thread Stefan (metze) Metzmacher
Metze, are you ok with r14256? The structures are definately better, but it seems to be failing quite a few tests :-) for example, RAW-UNLINK is failing. I'm pretty sure it was this patch that causes it, but I haven't worked out how yet. sorry, I take a look at it in about 5 hours,