Re: [SeaBIOS] [PATCH 00/10] Some TPM simplifications

2016-01-05 Thread Kevin O'Connor
On Tue, Jan 05, 2016 at 05:05:20PM -0500, Stefan Berger wrote: > "Kevin O'Connor" wrote on 01/05/2016 03:35:35 PM: [...] > > - Take "measurements" during the boot process so that later on users > > can verify if some low-level code has changed (and thu

Re: [SeaBIOS] eDP Init Failure on Broadwell

2016-01-05 Thread Kevin O'Connor
On Sun, Jan 03, 2016 at 07:33:14PM +, CoolStar Organization wrote: > Here's the cbmem with the updated patch. Thanks. To summarize our conversation on IRC, it looks like some hardware flags for this board are changed in coreboot that impact the option rom. The flags are set after coreboot at

Re: [SeaBIOS] [PATCH 00/10] Some TPM simplifications

2016-01-05 Thread Kevin O'Connor
On Tue, Jan 05, 2016 at 02:05:55PM -0500, Stefan Berger wrote: > "Kevin O'Connor" wrote on 01/05/2016 12:16:18 PM: > > On Tue, Dec 29, 2015 at 07:17:40PM -0500, Kevin O'Connor wrote: > > > The following series involves some code reorganization in the

Re: [SeaBIOS] [PATCH 0/8] TPM return code simplifications

2016-01-05 Thread Kevin O'Connor
On Wed, Dec 30, 2015 at 02:31:54PM -0500, Kevin O'Connor wrote: > Hi Stefan, > > I cleaned up the additional patches I mentioned yesterday. > > Some time back, you posted a series of patches that removed the use of > TCG 16bit BIOS structs from internal functions. Many of

[SeaBIOS] [PATCH] usb: Remove usbdev->slotid field

2016-01-05 Thread Kevin O'Connor
The usbdev->slotid field is xhci specific and on xhci it is always reachable from usbdev->defpipe->slotid. Signed-off-by: Kevin O'Connor --- src/hw/usb-xhci.c | 6 -- src/hw/usb.h | 1 - 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/hw/usb-xhci.

Re: [SeaBIOS] [PATCH 00/10] Some TPM simplifications

2016-01-05 Thread Kevin O'Connor
On Tue, Dec 29, 2015 at 07:17:40PM -0500, Kevin O'Connor wrote: > The following series involves some code reorganization in the TPM code > that I found useful in understanding the code. FYI, I committed patches 1-9 (after some bug fixe

Re: [SeaBIOS] eDP Init Failure on Broadwell

2016-01-03 Thread Kevin O'Connor
On Sun, Jan 03, 2016 at 07:13:03PM +, CoolStar Organization wrote: > Here is the cbmem with the debug patch. Can you try with this debug patch instead? -Kevin --- a/src/vgahooks.c +++ b/src/vgahooks.c @@ -299,10 +299,19 @@ winent_mb6047_setup(struct pci_device *pci) * Entry and setup **

Re: [SeaBIOS] eDP Init Failure on Broadwell

2016-01-03 Thread Kevin O'Connor
On Sun, Jan 03, 2016 at 06:48:34PM +, CoolStar Organization wrote: > I'm using SeaBIOS 1.9.0 stable. I'm building with make/gcc on Ubuntu 14.04 > LTS. Will try those patches in a few. Are you building from the git repo or from a tar file? Can you cut-and-paste the build output from "make clea

Re: [SeaBIOS] eDP Init Failure on Broadwell

2016-01-03 Thread Kevin O'Connor
On Sun, Jan 03, 2016 at 06:29:16PM +, CoolStar Organization wrote: > I have attached 4 cbmem's. > > cbmem.txt is with coreboot running the ROM & seabios using SeaVGABIOS. eDP > Inits properly and all is fine. > > I thought textmode might be the issue so I added a bootsplash but still no > dic

Re: [SeaBIOS] eDP Init Failure on Broadwell

2016-01-03 Thread Kevin O'Connor
On Sun, Jan 03, 2016 at 05:30:44PM +, CoolStar Organization wrote: > On a Broadwell based chromebook with upstream coreboot & SeaBIOS, SeaBIOS > fails to initialize the built-in display. > > If coreboot is configured to run the optionrom, keep the VESA framebuffer > and use VESA mode 4117 (102

Re: [SeaBIOS] [PATCH 2/8] tpm: No need to check the return status of measurements

2015-12-30 Thread Kevin O'Connor
On Wed, Dec 30, 2015 at 07:09:54PM -0500, Stefan Berger wrote: > On 12/30/2015 02:31 PM, Kevin O'Connor wrote: > >The low-level measurement functions already handle error conditions, > >there is no need to check for the errors in the high level measurement > >functions. &

Re: [SeaBIOS] [PATCH 03/10] tpm: Simplify hardware probe and detection checks

2015-12-30 Thread Kevin O'Connor
On Wed, Dec 30, 2015 at 07:06:58PM -0500, Kevin O'Connor wrote: > On Wed, Dec 30, 2015 at 06:57:23PM -0500, Stefan Berger wrote: > > On 12/29/2015 07:17 PM, Kevin O'Connor wrote: > > >+static u8 TPM_working; > > > > Should this not also have VARLOW to not

Re: [SeaBIOS] [PATCH 03/10] tpm: Simplify hardware probe and detection checks

2015-12-30 Thread Kevin O'Connor
On Wed, Dec 30, 2015 at 06:57:23PM -0500, Stefan Berger wrote: > On 12/29/2015 07:17 PM, Kevin O'Connor wrote: > >Perform the hardware probe once during setup instead of checking if > >the probe has been completed on each measurement event. > > > >Don't pro

[SeaBIOS] [PATCH 5/8] tpm: Don't use 16bit BIOS return codes in tpm_log_event()

2015-12-30 Thread Kevin O'Connor
Don't use the return codes from the 16bit BIOS spec in the internal tpm_log_event() and tpm_log_extend_event() functions. Only the 16bit BIOS interface code should need to handle the details of that spec. Signed-off-by: Kevin O'Connor --- src/tcgb

[SeaBIOS] [PATCH 1/8] tpm: Don't return a status from external bios measurement functions

2015-12-30 Thread Kevin O'Connor
The callers of the measurements don't care what happens, so no need to return a status. Signed-off-by: Kevin O'Connor --- src/tcgbios.c | 58 -- src/tcgbios.h | 8 2 files changed, 32 insertions(+), 34 deletions(-) di

[SeaBIOS] [PATCH 4/8] tpm: Don't use 16bit BIOS return codes in build_and_send_cmd()

2015-12-30 Thread Kevin O'Connor
gging dprintf() in build_and_send_cmd() instead of in every caller. This replaces the command name with the integer command id, but it does make the debugging more consistent. Signed-off-by: Kevin O'Connor --- src/tcgbios.c | 216

[SeaBIOS] [PATCH 3/8] tpm: Don't call tpm_set_failure() from tpm_log_extend_event()

2015-12-30 Thread Kevin O'Connor
The 16bit BIOS interface shouldn't be able to shutdown the TPM. Move the check for tpm_is_working() and tpm_set_failure() to the only caller of tpm_log_extend_event() that may shutdown the TPM. Signed-off-by: Kevin O'Connor --- src/tcgbios.c | 21 + 1 file

[SeaBIOS] [PATCH 7/8] tpm: Don't use 16bit BIOS return codes in TPM menu functions

2015-12-30 Thread Kevin O'Connor
igned-off-by: Kevin O'Connor --- src/tcgbios.c | 227 +- 1 file changed, 97 insertions(+), 130 deletions(-) diff --git a/src/tcgbios.c b/src/tcgbios.c index b31de39..cd6a433 100644 --- a/src/tcgbios.c +++ b/src/tcgbios.c @@ -889

[SeaBIOS] [PATCH 2/8] tpm: No need to check the return status of measurements

2015-12-30 Thread Kevin O'Connor
The low-level measurement functions already handle error conditions, there is no need to check for the errors in the high level measurement functions. Signed-off-by: Kevin O'Connor --- src/tcgbios.c | 119 -- 1 file changed, 40 inser

[SeaBIOS] [PATCH 8/8] tpm: Replace build_and_send_cmd with tpm_send_cmd and tpm_send_check_cmd

2015-12-30 Thread Kevin O'Connor
code line number in the debugging, but all callers of tpm_set_failure() will log the action that failed immediately prior to the dprintf(). So, the line number should not be necessary. Signed-off-by: Kevin O'Connor --- src/tcgbios.c

[SeaBIOS] [PATCH 6/8] tpm: Don't use 16bit BIOS return codes in tpmhw_* functions

2015-12-30 Thread Kevin O'Connor
Don't use the return codes from the 16bit BIOS spec in the internal tpmhw functions. Only the 16bit BIOS interface code should need to handle the details of that spec. Signed-off-by: Kevin O'Connor --- src/hw/tpm_drivers.c | 20 ++-- src/hw/tpm_drivers.h | 2 +- src

[SeaBIOS] [PATCH 0/8] TPM return code simplifications

2015-12-30 Thread Kevin O'Connor
replaces patch 10 of the previous series). Both series are also available at: https://github.com/KevinOConnor/seabios/tree/testing I'm not currently planning any other TPM changes after these. -Kevin Kevin O'Connor (8): tpm: Don't return a status from external bios measurement

Re: [SeaBIOS] [PATCH 08/10] tpm: Introduce tpm_get_capability() helper function

2015-12-29 Thread Kevin O'Connor
On Tue, Dec 29, 2015 at 09:09:09PM -0500, Stefan Berger wrote: > On 12/29/2015 07:17 PM, Kevin O'Connor wrote: > >+static int > >+tpm_get_capability(u32 cap, u32 subcap, struct tpm_rsp_header *rsp, u32 > >rsize) > >+{ > >+struct tpm_req_getcap trgc

Re: [SeaBIOS] [PATCH 10/10] tpm: Return returnCode from build_and_send_cmd() instead of via pointer param

2015-12-29 Thread Kevin O'Connor
On Tue, Dec 29, 2015 at 10:11:14PM -0500, Stefan Berger wrote: > On 12/29/2015 07:17 PM, Kevin O'Connor wrote: > >The callers interested in the return status of build_and_send_cmd() > >are only interested in the command return code status (returnCode) and > >not

[SeaBIOS] [PATCH 10/10] tpm: Return returnCode from build_and_send_cmd() instead of via pointer param

2015-12-29 Thread Kevin O'Connor
case that the command transmission fails, return -1 to signal the failure to the callers. Signed-off-by: Kevin O'Connor --- src/tcgbios.c | 139 -- 1 file changed, 66 insertions(+), 73 deletions(-) diff --git a/src/tcgbios.c b/src/tcgb

[SeaBIOS] [PATCH 01/10] tpm: Add banner separating the TCG bios interface code from TCG menu code

2015-12-29 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/tcgbios.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/tcgbios.c b/src/tcgbios.c index 7b93d87..4f78c42 100644 --- a/src/tcgbios.c +++ b/src/tcgbios.c @@ -1187,6 +1187,11 @@ tpm_interrupt_handler32(struct bregs *regs) r

[SeaBIOS] [PATCH 00/10] Some TPM simplifications

2015-12-29 Thread Kevin O'Connor
simplify the parameters to the build_and_send_cmd() function. The remaining patches are mostly just code reorg. I have only compile tested these changes. -Kevin Kevin O'Connor (10): tpm: Add banner separating the TCG bios interface code from TCG menu code tpm: Avoid macro expansion o

[SeaBIOS] [PATCH 06/10] tpm: Rework TPM interface shutdown support

2015-12-29 Thread Kevin O'Connor
ns to fail.) Centralize the checking for the interface shutdown condition in tpm_interrupt_handler32(). Signed-off-by: Kevin O'Connor --- src/tcgbios.c | 63 +++ 1 file changed, 11 insertions(+), 52 deletions(-) diff --git a/src/tcgbios.c

[SeaBIOS] [PATCH 05/10] tpm: Move TPM hardware functions from tcgbios.c to hw/tpm_drivers.c

2015-12-29 Thread Kevin O'Connor
Move the hardware interface functions (tpmhw_probe, tpmhw_transmit, and tpmhw_set_timeouts) to tpm_drivers.c code, and only export those functions. This simplifies the hardware interface. Signed-off-by: Kevin O'Connor --- src/hw/tpm_drivers.c

[SeaBIOS] [PATCH 08/10] tpm: Introduce tpm_get_capability() helper function

2015-12-29 Thread Kevin O'Connor
Introduce helper function to call the TPM_ORD_GetCapability command. Update all get capability callers to use this helper. Signed-off-by: Kevin O'Connor --- src/std/tcg.h | 17 +++--- src/tcgbios.c | 176 -- 2 files changed, 57 inser

[SeaBIOS] [PATCH 09/10] tpm: Eliminate response buffer parameter from build_and_send_cmd()

2015-12-29 Thread Kevin O'Connor
There are no longer any callers that use the response buffer. Signed-off-by: Kevin O'Connor --- src/tcgbios.c | 45 + 1 file changed, 17 insertions(+), 28 deletions(-) diff --git a/src/tcgbios.c b/src/tcgbios.c index 510d4b3..c578fd2 100644 ---

[SeaBIOS] [PATCH 07/10] tpm: Simplify tcpa probe

2015-12-29 Thread Kevin O'Connor
-off-by: Kevin O'Connor --- src/tcgbios.c | 141 +++--- 1 file changed, 45 insertions(+), 96 deletions(-) diff --git a/src/tcgbios.c b/src/tcgbios.c index 3207478..8f9f321 100644 --- a/src/tcgbios.c +++ b/src/tcgbios.c @@ -61,14 +61,14 @@ s

[SeaBIOS] [PATCH 04/10] tpm: Add wrapper function tpm_set_timeouts()

2015-12-29 Thread Kevin O'Connor
Signed-off-by: Kevin O'Connor --- src/tcgbios.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/tcgbios.c b/src/tcgbios.c index 9448984..b680c1d 100644 --- a/src/tcgbios.c +++ b/src/tcgbios.c @@ -155,6 +155,13 @@ transmit(u8 locty, struct tpm_req_header

[SeaBIOS] [PATCH 02/10] tpm: Avoid macro expansion of tpm request / response structs

2015-12-29 Thread Kevin O'Connor
Avoid macros and use regular struct definitions for the request and response headers. This simplifies the header and reduces the need for casts in the code. Signed-off-by: Kevin O'Connor --- src/std/tcg.h | 40 +--- src/tcgbios.c | 11 +-- 2

[SeaBIOS] [PATCH 03/10] tpm: Simplify hardware probe and detection checks

2015-12-29 Thread Kevin O'Connor
igned-off-by: Kevin O'Connor --- src/tcgbios.c | 122 -- 1 file changed, 34 insertions(+), 88 deletions(-) diff --git a/src/tcgbios.c b/src/tcgbios.c index 55e38a9..9448984 100644 --- a/src/tcgbios.c +++ b/src/tcgbios.c @@ -67,11 +67,7

Re: [SeaBIOS] SeaBIOS crashes on CBFS without legacy header

2015-12-28 Thread Kevin O'Connor
On Mon, Dec 28, 2015 at 04:09:22PM -0800, Alex G. wrote: > > Are you suggesting that an (unsigned) cast should be added? I doubt > > it would matter. > > I'm suggesting to not rely on (0 - 4) to produce 0xfffc. The > (unsigned) cast does not solve the C issue of writing a negative value > int

Re: [SeaBIOS] SeaBIOS crashes on CBFS without legacy header

2015-12-28 Thread Kevin O'Connor
On Thu, Dec 24, 2015 at 03:45:03PM -0800, Alex Gagniuc wrote: > When SeaBIOS is run on an FMAP-based CBFS (AKA, without a CBFS master > header, it crashes). The problem is in coreboot_cbfs_init. A > disassembly with -Mintel shows the following: > > : >... >7: 8b 35 fc ff ff ff

Re: [SeaBIOS] [PATCH] build: fix typo in buildversion.py

2015-12-28 Thread Kevin O'Connor
On Mon, Dec 28, 2015 at 01:50:41PM +0100, Roger Pau Monne wrote: > Fixes the following build error: > > Building ld scripts > Traceback (most recent call last): > File "./scripts/buildversion.py", line 134, in > main() > File "./scripts/buildversion.py", line 114, in main > cleanbui

Re: [SeaBIOS] [PATCH] nmi: Don't try to switch onto extra stack in NMI handler

2015-12-28 Thread Kevin O'Connor
On Wed, Dec 23, 2015 at 03:47:26PM -0500, Kevin O'Connor wrote: > The NMI could occur when already on the extra stack, which would > corrupt it. Always use the current stack on an NMI to avoid this. FYI, I committed this change. -Kevin

Re: [SeaBIOS] [PATCH 1/2] scsi: Do not call printf() from scsi_is_ready()

2015-12-28 Thread Kevin O'Connor
On Wed, Dec 23, 2015 at 03:48:48PM -0500, Kevin O'Connor wrote: > The scsi_is_ready() function may be called from a thread, and it is > not valid to call printf() from a thread. Convert printf() to > dprintf() to avoid this possibility. > > This does mean that cdrom detect

Re: [SeaBIOS] [PATCH] xhci: Wait for port enable even for USB3 devices

2015-12-23 Thread Kevin O'Connor
On Sun, Dec 20, 2015 at 03:10:48PM -0500, Kevin O'Connor wrote: > Some USB3 controllers (and/or devices) need additional time after the > device is detected to place the port in an enabled state. Wait for > the controller to report enabled before proceeding. This fixes > s

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2015 at 09:27:25PM +0100, Peter Stuge wrote: > Kevin O'Connor wrote: > > SeaBIOS is careful to always disable IRQs while running C code to > > prevent this issue, but disabling normal IRQs does not disable NMIs. > > So, I believe this issue is spec

[SeaBIOS] [PATCH 2/2] block: Report drive->sectors using "%u" instead of "%d"

2015-12-23 Thread Kevin O'Connor
The sector count is a 64bit number that is often reported as a 32bit number (due to limitations in dprintf). Consistently use "%u" reporting to avoid confusing negative numbers. Reported-by: Tobias Diedrich Signed-off-by: Kevin O'Connor --- src/block.c | 2 +- src/hw

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

2015-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2015 at 09:14:44PM +0100, Tobias Diedrich wrote: > Final diff attached (without the src/stacks.c change, with %d->%u change > for sector counts). > Bootlog with debug_level 1 attached. Great! Patches sent - if no further comments I'll commit in a few days. -Kevin ___

[SeaBIOS] [PATCH 1/2] scsi: Do not call printf() from scsi_is_ready()

2015-12-23 Thread Kevin O'Connor
extra medium detection time is unlikely to be large anyway. Reported-by: Tobias Diedrich Signed-off-by: Kevin O'Connor --- src/hw/blockcmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/blockcmd.c b/src/hw/blockcmd.c index e20e3fc..0725b46 100644 --- a/s

[SeaBIOS] [PATCH] nmi: Don't try to switch onto extra stack in NMI handler

2015-12-23 Thread Kevin O'Connor
The NMI could occur when already on the extra stack, which would corrupt it. Always use the current stack on an NMI to avoid this. Signed-off-by: Kevin O'Connor --- src/romlayout.S | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/romlayout.S b/src/romlayout.S

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

2015-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2015 at 07:39:56PM +0100, Tobias Diedrich wrote: > On Wed, Dec 23, 2015 at 7:10 PM, Kevin O'Connor wrote: > > > On Wed, Dec 23, 2015 at 07:02:37PM +0100, Tobias Diedrich wrote: > > > Wcall16 with invalid stack: eax=dfbf3e62 edx=0 func=0x000f9563 > >

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

2015-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2015 at 07:13:27PM +0100, Tobias Diedrich wrote: > Wcall16 with invalid stack: eax=dfbf3e62 edx=0 func=0x000f9563 esp=dfbf3e50 > ret=0x000f2304 > > │.text:000F22C8 sub_F22C8 proc near ; CODE XREF: > sub_F2309+2Cvp > ▒ > │.text:000F22C8

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

2015-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2015 at 07:02:37PM +0100, Tobias Diedrich wrote: > Wcall16 with invalid stack: eax=dfbf3e62 edx=0 func=0x000f9563 esp=dfbf3e50 > > .text._farcall16 0x9563 : { *(.text._farcall16) } > Can you include the full log? It looks like the code tried to call a 16bit function while in a "

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2015 at 06:40:12AM +, Gonglei (Arei) wrote: > > From: Kevin O'Connor [mailto:ke...@koconnor.net] > > On Tue, Dec 22, 2015 at 02:14:12AM +, Gonglei (Arei) wrote: > > > Sorry, it doesn't work. What's worse is we cannot

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

2015-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2015 at 12:51:30PM -0500, Kevin O'Connor wrote: > On Wed, Dec 23, 2015 at 04:27:55PM +0100, Tobias Diedrich wrote: > > And with verbose logging (level 8). > > > > [...] > > Wcall16 with invalid stack > > Strange. Can you report the output

Re: [SeaBIOS] WD Elements hang SeaBIOS at boot with "call16 with invalid stack"

2015-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2015 at 04:27:55PM +0100, Tobias Diedrich wrote: > And with verbose logging (level 8). > > [...] > Wcall16 with invalid stack Strange. Can you report the output with the patch below? -Kevin --- a/src/stacks.c +++ b/src/stacks.c @@ -274,7 +274,8 @@ call16(u32 eax, u32 edx, void

Re: [SeaBIOS] SeaBIOS Digest, Vol 72, Issue 33

2015-12-22 Thread Kevin O'Connor
On Tue, Dec 22, 2015 at 11:03:09AM -0500, Stefan Berger wrote: > "Kevin O'Connor" wrote on 12/22/2015 10:40:03 AM: > > On Mon, Dec 21, 2015 at 11:50:07AM -0500, Stefan Berger wrote: > > > tpm_foo() > > > { > > > [...] > > > &g

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-22 Thread Kevin O'Connor
On Tue, Dec 22, 2015 at 02:14:12AM +, Gonglei (Arei) wrote: > > From: Kevin O'Connor [mailto:ke...@koconnor.net] > > Sent: Tuesday, December 22, 2015 2:47 AM > > To: Gonglei (Arei) > > Cc: Xulei (Stone); Paolo Bonzini; qemu-devel; seabios@seabios.org; > > Hua

Re: [SeaBIOS] SeaBIOS Digest, Vol 72, Issue 33

2015-12-22 Thread Kevin O'Connor
On Mon, Dec 21, 2015 at 11:50:07AM -0500, Stefan Berger wrote: > "Kevin O'Connor" wrote on 12/17/2015 05:22:56 PM: > > > > > On Mon, Nov 30, 2015 at 11:32:05AM +, Wim Vervoorn wrote: > > > Hello, > > > > > > I noticed that

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-22 Thread Kevin O'Connor
On Tue, Dec 22, 2015 at 03:15:26AM +, Xulei (Stone) wrote: > Hi, Kevin, > Can you tell how to reset/reboot this VM, if it goes to the handle_hwpic1() > on its booting procedure? I mean, usually, SeaBIOS would not go to > handle_hwpic routine. But in my test case, SeaBIOS calls handle_hwpic whe

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-21 Thread Kevin O'Connor
On Mon, Dec 21, 2015 at 04:53:24PM -0600, Matt DeVillier wrote: > FYI, the current testing branch (commit 977a7d4) has issues booting Windows > 10 via USB / Windows installer media on a Haswell ChromeBox (XHCI only), > locks up on the Windows logo. Tag 1.9.0 (commit 01a84be) has no such > issues.

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-21 Thread Kevin O'Connor
On Mon, Dec 21, 2015 at 06:44:18PM +, edward wandasiewicz wrote: > With 47-g977a7d4, we get > > 1. YES - we get no duplicate of the Philips, and get just one of each > appear in the boot list, Mushkin & Philips > > 2. NO - we sometimes get just the Mushkin only - no Philips detected - > with

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-21 Thread Kevin O'Connor
On Mon, Dec 21, 2015 at 09:41:32AM +, Gonglei (Arei) wrote: > When the gurb of OS is booting, then the softirq and C function send_disk_op() > may use extra stack of SeaBIOS. If we inject a NMI, romlayout.S: > irqentry_extrastack > is invoked, and the extra stack will be used again. And the st

Re: [SeaBIOS] 5 basic features provided by CSM, which SeaBIOS does provide?

2015-12-21 Thread Kevin O'Connor
On Mon, Dec 21, 2015 at 12:57:33PM +, Stojsavljevic, Zoran wrote: > Hello Kevin, > > All Good with setting CSM ON for legacy support. You need it for 16 bit > BIOSes, and for legacy OSes, such as WIN XP or WIN 7 and derivatives. > > Here is the question I am wondering: What if I decide to br

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-20 Thread Kevin O'Connor
On Sun, Dec 20, 2015 at 09:47:04PM +, edward wandasiewicz wrote: > As requested, for rel-1.9.0-46-g636cbb4. Thanks. So, same as before? > Is it worth testing the double scenario, or maybe put it down to a > "manufacturer's flaw" going forward? I need additional time to think about that and

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-20 Thread Kevin O'Connor
On Sun, Dec 20, 2015 at 08:23:40PM +, John Lewis wrote: > > > >Thanks, but the "badboot" log doesn't seem to show the failure. > > > > Apologies, not thinking again. How about that one? Okay - looks like you don't have the high/super confusion, but do need the wait for port enable. I cleaned

[SeaBIOS] [PATCH 1/2] xhci: Improve port status change debugging

2015-12-20 Thread Kevin O'Connor
Report the port state on a port status change notification. Clear the change bits so further change notifications are delivered. Signed-off-by: Kevin O'Connor --- src/hw/usb-xhci.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/hw/usb-xhci.c b/src/h

[SeaBIOS] [PATCH 2/2] xhci: Disable slot on failed set_address command

2015-12-20 Thread Kevin O'Connor
If the set_address command fails, attempt to free up the slot resource associated with the attempt. Signed-off-by: Kevin O'Connor --- src/hw/usb-xhci.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/hw/usb-xhci.c b/src/hw/usb-xhci.c index 5f44239..33

[SeaBIOS] [PATCH] xhci: Wait for port enable even for USB3 devices

2015-12-20 Thread Kevin O'Connor
ned-off-by: Kevin O'Connor --- src/hw/usb-xhci.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/src/hw/usb-xhci.c b/src/hw/usb-xhci.c index 945b462..654feba 100644 --- a/src/hw/usb-xhci.c +++ b/src/hw/usb-xhci.c @@

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-20 Thread Kevin O'Connor
On Sun, Dec 20, 2015 at 07:43:19PM +, John Lewis wrote: > On 2015-12-20 07:59, Kevin O'Connor wrote: > >On Sat, Dec 19, 2015 at 05:20:08PM +, John Lewis wrote: > >>How quickly do you think you'll upstream these changes, Kevin? - they > >>make a > >

Re: [SeaBIOS] [PATCH V2] fw/pci: do not automatically allocate IO region for PCIe bridges

2015-12-20 Thread Kevin O'Connor
On Mon, Dec 07, 2015 at 02:05:14PM +0200, Marcel Apfelbaum wrote: > PCIe downstream ports (Root Ports and switches Downstream Ports) appear > to firmware as PCI-PCI bridges and a 4K IO space is allocated for them > even if there is no device behind them requesting IO space, > all that for hotplug p

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

2015-12-20 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 06:18:27AM +0100, Peter Stuge wrote: > Sorry, should have sent all in one email. > > Stefan Berger wrote: > > +if (enable) > > +dprintf(DEBUG_tcg, "Return code from TPM_PhysicalEnable = > > 0x%08x\n", > > +*returnCode); > > +else > > +

Re: [SeaBIOS] [PATCH v2 0/3] tpm: Small fixes and add menu for TPM control

2015-12-20 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 11:14:16AM -0500, Stefan Berger wrote: > This series provides two small fixes and then adds the menu for TPM control. Thanks. Applied. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-20 Thread Kevin O'Connor
On Sun, Dec 20, 2015 at 09:49:54AM +, Gonglei (Arei) wrote: > > From: Kevin O'Connor [mailto:ke...@koconnor.net] > > Sent: Saturday, December 19, 2015 11:12 PM > > On Sat, Dec 19, 2015 at 12:03:15PM +, Gonglei (Arei) wrote: > > > Maybe the root cause is

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-20 Thread Kevin O'Connor
On Sat, Dec 19, 2015 at 05:20:08PM +, John Lewis wrote: > How quickly do you think you'll upstream these changes, Kevin? - they make a > USB 3.0 M2 SSD enclosure I've just bought, work, on the USB 3.0 port, > whereas it will only work with the USB 2.0 on upstream. Which version works, 0cc3233?

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-19 Thread Kevin O'Connor
On Sat, Dec 19, 2015 at 12:03:15PM +, Gonglei (Arei) wrote: > Maybe the root cause is not NMI but INTR, so yield() can open hardware > interrupt, > And then execute interrupt handler, but the interrupt handler make the SeaBIOS > stack broken, so that the BSP can't execute the instruction and o

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-18 Thread Kevin O'Connor
On Sat, Dec 19, 2015 at 01:49:04AM +, edward wandasiewicz wrote: > Is it a technically a manufacturer messing up the USB spec definitions it > should be following? That's a great question, and I don't know the answer to it. It would be great if there was some guidance in the USB3 spec to help

Re: [SeaBIOS] 5 basic features provided by CSM, which SeaBIOS does provide?

2015-12-18 Thread Kevin O'Connor
On Fri, Dec 18, 2015 at 08:43:37AM +, Stojsavljevic, Zoran wrote: > Hello both lists, Jiming, > > There are 5 basic features, provided by CSM SeaBIOS payload, and I > am looking to list of these features. > > Could you, please, provide to me list of these features, and some > description, and

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-18 Thread Kevin O'Connor
On Sat, Dec 19, 2015 at 01:51:15AM +0100, Peter Stuge wrote: > Kevin O'Connor wrote: > > > Doesn't it effectively take the same amount of wall clock time? > .. > > If you're asking if current state vs unregistering/delaying would take > > the same wall t

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-18 Thread Kevin O'Connor
On Sat, Dec 19, 2015 at 01:11:34AM +0100, Peter Stuge wrote: > Kevin O'Connor wrote: > > > > > Would checking the connection status for each device after all > > > > > devices have been registered be able to filter the USB2 device out? > > > >

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-18 Thread Kevin O'Connor
On Sat, Dec 19, 2015 at 12:52:15AM +0100, Peter Stuge wrote: > Kevin O'Connor wrote: > > > Would checking the connection status for each device after all > > > devices have been registered be able to filter the USB2 device out? > > > > Yes, but there isn&

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-18 Thread Kevin O'Connor
On Sat, Dec 19, 2015 at 12:11:59AM +0100, Peter Stuge wrote: > Kevin O'Connor wrote: > > Once the device is recognized as USB3, the controller disconnects > > it from USB2, but by that point SeaBIOS has already fully registered > > it and isn't even checking the co

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-18 Thread Kevin O'Connor
On Fri, Dec 18, 2015 at 03:04:58AM +, Gonglei (Arei) wrote: > Hi Kevin & Paolo, > > Luckily, I reproduced this problem last night. And I got the below log when > SeaBIOS is stuck. [...] > [2015-12-18 10:38:10] gonglei: finish while [...] > <...>-31509 [035] 154753.180077: kvm_exit: reason

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-18 Thread Kevin O'Connor
On Fri, Dec 18, 2015 at 11:51:16AM +, edward wandasiewicz wrote: > I thought, lets try swapping over the devices, but keeping the same > Type-C cables on the left and right hand side and see what happens. > > I get scenario 5. > > 5. NO - Type C & Type C - one Philiips & no Mushkin > > cbmem

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-18 Thread Kevin O'Connor
On Fri, Dec 18, 2015 at 08:12:22PM +, edward wandasiewicz wrote: > As requested. Thanks. It appears this particular device is being fully detected as a USB2 device (connection is detected, address is assigned, drive configuration is downloaded, and the drive is registered internally) before t

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-18 Thread Kevin O'Connor
On Fri, Dec 18, 2015 at 07:08:24PM +, edward wandasiewicz wrote: > Wrong file. Correct file attached. I checked for rel-1.9.0-45-gec65068 Thanks, can you retry with 46-g0cc3233 ? -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabio

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-18 Thread Kevin O'Connor
On Fri, Dec 18, 2015 at 06:11:56PM +, edward wandasiewicz wrote: > As requested. Thanks, but I had an off-by-one error in the patch - can you do the same thing with 45-gec65068? -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-18 Thread Kevin O'Connor
On Fri, Dec 18, 2015 at 11:51:16AM +, edward wandasiewicz wrote: > I managed to replicate a scenario 2 but with Type-C instead of USB 3, > with both 42-g9c58583 and 43-g55de21d > > 2(b) NO - Type C & Type C - once each (Philips & Muskin) - but double > Philips showing > > cbmem.yes.both.Type

Re: [SeaBIOS] Qemu-kvm VM halt at allocate VGA stack when continuously reset VM

2015-12-17 Thread Kevin O'Connor
On Thu, Dec 17, 2015 at 05:28:23AM +, Xulei (Stone) wrote: > 1. This problem seems have relations with PIC irq0 and host CPU feature: > On one of my host, this problem never happens while on another, it's > very easy to happen (both of hosts have the same kmod,qemu,libvirt and > SeaBIOS, SeaVG

Re: [SeaBIOS] SeaBIOS Digest, Vol 72, Issue 33

2015-12-17 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 11:32:05AM +, Wim Vervoorn wrote: > Hello, > > I noticed that a lot of work is going on for the TPM support in SeaBIOS. > > All of this work is TPM 1.2 based. I was wondering if there are any > plans to support TPM 2.0 in the future. I'm not aware of any plans. -Kevi

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-17 Thread Kevin O'Connor
On Mon, Dec 14, 2015 at 07:02:14PM -0500, Kevin O'Connor wrote: > The double detection looks like the controller doing something weird. > I need to look closer at the spec, but I don't think I'll be able to > do that until later in the week. After reviewing the spec I

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-14 Thread Kevin O'Connor
On Sun, Dec 13, 2015 at 09:16:02PM +, edward wandasiewicz wrote: > On Sun, Dec 13, 2015 at 9:05 PM, edward wandasiewicz <0.w3...@gmail.com> > wrote: > > Hooray, it works... minus 2 scenarios :( > > > > With both Philips USB and Mushkin USB attached, and I perform a cold boot > > > > 1. YES - U

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-13 Thread Kevin O'Connor
On Sun, Dec 13, 2015 at 10:49:30AM +, edward wandasiewicz wrote: > With both the Philips USB and Mushkin USB plugged in on boot, I'm > still getting 4 different scenarios appearing. > > 1. Philips Only > 2. Mushkin Only > 3. Both recognised - listed once and once only > 4. Both recognised - Mu

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-09 Thread Kevin O'Connor
On Fri, Dec 04, 2015 at 09:04:35PM +, edward wandasiewicz wrote: > Here's what happens with x1 Philips USB attached and x1 Mushkin > attached, and we cold boot with Kevin's patched SeaBIOS > > FIXED - when Philips drive is detected, it appears only once and once > only in the list of bootable

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-04 Thread Kevin O'Connor
On Fri, Dec 04, 2015 at 07:08:50PM +, edward wandasiewicz wrote: > On 4 Dec 2015 7:04 p.m., "Kevin O'Connor" wrote: > > > > On Fri, Dec 04, 2015 at 06:36:18PM +, edward wandasiewicz wrote: > > > @ John > > > > > > Is the wo

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-04 Thread Kevin O'Connor
On Fri, Dec 04, 2015 at 06:36:18PM +, edward wandasiewicz wrote: > @ John > > Is the work on SeaVGABIOS for CBFS work under construction for the > Broadwell based Pixel 2015? > > Looking at Kevin's chromeimage.sh - showing relevant parts only > > CBFSTOOL=cbfstool > PAYLOAD=out/bios.bin.elf

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-04 Thread Kevin O'Connor
On Fri, Dec 04, 2015 at 05:50:29PM +, edward wandasiewicz wrote: > Looking at the output from Googles ChromeOS shell-ball, I do: > > Write the hardware ID to get future ChromeOS updates > > $ ./gbb_utility --set --hwid="SAMUS XXX-YYY-ZZZ" bios.bin bios.hwid.bin > > # dd out 2 megs of the ROM

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-12-01 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 07:04:55PM +, edward wandasiewicz wrote: > On 30 Nov 2015 5:35 p.m., "Kevin O'Connor" wrote: > > Looks like two separate issues are occurring - the Philips drive is > > being detected as both a high speed device and as a super speed

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-11-30 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 04:47:29PM +, edward wandasiewicz wrote: > I started over, as I forgot which device was in which port. > > It seem's like a race condition, as I managed to get a USB device > detected twice with JohnLewis RW_LEGACY as well now, although it > doesn't happen very frequent

Re: [SeaBIOS] SeaBIOS recognising USB 3.0 on boot works - partly

2015-11-30 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 03:22:38PM +, edward wandasiewicz wrote: > Booting with 1 x Phillips USB and 1 x Ventura Ultra attached to the Pixel 2015 > > I've attached the cbmem -c from Pixel Samus, after a cold boot into > Arch Linux and also following a reboot immediately after. > > After a reb

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

2015-11-30 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 10:23:28AM -0500, Stefan Berger wrote: > "Kevin O'Connor" wrote on 11/30/2015 10:05:22 AM: > > Are the above definitions part of the standard, or internal to the > > implementation? If the latter, they should go into tcgbios.[ch] > > T

Re: [SeaBIOS] Qemu-kvm VM halt at allocate VGA stack when continuously reset VM

2015-11-30 Thread Kevin O'Connor
On Sat, Nov 28, 2015 at 07:12:47AM +, Xulei (Stone) wrote: > Hi, > Recently, i use a script to continuously reset a VM and > i found my VM frequently halts at "Attempting to allocate > VGA stack via pmm call". After analyzing, i think it may > be a problem of SeaBIOS. > > From the log(attach

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

2015-11-30 Thread Kevin O'Connor
On Sun, Nov 29, 2015 at 11:49:43PM -0500, Stefan Berger wrote: > From: Stefan Berger > > This patch adds an new menu entry to the main menu. This menu item enables > the user to enter a TPM control menu which allows control of those aspects > of the TPM's state that can only be controlled while i

Re: [SeaBIOS] [PATCH 3/3] tpm: Add a menu for TPM configuration

2015-11-30 Thread Kevin O'Connor
On Mon, Nov 30, 2015 at 06:02:45AM +0100, Peter Stuge wrote: > Stefan Berger wrote: > > +++ b/src/tcgbios.c > > +static u32 > > +read_stclear_flags(char *buf, int buf_len) > > +{ > .. > > +if (rc || returnCode) > > +goto err_exit; > .. > > +err_exit: > > +dprintf(DEBUG_tcg, "TCGBIOS

<    5   6   7   8   9   10   11   12   13   14   >