Before this change, you require default policy in neither export nor import to
be empty but do not care about the getMinimum() result. In this change, you
make sure the final result is not empty. I assume this is a fix?
283 // Did we find a default perms?
What does this line
Regression tests are still running, but thought that I will send the
updated webrev out and see if there are more comments.
Webrev is updated at:
http://cr.openjdk.java.net/~valeriep/8078661/webrev.01/
Thanks,
Valerie
On 8/17/2016 9:55 AM, Michael StJohns wrote:
On 8/16/2016 9:24 PM, Valeri
If I recall correctly, there should be a way to specify a policy file
in @run without overriding the default one. May be it is "@run
main/othervm/java.security.policy=unbound.ssl.policy_new"
Yes, I think this should work. I've also just learned about it and don't
know from which jtreg it is sup
Thanks for the input.
SunPKCS11 provider always generate RSA CRT keys if I recall correctly,
so it's hard to test the non-CRT scenarios. Thus, I made the changes
basing on the suggestions in the bug report.
I will update the webrev accordingly.
Valerie
On 8/17/2016 9:55 AM, Michael StJohns w
New webrev:
https://bugs.openjdk.java.net/browse/JDK-8061842
http://cr.openjdk.java.net/~wetmore/8061842/webrev.01/
On 8/10/2016 11:19 AM, Sean Mullan wrote:
Hi Brad,
Looks pretty good. You should also send this to build-dev to review the
Makefile changes. Just a few comments:
- src/java.base
Thanks
Tony
On 08/17/2016 01:47 PM, Sean Mullan wrote:
Looks fine to me.
--Sean
On 08/17/2016 04:11 PM, Anthony Scarpino wrote:
Hi,
I need a simple review on fixing some cut-n-paste errors that the JCK
tests found.
I didn't include the tests because the functionality is covered by the
JCK
Looks fine to me.
--Sean
On 08/17/2016 04:11 PM, Anthony Scarpino wrote:
Hi,
I need a simple review on fixing some cut-n-paste errors that the JCK
tests found.
I didn't include the tests because the functionality is covered by the
JCK tests and I don't feel typos need a regression test.
http
Hi,
I need a simple review on fixing some cut-n-paste errors that the JCK
tests found.
I didn't include the tests because the functionality is covered by the
JCK tests and I don't feel typos need a regression test.
http://cr.openjdk.java.net/~ascarpino/8156192/webrev/
Tony
On 8/17/16 11:36 AM, Chris Hegarty wrote:
On 17 Aug 2016, at 18:54, Rajan Halade wrote:
sun/net/www/protocol/https tests are redundant in jdk_security3 group, these
are included in jdk_net group.
Yes they are, but it is very important that anyone touching TLS verify
that HTTPS still works. I
Looks ok, probably better than the initial proposed fix from April 2014.
Brad
On 8/11/2016 4:55 AM, Vincent Ryan wrote:
Please review this change to unpin the Mac implementation from the
SunJCE provider.
Since the Mac is a private field there are no issues
regarding Clonable implementations
On 17 Aug 2016, at 18:54, Rajan Halade wrote:
>
> sun/net/www/protocol/https tests are redundant in jdk_security3 group, these
> are included in jdk_net group.
Yes they are, but it is very important that anyone touching TLS verify
that HTTPS still works. If the jdk_net tests will be run to veri
Hello,
Please review the following patch for
com/sun/crypto/provider/KeyFactory/TestProviderLeak.java test.
This is a request to make the test take into account a test timeout
factor. Timeout factor can be specified with "-timeout" jtreg's command
line option. This option is used in some tes
sun/net/www/protocol/https tests are redundant in jdk_security3 group,
these are included in jdk_net group.
Webrev: http://cr.openjdk.java.net/~rhalade/8164229/webrev.00/
Thanks,
Rajan
Sorry, my bad, I didn't notice '9-na' label.
I suppose that code from ext directory should have all permissions:
artem@artem-laptop:$ cat ~/jdk/jdk1.8.0_92b14/jre/lib/security/java.policy
// Standard extensions get all permissions by default
grant codeBase "file:${{java.ext.dirs}}/*" {
Hi Artem,
Sorry - should have said that this is for jdk8u-dev. The bug is marked
9-na. The provider loading changes made in this area for 9 mean that
it's not affected.
Regards,
Sean.
On 17/08/16 18:10, Artem Smotrakov wrote:
Hi Sean,
If I remember correctly, there is no ext directory in J
Hi Sean,
If I remember correctly, there is no ext directory in JDK 9 any more.
I don't see in jtr file that "java.ext.dirs" system property is passed
to the test. If I understand correctly, "file:${{java.ext.dirs}}/*"
becomes "file:/*" which seems to grand all permissions to all the code.
It
On 8/16/2016 9:24 PM, Valerie Peng wrote:
Anyone has time to review a straightforward fix? The current PKCS11
code assume that if public exponent is available for RSA Private Key,
then it's a RSA CRT key. However, not all vendor implementation works
this way. Changing to a tighter check and d
A recently added test case lacks sufficient permissions to read a conf
file when running with security manager.
bug report : https://bugs.openjdk.java.net/browse/JDK-8162916
proposed patch :
diff --git a/test/sun/security/krb5/auto/unbound.ssl.policy
b/test/sun/security/krb5/auto/unbound.ssl.
On 2016-08-17 18:43, Sean Mullan wrote:
On 8/17/2016 12:33 PM, Erik Joelsson wrote:
Hello Sean,
The change looks ok, but it could also be expressed like this to
avoid duplication:
ifneq ($(filter $(OPENJDK_TARGET_OS), windows solaris), )
DEF_POLICY_SRC_LIST +=
$(JDK_TOPDIR)/src/java.base
On 8/17/2016 12:33 PM, Erik Joelsson wrote:
Hello Sean,
The change looks ok, but it could also be expressed like this to avoid
duplication:
ifneq ($(filter $(OPENJDK_TARGET_OS), windows solaris), )
DEF_POLICY_SRC_LIST +=
$(JDK_TOPDIR)/src/java.base/$(OPENJDK_TARGET_OS)/lib/security/defaul
Thank you!
Fixed in place:
http://cr.openjdk.java.net/~shurailine/8163126/webrev.00/test/jdk/security/jarsigner/Spec.java.sdiff.html
Shura
> On Aug 16, 2016, at 6:48 PM, Wang Weijun wrote:
>
>
>> On Aug 17, 2016, at 9:26 AM, Alexandre (Shura) Iline
>> wrote:
>>
>> Before the suggested fix,
Hello Sean,
The change looks ok, but it could also be expressed like this to avoid
duplication:
ifneq ($(filter $(OPENJDK_TARGET_OS), windows solaris), )
DEF_POLICY_SRC_LIST +=
$(JDK_TOPDIR)/src/java.base/$(OPENJDK_TARGET_OS)/lib/security/default.policy
endif
/Erik
On 2016-08-17 18:18, S
Please review this simple fix to append the solaris default.policy file
to the overall default.policy file.
Bug: https://bugs.openjdk.java.net/browse/JDK-8164071
diff -r 551f7617b2c0 make/copy/Copy-java.base.gmk
--- a/make/copy/Copy-java.base.gmk Wed Aug 17 10:08:18 2016 +0800
+++ b/make/c
Your fix looks good to me.
Thanks.
> On 17 Aug 2016, at 02:24, Valerie Peng wrote:
>
>
> Anyone has time to review a straightforward fix? The current PKCS11 code
> assume that if public exponent is available for RSA Private Key, then it's a
> RSA CRT key. However, not all vendor implementatio
Hi Valerie!
On 17.08.2016 1:25, Valerie Peng wrote:
Hmm, interesting...
So, if the first call succeeded and you release the context and
re-try. Does the popup window show up for the second call?
Just curious.
I assume that CryptAcquireCertificatePrivateKey() only displays the UI
when nece
25 matches
Mail list logo
