Great, thanks for the review and feedback~
Valerie
On 9/24/2019 9:20 PM, Xuelei Fan wrote:
I looked at the latest webrev:
http://cr.openjdk.java.net/~valeriep/8229243/webrev.01/
Which is good to me.
Thanks,
Xuelei
On 9/19/2019 5:46 PM, Valerie Peng wrote:
I am not on the PKCS#11
Great, the update looks good.
Thanks,
Valerie
On 9/24/2019 5:49 PM, Hohensee, Paul wrote:
Thank you, Valerie. :)
The patch needs a test, however, so I added a slightly modified
version of Tianmin’s reproducer. New webrev at
http://cr.openjdk.java.net/~phh/8231387/webrev.01/
The test fails
I looked at the latest webrev:
http://cr.openjdk.java.net/~valeriep/8229243/webrev.01/
Which is good to me.
Thanks,
Xuelei
On 9/19/2019 5:46 PM, Valerie Peng wrote:
I am not on the PKCS#11 committee and not sure about the plan.
As for which one is right, I am more inclined to the "spec is
Thanks Erik.
在 2019年09月24日 23:19, Erik Joelsson 写道:
Sure, will do.
/Erik
Thank you, Valerie. :)
The patch needs a test, however, so I added a slightly modified version of
Tianmin’s reproducer. New webrev at
http://cr.openjdk.java.net/~phh/8231387/webrev.01/
The test fails without the fix.
From: Valerie Peng
Organization: Oracle Corporation
Date: Tuesday,
I am the security reviewer that you need. One should be enough. ;)
Valerie
On 9/24/2019 2:37 PM, Hohensee, Paul wrote:
Yes, I’ll sponsor. Though it looks ok to me, I’m not a security
expert, so do we need another security reviewer?
*From: *security-dev on behalf
of Valerie Peng
Yes, I’ll sponsor. Though it looks ok to me, I’m not a security expert, so do
we need another security reviewer?
From: security-dev on behalf of Valerie
Peng
Organization: Oracle Corporation
Date: Tuesday, September 24, 2019 at 2:17 PM
To: "security-dev@openjdk.java.net"
Subject: Re: RFR
Hi Matthias,
The output on line 324 may report inconsistent info - the provider in
use may not be NSS but yet you put NSS version with provider name?
Since you are updating the code here, how about re-org the code a bit
and first check for whether NSS provider is used then do the various
Changes look fine. I suppose Paul will help sponsoring the fix as he is
listed as the RE for 8231387?
Thanks,
Valerie
On 9/24/2019 12:36 PM, Shi, Tianmin wrote:
Hi
Can someone help reviewing this fix?
Bug: https://bugs.openjdk.java.net/browse/JDK-8231387
Webrev:
Hi
Can someone help reviewing this fix?
Bug: https://bugs.openjdk.java.net/browse/JDK-8231387
Webrev: http://cr.openjdk.java.net/~phh/8231387/webrev.00/
Thank you,
Tianmin Shi
Looks fine Joe.
regards,
Sean.
On 23/09/2019 17:15, Joe Darcy wrote:
Hello,
Another module, another review request as part of making serial
warnings more robust:
JDK-8231368: Suppress warnings on non-serializable non-transient
instance fields in java.security.jgss
Sure, will do.
/Erik
On 2019-09-23 20:57, Jia Huang wrote:
Hi Erik,
Thank you for your review and valuable comments.
Updated: http://cr.openjdk.java.net/~jiefu/8231351-huangjia/webrev.01/
- The reference to the pkcs11 README and the reviewers had been added.
Please note the user in the
Hi Matthias,
looks good to me.
One minor style nit: You could close the else case in line 335 with "}" and
then have just one throw e; after the whole if else block.
Best regards
Christoph
From: Baesken, Matthias
Sent: Dienstag, 24. September 2019 10:30
To: Langer, Christoph ;
Just a couple of minor comments:
1. For comments like this:
// Warning: Used by NativeCreds.c and nativeccache.c
I think not capitalizing "Used" would be better. Also, would "called by"
be more appropriate? Result:
// Warning: called by NativeCreds.c and nativeccache.c
2. Sometimes you end
Hi John Jiang,
I don't care which NSS you have skipped.
I am just curious about the root cause for the failure on Ubuntu.
It seems more reasonable to close JDK-8231338 as won't fix.
But you just closed it as can't reproduce.
Thanks.
Best regards,
Jie
On 2019/9/24 下午4:01, sha.ji...@oracle.com
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8231357.1/
I adjusted the imports and now output a warning .
Best regards, Matthias
From: Baesken, Matthias
Sent: Montag, 23. September 2019 16:07
To: Langer, Christoph ; security-dev@openjdk.java.net
Cc: Zeller, Arno
Subject: RE: RFR
Hi Jie,
IIRC, this test passed on your Ubuntu 18.04 with a new built NSS 3.35 libs.
So, I suspected your Linux or the system built-in NSS libs had something
wrong.
Now that this test passed with NSS 3.35 on others' Linux, including
mine, it may not make sense that this test is skipped for NSS
I can't understand why JDK-8231338 was closed as "Cannot Reproduce"
since it can always be reproduced on Ubuntu 18.04.2 LTS.
Reproduce on Ubuntu 18.04 is very simple:
-
make test TEST="jtreg:sun/security/pkcs11/Secmod/AddTrustedCert.java"
CONF=re
I may be a little bit hesitate to add such words, "highly recommended to
use the latest NSS version ...", in the general TOP doc. There are a
few issues that I wary about:
It is not always expected that all PKCS 11 test should be run on latest
NSS version. Otherwise, there might be
19 matches
Mail list logo
