Re: RFR: JDK-8255603: Memory/Performance regression after JDK-8210985

2020-10-30 Thread Andrew Haley
On Thu, 29 Oct 2020 15:11:09 GMT, Christoph Langer wrote: > It seems that there exists a memory/performance regression that was > introduced with JDK-8210985: Update the default SSL session cache size to > 20480. > > The idea to limit the maixmum SSL session cache size by itself is good. > Un

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v19]

2020-10-30 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v13]

2020-10-30 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this API

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v14]

2020-10-30 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this API

Re: RFR: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms [v3]

2020-10-30 Thread Sean Mullan
On Fri, 9 Oct 2020 01:33:38 GMT, Weijun Wang wrote: >> Default algorithms are bumped to be based on PBES2 with AES-256 and SHA-256. >> Please also review the CSR at >> https://bugs.openjdk.java.net/browse/JDK-8228481. > > Weijun Wang has updated the pull request incrementally with one additiona

Integrated: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms

2020-10-30 Thread Weijun Wang
On Thu, 1 Oct 2020 20:02:34 GMT, Weijun Wang wrote: > Default algorithms are bumped to be based on PBES2 with AES-256 and SHA-256. > Please also review the CSR at > https://bugs.openjdk.java.net/browse/JDK-8228481. This pull request has now been integrated. Changeset: f77a6585 Author:Weij

Re: RFR: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms [v4]

2020-10-30 Thread Weijun Wang
> Default algorithms are bumped to be based on PBES2 with AES-256 and SHA-256. > Please also review the CSR at > https://bugs.openjdk.java.net/browse/JDK-8228481. Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unre

Integrated: 8255536: Remove the directsign property and option

2020-10-30 Thread Weijun Wang
On Wed, 28 Oct 2020 20:56:31 GMT, Weijun Wang wrote: > I regret adding the `directsign` property/option to JarSigner/jarsigner. See > the bug for details. This pull request has now been integrated. Changeset: a7563207 Author:Weijun Wang URL: https://git.openjdk.java.net/jdk/commit/a

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-30 Thread Weijun Wang
On Thu, 29 Oct 2020 03:18:33 GMT, Weijun Wang wrote: >> Changes look good. Only minor comments. > > Just curious, can the Java files be generated during the build process? The constants in PKCS11Exception are duplicated in PKCS11Constants. 0x, vs public static final long CKR

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-30 Thread Valerie Peng
On Thu, 29 Oct 2020 02:06:06 GMT, Hai-May Chao wrote: >> Could someone please help review this PKCS#11 v3.0 header files update? >> >> Changes are straight-forward as below: >> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0 >> 2) Updated java side w/ the new constants definitions and name/err

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-30 Thread Valerie Peng
On Thu, 29 Oct 2020 02:07:39 GMT, Hai-May Chao wrote: >> Could someone please help review this PKCS#11 v3.0 header files update? >> >> Changes are straight-forward as below: >> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0 >> 2) Updated java side w/ the new constants definitions and name/err

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-30 Thread Valerie Peng
On Thu, 29 Oct 2020 02:16:15 GMT, Hai-May Chao wrote: >> Could someone please help review this PKCS#11 v3.0 header files update? >> >> Changes are straight-forward as below: >> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0 >> 2) Updated java side w/ the new constants definitions and name/err

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-30 Thread Valerie Peng
On Thu, 29 Oct 2020 03:18:33 GMT, Weijun Wang wrote: > > > Just curious, can the Java files be generated during the build process? Hmm, maybe, by the java files, do you just mean PKCS11Constants class or more? I am not familiar with how to generate Java files during the build process, can yo

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-30 Thread Valerie Peng
On Fri, 30 Oct 2020 14:43:20 GMT, Weijun Wang wrote: > > > The constants in PKCS11Exception are duplicated in PKCS11Constants. > > ``` > 0x, > ``` > > vs > > ``` > public static final long CKR_OK = 0xL; > ``` > > Is there any way to simplify it?

Re: RFR: 8255494: PKCS7 should use digest algorithm to verify the signature

2020-10-30 Thread Valerie Peng
On Thu, 29 Oct 2020 18:57:45 GMT, Hai-May Chao wrote: >> This is a regression made by >> [JDK-8242068](https://bugs.openjdk.java.net/browse/JDK-8242068). When the >> digest algorithm is not the same as the hash part of the signature >> algorithm, we used to combine the digest algorithm with th

Re: RFR: 8255494: PKCS7 should use digest algorithm to verify the signature [v2]

2020-10-30 Thread Valerie Peng
On Thu, 29 Oct 2020 18:37:06 GMT, Weijun Wang wrote: >> This is a regression made by >> [JDK-8242068](https://bugs.openjdk.java.net/browse/JDK-8242068). When the >> digest algorithm is not the same as the hash part of the signature >> algorithm, we used to combine the digest algorithm with the

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-30 Thread Hai-May Chao
On Fri, 30 Oct 2020 21:39:42 GMT, Valerie Peng wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java >> line 1095: >> >>> 1093: addMech(CKM_SP800_108_FEEDBACK_KDF, >>> "CKM_SP800_108_FEEDBACK_KDF"); >>> 1094: addMech(CKM_SP800_108_DOUBLE

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-30 Thread Hai-May Chao
On Fri, 30 Oct 2020 21:44:00 GMT, Valerie Peng wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java >> line 987: >> >>> 985: public static final long CKM_SP800_108_FEEDBACK_KDF = >>> 0x03adL; >>> 986: public static final long CKM_SP

Integrated: 8255494: PKCS7 should use digest algorithm to verify the signature

2020-10-30 Thread Weijun Wang
On Wed, 28 Oct 2020 21:01:44 GMT, Weijun Wang wrote: > This is a regression made by > [JDK-8242068](https://bugs.openjdk.java.net/browse/JDK-8242068). When the > digest algorithm is not the same as the hash part of the signature algorithm, > we used to combine the digest algorithm with the key

Re: RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

2020-10-30 Thread Weijun Wang
On Fri, 30 Oct 2020 21:55:10 GMT, Valerie Peng wrote: > > The constants in PKCS11Exception are duplicated in PKCS11Constants. > > ``` > > 0x, > > ``` > > > > > > vs > > ``` > > public static final long CKR_OK = 0xL; > > ``` > > > > > > Is there any