On Mon, 30 Aug 2021 18:28:41 GMT, Xue-Lei Andrew Fan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reorg src, new test case
>
> src/java.base/share/classes/sun/security/ssl/X5
On Mon, 30 Aug 2021 20:57:51 GMT, Xue-Lei Andrew Fan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> after feedback
>
> src/java.base/share/classes/sun/security/ssl/CertificateMessage
> This code change collects all key types and runs `chooseClientAlias` only
> once.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
rename one variable
-
Changes:
- all: https://git.openjdk.java.net/jdk/pul
> This code change collects all key types and runs `chooseClientAlias` only
> once.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
after feedback
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5257
On Fri, 27 Aug 2021 14:36:52 GMT, Weijun Wang wrote:
>> This code change collects all key types and runs `chooseClientAlias` only
>> once.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> re
On Mon, 30 Aug 2021 16:54:23 GMT, Xue-Lei Andrew Fan wrote:
>> No, I meant changing the type of the `certScheme` argument in
>>
>> static SignatureScheme getPreferableAlgorithm(
>> AlgorithmConstraints constraints,
>> List schemes,
>> SignatureScheme
On Mon, 30 Aug 2021 15:45:00 GMT, Xue-Lei Andrew Fan wrote:
>> Good suggestion.
>>
>> One more thing: `checkedKeyTypes` only looks at `ss.keyAlgorithm`. I know
>> the other checks (`SignatureScheme.getPreferableAlgorithm` and
>> `X509Authentication.valueOf`) also only look at
On Fri, 27 Aug 2021 22:00:47 GMT, Xue-Lei Andrew Fan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reorg src, new test case
>
> src/java.base/share/classes/sun/security/ssl/Certif
On Fri, 27 Aug 2021 19:47:30 GMT, Weijun Wang wrote:
> A one slot ccache is added to avoid multiple authentication from the same
> principal.
Back to draft as the fix has not take care of different callers.
-
PR: https://git.openjdk.java.net/jdk/pull/5286
A one slot ccache is added to avoid multiple authentication from the same
principal.
-
Commit messages:
- 6859027: Duplicate communications to KDC in
GSSManager.createCredential(usage)
Changes: https://git.openjdk.java.net/jdk/pull/5286/files
Webrev:
> This code change collects all key types and runs `chooseClientAlias` only
> once.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
reorg src, new test case
-
Changes:
- all: https://git.openjdk.java.net/jdk/pul
On Wed, 25 Aug 2021 19:00:06 GMT, Weijun Wang wrote:
> This code change collects all key types and runs `chooseClientAlias` only
> once.
New commit pushed. A lot of code reorg. Now
`X509PossessionGenerator::createPossession` is also calling the new static
methods.
-
PR:
On Fri, 27 Aug 2021 03:55:56 GMT, Xue-Lei Andrew Fan wrote:
>> This code change collects all key types and runs `chooseClientAlias` only
>> once.
>
> src/java.base/share/classes/sun/security/ssl/X509Authentications.java line 37:
>
>> 35: import javax.net.ssl.X509ExtendedKeyManager;
>> 36:
>>
This code change collects all key types and runs `chooseClientAlias` only once.
-
Commit messages:
- no more reflection in test
- 8262186: Callback semantics of the method
X509KeyManager.chooseClientAlias(...)
Changes: https://git.openjdk.java.net/jdk/pull/5257/files
Webrev:
On Tue, 24 Aug 2021 22:15:52 GMT, Weijun Wang wrote:
>> This code change adds new methods to `DerInputStream` to easily and safely
>> read optional fields in a ASN.1 DER-encoded value. It also adds several
>> wrapping methods to `DerValue` to avoid unnecessary memory copyin
ethods are applied to `OAEPParameters` to show out how they work. A
> new regression test is added to show that not only the new methods are simper
> but they are safer and more correct.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revis
On Tue, 24 Aug 2021 19:06:37 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> best practice for reading DEFAULT, switch expression, etc
>
> test/jdk/com/sun/crypt
On Tue, 24 Aug 2021 17:47:18 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> best practice for reading DEFAULT, switch expression, etc
>
> src/java.base/s
On Tue, 24 Aug 2021 17:03:41 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> best practice for reading DEFAULT, switch expression, etc
>
> src/java.base/s
On Tue, 24 Aug 2021 17:04:01 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> best practice for reading DEFAULT, switch expression, etc
>
> src/java.base/s
ethods are applied to `OAEPParameters` to show out how they work. A
> new regression test is added to show that not only the new methods are simper
> but they are safer and more correct.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last re
On Mon, 23 Aug 2021 15:48:10 GMT, Jamil Nimeh wrote:
>> This code change adds new methods to `DerInputStream` to easily and safely
>> read optional fields in a ASN.1 DER-encoded value. It also adds several
>> wrapping methods to `DerValue` to avoid unnecessary memory copying when
>> calling
This code change adds new methods to `DerInputStream` to easily and safely read
optional fields in a ASN.1 DER-encoded value. It also adds several wrapping
methods to `DerValue` to avoid unnecessary memory copying when calling by an
internal method.
The new methods are applied to
On Mon, 23 Aug 2021 03:22:18 GMT, Jaikiran Pai wrote:
> Would this then allow the security manager to be used? In other words, can
> the value of `java.security.manager` be changed dynamically at runtime or is
> it restricted to be set only at launch time (via command line arugment
>
On Fri, 20 Aug 2021 22:44:34 GMT, Weijun Wang wrote:
> This change modifies the default value of the `java.security.manager` system
> property from "allow" to "disallow". This means unless it's explicitly set to
> "allow", any call to `System.s
On Sun, 22 Aug 2021 02:53:44 GMT, Sergey Bylokhov wrote:
> This is the continuation of JDK-8233884, JDK-8271456, and JDK-8272120.
>
> In many places standard charsets are looked up via their names, for example:
> absolutePath.getBytes("UTF-8");
>
> This could be done more efficiently(up to x20
On Sat, 21 Aug 2021 16:59:39 GMT, Alan Bateman wrote:
>> This is the same as the existing words for "disallow".
>
> I think I agree with Lance that "Throws UOE" would be clearer in this table.
Suggestion accepted.
-
PR: https://git.openjdk.java.net/jdk/pull/5204
On Fri, 20 Aug 2021 23:01:27 GMT, Lance Andersen wrote:
>> This change modifies the default value of the `java.security.manager` system
>> property from "allow" to "disallow". This means unless it's explicitly set
>> to "allow", any call to `System.setSecurityManager()` would throw an UOE.
>>
This change modifies the default value of the `java.security.manager` system
property from "allow" to "disallow". This means unless it's explicitly set to
"allow", any call to `System.setSecurityManager()` would throw an UOE.
The `AllowSecurityManager.java` and `SecurityManagerWarnings.java`
On Wed, 18 Aug 2021 22:33:42 GMT, Weijun Wang wrote:
> The "Key for the principal foo...@acme.com not available in
> /home/foobar/foobar.keytab" debug output does not contain enough information.
> The keytab file might be missing, or not readable, or does not contain th
The "Key for the principal foo...@acme.com not available in
/home/foobar/foobar.keytab" debug output does not contain enough information.
The keytab file might be missing, or not readable, or does not contain the
required key(s).
Please note that this debug info is only visible when
On Tue, 17 Aug 2021 15:58:49 GMT, Abdul Kolarkunnu
wrote:
> MultipleLogins.sh compiles all files under lib/jdk/test/lib/artifacts, Since
> JDK-8266182 added a new file OpensslArtifactFetcher.java in to same package
> and it has dependency with some other library files
>
On Tue, 17 Aug 2021 11:33:07 GMT, Abdul Kolarkunnu
wrote:
>> ParamsTest is an interop test between keytool <-> openssl. There are some
>> manual steps listed in jdk/sun/security/pkcs12/params/README to perform
>> after the execution of jtreg execution. So this test is to perform that
>>
On Fri, 13 Aug 2021 09:47:53 GMT, Abdul Kolarkunnu
wrote:
>> ParamsTest is an interop test between keytool <-> openssl. There are some
>> manual steps listed in jdk/sun/security/pkcs12/params/README to perform
>> after the execution of jtreg execution. So this test is to perform that
>>
On Tue, 10 Aug 2021 14:48:08 GMT, Martin Balao wrote:
>> Not adding the type is OK, I said it's just to be a little clearer. I think
>> you're right about the cname. It's always the one that actually sends the
>> request.
>>
>> What is "the TGS" (in "the TGS is the one")?
On Tue, 10 Aug 2021 13:45:22 GMT, Martin Balao wrote:
>> src/java.security.jgss/share/classes/sun/security/krb5/internal/ReferralsCache.java
>> line 59:
>>
>>> 57: private byte[] clientSvcTicketEnc; // S4U2Proxy only
>>> 58: ReferralCacheKey (PrincipalName cname, PrincipalName
On Fri, 6 Aug 2021 19:27:30 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8270137 [1].
>
> This bug is triggered when using a previously stored referral ticket (in the
> Referrals Cache) at the moment of following a S4U2Proxy cross-realm referral.
> The mistakenly-used referral
On Mon, 9 Aug 2021 11:06:25 GMT, Abdul Kolarkunnu
wrote:
>> ParamsTest is an interop test between keytool <-> openssl. There are some
>> manual steps listed in jdk/sun/security/pkcs12/params/README to perform
>> after the execution of jtreg execution. So this test is to perform that
>>
On Thu, 15 Jul 2021 22:38:24 GMT, Weijun Wang wrote:
> Add code to call XML signing using internal APIs. The implementation was also
> fixed back in JDK-8259535 but not covered by the new test there.
This pull request has now been integrated.
Changeset: 221e4b9c
Author:Weijun Wan
On Thu, 29 Jul 2021 14:24:52 GMT, Sean Mullan wrote:
> Please review this fix to remove the Validator.VAR_PLUGIN_CODE_SIGNING
> variant and related code that is no longer needed in the PKIX implementation.
Looks good. One nit: `Validator::getInstance` methods are internal. Does it
really
On Mon, 26 Jul 2021 17:03:11 GMT, Sean Mullan wrote:
>> Please review this fix to change the internal `X509CertImpl.getFingerprint`
>> method to not return "" as a fingerprint if there is an error generating
>> that fingerprint. Instead, `null` is now returned, and "" is no longer
>> cached
On Mon, 26 Jul 2021 13:37:39 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/security/x509/X509CertImpl.java line 1924:
>>
>>> 1922: x -> getFingerprintInternal(x, debug));
>>> 1923: }
>>> 1924:
>>
>> I'm a little confused by these methods. Can you inline
>>
On Fri, 23 Jul 2021 17:16:26 GMT, Sean Mullan wrote:
> Please review this fix to change the internal `X509CertImpl.getFingerprint`
> method to not return "" as a fingerprint if there is an error generating that
> fingerprint. Instead, `null` is now returned, and "" is no longer cached as a
>
On Tue, 6 Jul 2021 23:06:39 GMT, Anthony Scarpino wrote:
>> Hi,
>>
>> I need a review of these new jmh tests that run AES/GCM encryption and
>> decryption using byte[], heap bytebuffers, and direct bytebuffers as input
>> and output buffers for single and multi-part testing.
>>
>> thanks
>>
On Fri, 2 Jul 2021 23:30:17 GMT, Anthony Scarpino wrote:
>> Hi,
>>
>> I need a review of these new jmh tests that run AES/GCM encryption and
>> decryption using byte[], heap bytebuffers, and direct bytebuffers as input
>> and output buffers for single and multi-part testing.
>>
>> thanks
>>
On Mon, 28 Jun 2021 21:09:43 GMT, Weijun Wang wrote:
> Add a cache to record which sources have called `System::setSecurityManager`
> and only print out warning lines once for each.
This pull request has now been integrated.
Changeset: c4ea13ed
Author:Weijun Wang
URL:
> Add a cache to record which sources have called `System::setSecurityManager`
> and only print out warning lines once for each.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
update cache key from String to
On Wed, 30 Jun 2021 06:32:04 GMT, Alan Bateman wrote:
>> I hope this is uncommon but if that class is loaded by a `ClassLoader` again
>> and again then it will be different each time. I'll investigate more.
>
> WeakHashMap, Boolean>, where the key is the caller, should be okay
> (assume
On Tue, 29 Jun 2021 19:57:24 GMT, Roger Riggs wrote:
>> If I switch to a "non-weak" set or map, then it seems I can safely use the
>> source string as the key. Will using the Class object as a key prevent them
>> from unloading?
>
> Using a synchronized WeakHashMap with the class as the key
On Tue, 29 Jun 2021 19:23:26 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/lang/System.java line 337:
>>
>>> 335: = Collections.synchronizedMap(new WeakHashMap<>());
>>> 336: }
>>> 337:
>>
>> I wonder about the use of a WeakHashMap here. That may work well when
On Mon, 28 Jun 2021 18:03:56 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
>
> Note: this is copied from https://github.com/
More refactoring to limit the scope of `@SuppressWarnings` annotations.
Sometimes I introduce new methods. Please feel free to suggest method names you
like to use.
Note: this is copied from https://github.com/openjdk/jdk17/pull/152.
-
Commit messages:
- copy all code change from
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
This pull request has been closed without bein
On Mon, 28 Jun 2021 12:20:38 GMT, Daniel Fuchs wrote:
>> This cast is only to tell the compiler which overloaded method to call, and
>> I don't think there will be a real cast at runtime. It might look a little
>> ugly but extracting it into a variable declaration/definition plus a new
>>
On Fri, 25 Jun 2021 23:40:27 GMT, Weijun Wang wrote:
>> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>>
>> Sometimes I introduce new methods. Please feel free to suggest method names
>> you like to use.
>
> Weijun Wang has updated
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
On Sat, 26 Jun 2021 16:53:30 GMT, Alan Bateman wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> one more
>
> src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java lin
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
More refactoring to limit the scope of `@SuppressWarnings` annotations.
Sometimes I introduce new methods. Please feel free to suggest method names you
like to use.
-
Commit messages:
- 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
Changes:
On Fri, 11 Jun 2021 01:59:59 GMT, Weijun Wang wrote:
> More loudly and precise warning messages when a security manager is either
> enabled at startup or installed at runtime.
>
> This is new PR for the `openjdk/jdk17` repo copied from
> https://github.com/openjdk/jdk/pull/440
On Mon, 21 Jun 2021 22:43:58 GMT, Weijun Wang wrote:
> This is a copy of https://github.com/openjdk/jdk17/pull/100 so that I can
> integrate the fix for @seanjmullan.
This pull request has now been integrated.
Changeset: e2d7ec38
Author:Weijun Wang
URL:
This is a copy of https://github.com/openjdk/jdk17/pull/100 so that I can
integrate the fix for @seanjmullan.
-
Commit messages:
- [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs.
Changes: https://git.openjdk.java.net/jdk17/pull/113/files
Webrev:
On Fri, 18 Jun 2021 02:30:22 GMT, Jaikiran Pai wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> verbose warning message test and renaming in System.java
>
> src/java.base/share/classes/
> More loudly and precise warning messages when a security manager is either
> enabled at startup or installed at runtime.
>
> This is new PR for the `openjdk/jdk17` repo copied from
> https://github.com/openjdk/jdk/pull/4400. A new commit is added.
Weijun Wang has updated t
On Thu, 17 Jun 2021 14:55:02 GMT, Weijun Wang wrote:
>> More loudly and precise warning messages when a security manager is either
>> enabled at startup or installed at runtime.
>>
>> This is new PR for the `openjdk/jdk17` repo copied from
>> https://github.co
> More loudly and precise warning messages when a security manager is either
> enabled at startup or installed at runtime.
>
> This is new PR for the `openjdk/jdk17` repo copied from
> https://github.com/openjdk/jdk/pull/4400. A new commit is added.
Weijun Wang has updated t
On Thu, 17 Jun 2021 16:27:41 GMT, Alan Bateman wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add bug id into a test
>
> src/java.base/share/classes/java/lang/System.jav
> More loudly and precise warning messages when a security manager is either
> enabled at startup or installed at runtime.
>
> This is new PR for the `openjdk/jdk17` repo copied from
> https://github.com/openjdk/jdk/pull/4400. A new commit is added.
Weijun Wang has updated t
On Thu, 17 Jun 2021 14:05:40 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> new warning text again (6/14)
>
> test/jdk/java/security/ProtectionDomain/Recursi
On Thu, 17 Jun 2021 14:02:35 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> new warning text again (6/14)
>
> test/jdk/java/lang/System/SecurityManagerWarnings.
> More loudly and precise warning messages when a security manager is either
> enabled at startup or installed at runtime.
>
> This is new PR for the `openjdk/jdk17` repo copied from
> https://github.com/openjdk/jdk/pull/4400. A new commit is added.
Weijun Wang has updated t
> More loudly and precise warning messages when a security manager is either
> enabled at startup or installed at runtime.
>
> This is new PR for the `openjdk/jdk17` repo copied from
> https://github.com/openjdk/jdk/pull/4400. A new commit is added.
Weijun Wang has updated t
On Fri, 11 Jun 2021 01:46:46 GMT, Weijun Wang wrote:
> The test must run with sudo but I forgot to mention it. New comment and a
> better error message is added.
This pull request has now been integrated.
Changeset: e39346e7
Author:Weijun Wang
URL:
https://git.openjdk.ja
More loudly and precise warning messages when a security manager is either
enabled at startup or installed at runtime.
This is new PR for the `openjdk/jdk17` repo copied from
https://github.com/openjdk/jdk/pull/4400. A new commit is added.
-
Commit messages:
- no cache, new
On Mon, 7 Jun 2021 20:42:53 GMT, Weijun Wang wrote:
> More loudly and precise warning messages when a security manager is either
> enabled at startup or installed at runtime.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jd
The test must run with sudo but I forgot to mention it. New comment and a
better error message is added.
-
Commit messages:
- 8268093: Manual Testcase:
"sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
Changes: https://git.openjdk.java.net/jdk17/pull/12/files
On Mon, 7 Jun 2021 20:57:52 GMT, Weijun Wang wrote:
> The test must run with sudo but I forgot to mention it. New comment and a
> better error message is added.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/4401
On Thu, 10 Jun 2021 17:10:22 GMT, Weijun Wang wrote:
> Remove newly leaked memory.
This pull request has now been integrated.
Changeset: 7b2e7d8b
Author: Weijun Wang
URL:
https://git.openjdk.java.net/jdk17/commit/7b2e7d8bab890bd655093976cc9c3b0b6d00c034
Stats: 158 lines i
> Remove newly leaked memory.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
clean up one class
-
Changes:
- all: https://git.openjdk.java.net/jdk17/pull/3/files
- new: https://git.openjdk.java.net/jdk17/pul
Remove newly leaked memory.
-
Commit messages:
- 8268525: Some new memory leak after JDK-8248268 and JDK-827
Changes: https://git.openjdk.java.net/jdk17/pull/3/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=3=00
Issue:
On Thu, 10 Jun 2021 15:40:56 GMT, Weijun Wang wrote:
> Remove newly leaked memory.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/4466
Remove newly leaked memory.
-
Commit messages:
- 8268525: Some new memory leak after JDK-8248268 and JDK-827
Changes: https://git.openjdk.java.net/jdk/pull/4466/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4466=00
Issue:
On Tue, 8 Jun 2021 17:15:29 GMT, Alan Bateman wrote:
>> I thought about that but not sure of performance impact. Is the worst
>> problem that more than one warnings will be printed for a single caller?
>> It's not really harmless.
>>
>> As for the frame, if the warning message only contain
On Tue, 8 Jun 2021 06:11:17 GMT, Alan Bateman wrote:
>> More loudly and precise warning messages when a security manager is either
>> enabled at startup or installed at runtime.
>
> src/java.base/share/classes/java/lang/System.java line 331:
>
>> 329:
>> 330: // Remember original
On Tue, 8 Jun 2021 06:41:11 GMT, Alan Bateman wrote:
> > You might want to make your "WARNING" consistent with the VM's "Warning" so
> > that OutputAnalyzer's logic to ignore warnings will automatically ignore
> > these too.
>
> The uppercase "WARNING" is intentional here, it was the same
The test must run with sudo but I forgot to mention it. New comment and a
better error message is added.
-
Commit messages:
- 8268093: Manual Testcase:
"sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
Changes: https://git.openjdk.java.net/jdk/pull/4401/files
On Thu, 27 May 2021 08:52:20 GMT, Sibabrata Sahoo wrote:
> This change converts JTREG shell Test scripts to Java equivalent.
Marked as reviewed by weijun (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4220
On Thu, 3 Jun 2021 21:50:32 GMT, Bradford Wetmore wrote:
>> The latter is probably better so you don't have to move the code; @wangweij
>> used this technique quite a bit for JEP 411 refactoring, see
>> https://github.com/openjdk/jdk/commit/508cec7535cd0ad015d566389bc9e5f53ce4103b
>
>
On Thu, 3 Jun 2021 11:10:10 GMT, Sean Coffey wrote:
> MultipleLogins.java should skip test where NSS support is not present
Marked as reviewed by weijun (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4333
On Mon, 24 May 2021 20:23:27 GMT, Weijun Wang wrote:
> For all modified files in #4073 having "security", "crypto", or "ssl" in
> their names. Codes are refactored to bring a `@SuppressWarning` annotation
> nearer to the deprecated API usage and also s
On Fri, 21 May 2021 01:52:27 GMT, Weijun Wang wrote:
> The code change refactors classes that have a `SuppressWarnings("removal")`
> annotation that covers more than 50KB of code. The big annotation is often
> quite faraway from the actual deprecated API usag
pyright year update commit before integration.
Weijun Wang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains one commit:
8267543: Post JEP 411 refactoring: security
-
Changes: https://git.openjdk.java.net/jdk/pull/4172/fi
into a single statement if possible.
> 4. Rewrite code to achieve #3 above.
>
> I'll add a copyright year update commit before integration.
Weijun Wang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains one commit:
8267521: Post JEP
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.c
ions and javadoc tags, build, compiler,
> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are
> reviewed. Rest are 2d, awt, beans, sound, and swing.
Weijun Wang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now conta
ions and javadoc tags, build, compiler,
> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are
> reviewed. Rest are 2d, awt, beans, sound, and swing.
Weijun Wang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contain
ions and javadoc tags, build, compiler,
> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are
> reviewed. Rest are 2d, awt, beans, sound, and swing.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
rename
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>
ions and javadoc tags, build, compiler,
> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are
> reviewed. Rest are 2d, awt, beans, sound, and swing.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 28 May 2021 03:12:35 GMT, Phil Race wrote:
>> There *is* a tiny refactoring here: a new variable `s2` is introduced so the
>> 2nd `doPrivileged` call on line 636 is now also in a declaration statement
>> (for `s2`) and therefore annotatable. Without this I cannot add the
>> annotation
501 - 600 of 2902 matches
Mail list logo
