Hi Max,
Sorry for the formatting issue, I have removed all TAB characters and
ran jcheck on the changeset below, could you please sponsor it?
http://cr.openjdk.java.net/~amjiang/8048357/webrev.06/
Thanks,
Amanda
On 15/11/19 下午4:32, Wang Weijun wrote:
Looks fine, but there are TAB characters
Looks fine, but there are TAB characters. Have you run jcheck?
remote: test/sun/security/pkcs/pkcs10/PKCS10AttrEncoding.java:29: Tab character
remote: test/sun/security/pkcs/pkcs10/PKCS10AttributeReader.java:52: Tab
character
remote: test/sun/security/pkcs/pkcs7/PKCS7VerifyTest.java:48: Tab chara
Done at http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c071ebc7f3bf
Thanks
Max
> On Nov 20, 2015, at 11:00 AM, Amanda Jiang wrote:
>
> Hi Max,
>
> Sorry for the formatting issue, I have removed all TAB characters and ran
> jcheck on the changeset below, could you please sponsor it?
> http://cr.o
Hi Max,
Please check the webrev below which includes fixes for you previous
comments:
http://cr.openjdk.java.net/~amjiang/8048357/webrev.05/
Thanks,
Amanda
On 15/11/16 下午11:55, Weijun Wang wrote:
Hi Amanda
On 11/17/2015 15:03, Amanda Jiang wrote:
http://cr.openjdk.java.net/~amjiang/8048357
Hi Amanda
On 11/17/2015 15:03, Amanda Jiang wrote:
http://cr.openjdk.java.net/~amjiang/8048357/webrev.03/
Why "othervm" for all these tests?
The pkcs10 and pkcs8 tests still uses othervm. Is that necessary? I see
no VM static change made by these tests.
PKCS8Test.java:
- sun.security.x5
Hi Max,
Thanks for reviewing the webrev, below is another updated webrev which
contains fixes for all your comments, please let me know if you have any
other suggestions.
http://cr.openjdk.java.net/~amjiang/8048357/webrev.03/
Thanks,
Amanda
On 15/11/15 下午11:41, Wang Weijun wrote:
Why "other
Why "othervm" for all these tests?
PKCS10AttrOrder.java:
- Is sun.security.provider and sun.misc used anywhere? You have them in
@modules.
- sun.security.pkcs.PKCS9Attribute contains public constants like
CONTENT_TYPE_OID, SIGNING_TIME_OID, CHALLENGE_PASSWORD_OID. You can directly
use them. S
Hi Max,
Please check the updated webrev which address your comments, please let
me know if you have any other suggestions.
http://cr.openjdk.java.net/~amjiang/8048357/webrev.02/
Thanks,
Amanda
On 15/8/21 上午12:13, Weijun Wang wrote:
PKCS10AttrOrder.java:
- Why not inline revAttributes(), pro
PKCS10AttrOrder.java:
- Why not inline revAttributes(), prov() and constructMap()? They are
only used once. Putting the content into the main method is more clear.
- You can create separate method for the while look checks. The 2 look
identical.
PKCS10AttributeReader.java:
- Is it OK to in
Hello Amanda,
out of curiosity I was looking at the tests, and have a few comments:
PKCS7VerifyTest.java
63byte[] base64Bytes = new byte[pkcs7In.available()];
64 if (pkcs7In.read(base64Bytes) < base64Bytes.length) {
There are two pet peeves of mine. available() to get the
Hi All,
Please be free to review new tests for conformance testing of PKCS.
bug: https://bugs.openjdk.java.net/browse/JDK-8048357
webrev: http://cr.openjdk.java.net/~amjiang/8048357/webrev.01/
Thanks,
Amanda
11 matches
Mail list logo
