Re: RFR: 8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass [v3]

2025-09-25 Thread Mikhail Yankelevich
On Thu, 25 Sep 2025 14:49:57 GMT, Sean Mullan wrote: >> test/jdk/sun/security/pkcs11/Secmod/AddPrivateKey.java line 65: >> >>> 63: >>> 64: public static void main(String[] args) throws Exception { >>> 65: initSecmod(); >> >> Does `initSecmod` ever return false? Should we change the

Re: RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip [v3]

2025-09-24 Thread Mikhail Yankelevich
security/pkcs11/Signature/SignatureTestPSS.java > * test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS2.java > * test/jdk/sun/security/pkcs11/Signature/TestDSA.java Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: na

Integrated: 8360979: Remove use of Thread.stop in krb5/auto/KDC.java

2025-09-24 Thread Mikhail Yankelevich
On Thu, 10 Jul 2025 16:03:54 GMT, Mikhail Yankelevich wrote: > Replaced Thread::stop to Thread::interrupt This pull request has now been integrated. Changeset: 2a232d02 Author: Mikhail Yankelevich URL: https://git.openjdk.org/jdk/commit/2a232d0210015606da7207edab793760fdb61

Re: RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip [v2]

2025-09-24 Thread Mikhail Yankelevich
On Wed, 24 Sep 2025 12:50:10 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> renamed id > > test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS.

Re: RFR: 8368226: Remove Thread.stop [v3]

2025-09-24 Thread Mikhail Yankelevich
On Wed, 24 Sep 2025 10:37:05 GMT, Alan Bateman wrote: >> test/jdk/sun/security/krb5/auto/KDC.java line 1651: >> >>> 1649: thread1.interrupt(); >>> 1650: thread2.interrupt(); >>> 1651: thread3.interrupt(); >> >> I don't think this will work in this

Re: RFR: 8360979: Remove use of Thread.stop in krb5/auto/KDC.java [v2]

2025-09-24 Thread Mikhail Yankelevich
On Wed, 24 Sep 2025 13:00:56 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> breaking the loop when interrupt flag is set > > The fix looks fine. I might be o

Re: RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip

2025-09-24 Thread Mikhail Yankelevich
On Mon, 22 Sep 2025 15:56:11 GMT, Weijun Wang wrote: > Honestly, I don't quite understand why there are 2 tests initializing > `skipTest` as true and then assign it false. Usually it's the other way > round. If you know why it has to be coded this way, please add some comments > there. Thanks.

Re: RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip [v2]

2025-09-23 Thread Mikhail Yankelevich
On Tue, 23 Sep 2025 15:11:53 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> renamed id > > test/jdk/sun/security/pkcs11/Signature/KeyAndParamChec

Re: RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip

2025-09-23 Thread Mikhail Yankelevich
On Fri, 19 Sep 2025 05:46:35 GMT, SendaoYan wrote: >> * test/jdk/sun/security/pkcs11/Signature/InitAgainPSS.java >> * test/jdk/sun/security/pkcs11/Signature/KeyAndParamCheckForPSS.java >> * test/jdk/sun/security/pkcs11/Signature/SigInteropPSS.java >> * test/jdk/sun/security/pkcs11/Signature/SigIn

Re: RFR: 8343395: SSLLogger doesn't work for formatted messages [v2]

2025-09-22 Thread Mikhail Yankelevich
On Mon, 22 Sep 2025 10:06:15 GMT, Sean Coffey wrote: >> src/java.base/share/classes/sun/security/ssl/Utilities.java line 154: >> >>> 152: StringBuilder builder = new StringBuilder(); >>> 153: if (source == null) { >>> 154: builder.append(LINE_SEP).append(prefix).appe

Re: RFR: 8368226: Remove Thread.stop

2025-09-22 Thread Mikhail Yankelevich
On Mon, 22 Sep 2025 08:13:55 GMT, Alan Bateman wrote: > The no-arg Thread.stop has been deprecated since JDK 1.2, deprecated for > removal since JDK 18, and re-specified to throw UOE unconditionally since JDK > 20. It is time to finally remove the method. Its more evil sibling > Thread.stop(Th

Re: RFR: 8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass [v2]

2025-09-18 Thread Mikhail Yankelevich
sa/KeyWrap.java > * test/jdk/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: Matthew's comments - Changes: - all: https://git.openjdk.org/jdk/pull/271

RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip

2025-09-18 Thread Mikhail Yankelevich
* test/jdk/sun/security/pkcs11/Signature/InitAgainPSS.java * test/jdk/sun/security/pkcs11/Signature/KeyAndParamCheckForPSS.java * test/jdk/sun/security/pkcs11/Signature/SigInteropPSS.java * test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java * test/jdk/sun/security/pkcs11/Signature/Signature

Re: RFR: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom [v4]

2025-09-17 Thread Mikhail Yankelevich
asic.java > * test/jdk/sun/security/pkcs11/SecureRandom/TestDeserialization.java Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: added print stack trace for the system out - Changes: - all: https://git.openj

Re: RFR: 8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass [v2]

2025-09-17 Thread Mikhail Yankelevich
On Tue, 9 Sep 2025 11:19:06 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Matthew's comments > > test/jdk/sun/security/pkcs11/Config/ReadCo

Re: RFR: 8367344: Better error message when decryption of AP-REQ fails because of kvno mismatch

2025-09-16 Thread Mikhail Yankelevich
On Mon, 15 Sep 2025 15:49:11 GMT, Weijun Wang wrote: > For interoperability, AP-REQ decryption uses the key with the highest kvno in > the keytab if no exact match is found. If decryption fails, a normal > "checksum failed" error is reported, which may hide the real cause that the > wrong key

Integrated: 8366342: Key generator and key pair generator tests skipping, but showing as passed

2025-09-11 Thread Mikhail Yankelevich
On Thu, 28 Aug 2025 11:25:54 GMT, Mikhail Yankelevich wrote: > * Minor cleanup > * Key generator and key pair generator tests skipping, but showing as passed: >* test/jdk/sun/security/pkcs11/KeyGenerator/DESParity.java >* test/jdk/sun/security/pkcs11/KeyGenerator/

Re: RFR: 8365072: Refactor tests to use PEM API (Phase 2) [v2]

2025-09-11 Thread Mikhail Yankelevich
rustAnchor.java > 19. test/jdk/sun/security/x509/X509CRLImpl/Verify.java > > PEMRecord tests will be done under a subtask > [JDK-8367326](https://bugs.openjdk.org/browse/JDK-8367326) Mikhail Yankelevich has updated the pull request incrementally with one additional commit since t

RFR: 8365072: Refactor tests to use PEM API (Phase 2)

2025-09-10 Thread Mikhail Yankelevich
Tests changed in this PR: 1. test/jdk/java/security/cert/CertPathBuilder/selfIssued/StatusLoopDependency.java 2. test/jdk/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevel.java 3. test/jdk/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevelRevoked.java 6. tes

Re: RFR: 8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass [v3]

2025-09-10 Thread Mikhail Yankelevich
sa/KeyWrap.java > * test/jdk/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: Delete accidental file - Changes: - all: https://git.openjdk.org/jdk/pull/27

RFR: 8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass

2025-09-09 Thread Mikhail Yankelevich
Tests changed: * test/jdk/sun/security/pkcs11/Config/ReadConfInUTF16Env.java * test/jdk/sun/security/pkcs11/PKCS11Test.java * test/jdk/sun/security/pkcs11/Secmod/AddPrivateKey.java * test/jdk/sun/security/pkcs11/Secmod/AddTrustedCert.java * test/jdk/sun/security/pkcs11/Secmod/Crypto.java * test/j

Integrated: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom

2025-09-08 Thread Mikhail Yankelevich
On Tue, 26 Aug 2025 11:49:33 GMT, Mikhail Yankelevich wrote: > Skipped tests are treated as a pass: > > * test/jdk/sun/security/pkcs11/KeyStore/ClientAuth.java > * test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java > * test/jdk/sun/security/pkcs11/SecretKeyFactory/T

Re: RFR: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom [v3]

2025-09-08 Thread Mikhail Yankelevich
On Sat, 6 Sep 2025 15:46:54 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> waiting for all tests to run before skipping > > test/jdk/sun/security/pkcs11/Sec

Re: RFR: 8366182: Some PKCS11Tests are being skipped when they shouldn't [v2]

2025-09-06 Thread Mikhail Yankelevich
On Fri, 5 Sep 2025 13:43:04 GMT, Matthew Donovan wrote: >> Ah, you're right, I didn't think of this case! This approach will be easier >> then, I agree. >> >> Still, `ver.substring(idx+1)` may cause errors in cases like this [NSS >> 3.15.3.1 release >> notes](https://nss-crypto.org/reference

Re: RFR: 8366817: test/jdk/javax/net/ssl/TLSCommon/interop/JdkProcServer.java and JdkProcClient.java should not delete logs

2025-09-05 Thread Mikhail Yankelevich
On Wed, 3 Sep 2025 17:02:11 GMT, Fernando Guallini wrote: > The following test helpers delete logs after the test completes: > jdk/javax/net/ssl/TLSCommon/interop/JdkProcServer.java > jdk/javax/net/ssl/TLSCommon/interop/JdkProcClient.java > > These helpers are used by tests located in > jdk/ja

Re: RFR: 8366182: Some PKCS11Tests are being skipped when they shouldn't

2025-09-05 Thread Mikhail Yankelevich
On Thu, 4 Sep 2025 16:54:48 GMT, Matthew Donovan wrote: >> test/jdk/sun/security/pkcs11/Cipher/TestKATForGCM.java line 330: >> >>> 328: String osName = System.getProperty("os.name"); >>> 329: int idx = ver.indexOf("."); >>> 330: double major = Doub

Re: RFR: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom [v3]

2025-09-04 Thread Mikhail Yankelevich
asic.java > * test/jdk/sun/security/pkcs11/SecureRandom/TestDeserialization.java Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: waiting for all tests to run before skipping - Changes: - all: https://git.openj

Re: RFR: 8366182: Some PKCS11Tests are being skipped when they shouldn't

2025-09-04 Thread Mikhail Yankelevich
On Thu, 4 Sep 2025 13:59:22 GMT, Matthew Donovan wrote: > This PR updates PKCS11 tests to better handle NSS version numbers. The > previous code treated the version numbers as double values and used > comparison operators. The problem is that it incorrectly treats 3.111 as > between 3.11 and 3

Re: RFR: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom [v2]

2025-09-04 Thread Mikhail Yankelevich
On Thu, 4 Sep 2025 14:09:54 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8366159: SkippedException is treated as a pass for pkcs11/KeyStore, >> pkcs

Re: RFR: 8357466: Create test for Ciphers that are using ByteBuffers backed by MemorySegments

2025-09-03 Thread Mikhail Yankelevich
On Thu, 28 Aug 2025 11:41:59 GMT, Matthew Donovan wrote: >> test/jdk/javax/crypto/CipherSpi/CipherByteBufferOverwriteTest.java line 127: >> >>> 125: System.out.println("All Tests Passed"); >>> 126: } finally { >>> 127: arena.close(); >> >> Would it make sense to

Re: RFR: 8357466: Create test for Ciphers that are using ByteBuffers backed by MemorySegments

2025-09-01 Thread Mikhail Yankelevich
On Wed, 27 Aug 2025 18:09:55 GMT, Matthew Donovan wrote: > This PR extends security tests to use ByteBuffers backed by MemorySegments. > Tests in the areas of Signature, Cipher, MessageDigest, and Mac are updated. Looks good, just one comment and a few nitpicks. IMO nits are not worth doing un

Re: RFR: 8366342: Key generator and key pair generator tests skipping, but showing as passed

2025-08-29 Thread Mikhail Yankelevich
On Thu, 28 Aug 2025 16:42:41 GMT, Weijun Wang wrote: > Looks good. Why are these included in the previous PR? Grouping tests by folder as detecting them - PR Comment: https://git.openjdk.org/jdk/pull/26985#issuecomment-3236660607

Re: RFR: 8366211: Block signature scheme names to be used with CertificateSignature algorithm constraints usage

2025-08-28 Thread Mikhail Yankelevich
On Thu, 28 Aug 2025 14:39:17 GMT, Artur Barashev wrote: >> test/jdk/sun/security/ssl/SignatureScheme/BlockSignatureSchemesForCert.java >> line 46: >> >>> 44: "rsa_pss_pss_sha256 usage CertificateSignature"); >>> 45: >>> 46: runAndCheckException( >> >> Minor: could you

Re: RFR: 8366211: Block signature scheme names to be used with CertificateSignature algorithm constraints usage

2025-08-28 Thread Mikhail Yankelevich
On Wed, 27 Aug 2025 19:04:20 GMT, Artur Barashev wrote: > To avoid any user confusion, we should block signature scheme names to be > used with `CertificateSignature` algorithm constraints usage. For example, > `RSASSA-PSS` certificate signature algorithm corresponds to multiple > signature sc

Integrated: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException

2025-08-28 Thread Mikhail Yankelevich
On Thu, 21 Aug 2025 09:06:39 GMT, Mikhail Yankelevich wrote: > * cleanup > * changed tests hiding errors and skips to be different `@test`, so the > errors could be thrown > * tests affected: > - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPoly.java > - /test/jdk/s

RFR: 8366342: Key generator and key pair generator tests skipping, but showing as passed

2025-08-28 Thread Mikhail Yankelevich
* Minor cleanup * Key generator and key pair generator tests skipping, but showing as passed: * test/jdk/sun/security/pkcs11/KeyGenerator/DESParity.java * test/jdk/sun/security/pkcs11/KeyGenerator/TestAES.java * test/jdk/sun/security/pkcs11/KeyGenerator/TestChaCha20.java * test/jdk/sun/

Re: RFR: 8366224: Introduce DecimalDigits.appendPair for efficient two-digit formatting and refactor DateTimeHelper

2025-08-27 Thread Mikhail Yankelevich
On Sat, 23 Aug 2025 04:06:13 GMT, Shaojin Wen wrote: > This PR introduces a new efficient API for appending two-digit integers to > StringBuilders and refactors DateTimeHelper to leverage this new > functionality. > > Changes include: > > 1. New `appendPair` method for efficient two-digit int

Re: RFR: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom

2025-08-26 Thread Mikhail Yankelevich
On Tue, 26 Aug 2025 14:47:56 GMT, Francesco Andreuzzi wrote: >> I might be misunderstanding your point, but I think in this case a full >> exception stack trace would be more helpful. It covers everything this way. > > The usual way to print exceptions includes the cause too. So if you create >

Re: RFR: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom [v2]

2025-08-26 Thread Mikhail Yankelevich
asic.java > * test/jdk/sun/security/pkcs11/SecureRandom/TestDeserialization.java Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: JDK-8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/Secret

Re: RFR: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom

2025-08-26 Thread Mikhail Yankelevich
On Tue, 26 Aug 2025 14:42:52 GMT, Francesco Andreuzzi wrote: >> It is set there on purpose. This way it will log to the `System.out` and not >> `System.err`. Just easier to spot this way. I can add `e` into skipped >> exception, but it seems to be a bit of an overkill. What do you think? > > To

Re: RFR: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom

2025-08-26 Thread Mikhail Yankelevich
On Tue, 26 Aug 2025 12:45:46 GMT, Francesco Andreuzzi wrote: >> Skipped tests are treated as a pass: >> >> * test/jdk/sun/security/pkcs11/KeyStore/ClientAuth.java >> * test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java >> * test/jdk/sun/security/pkcs11/SecretKeyFactory/TestGeneral.java

RFR: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom

2025-08-26 Thread Mikhail Yankelevich
Skipped tests are treated as a pass: * test/jdk/sun/security/pkcs11/KeyStore/ClientAuth.java * test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java * test/jdk/sun/security/pkcs11/SecretKeyFactory/TestGeneral.java * test/jdk/sun/security/pkcs11/SecureRandom/Basic.java * test/jdk/sun/security

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v6]

2025-08-24 Thread Mikhail Yankelevich
hGCM.java > - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipher.java > - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java > - /test/jdk/sun/security/pkcs11/Cipher/ReinitCipher.java > - /test/jdk/sun/security/pkcs11/Cipher/TestRawRSACipher.java > - /t

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v5]

2025-08-24 Thread Mikhail Yankelevich
On Fri, 22 Aug 2025 12:25:24 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Weijun's comments > > test/jdk/sun/security/pkcs11/Cipher/Tes

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v3]

2025-08-24 Thread Mikhail Yankelevich
On Fri, 22 Aug 2025 12:29:14 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Matthew's comments > > test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphers.ja

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v4]

2025-08-24 Thread Mikhail Yankelevich
On Fri, 22 Aug 2025 12:45:47 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changed tests from multiple to one with tracking skipped exception > > test/

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v5]

2025-08-24 Thread Mikhail Yankelevich
hGCM.java > - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipher.java > - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java > - /test/jdk/sun/security/pkcs11/Cipher/ReinitCipher.java > - /test/jdk/sun/security/pkcs11/Cipher/TestRawRSACipher.java > - /t

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v4]

2025-08-22 Thread Mikhail Yankelevich
hGCM.java > - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipher.java > - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java > - /test/jdk/sun/security/pkcs11/Cipher/ReinitCipher.java > - /test/jdk/sun/security/pkcs11/Cipher/TestRawRSACipher.java > - /t

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v3]

2025-08-21 Thread Mikhail Yankelevich
On Thu, 21 Aug 2025 14:56:26 GMT, Weijun Wang wrote: > But it used to be only one othervm test and there are dozens now, and each > needs to load a PKCS #11 library. Is it possible to add a flag that a test is > skipped and finally throw the `SkippedException`? This is possible, but it will ma

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v2]

2025-08-21 Thread Mikhail Yankelevich
On Thu, 21 Aug 2025 13:08:34 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update TestPKCS5PaddingError.java >> - cleanup and added id to tests &g

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v3]

2025-08-21 Thread Mikhail Yankelevich
hGCM.java > - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipher.java > - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java > - /test/jdk/sun/security/pkcs11/Cipher/ReinitCipher.java > - /test/jdk/sun/security/pkcs11/Cipher/TestRawRSACipher.java > - /t

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v2]

2025-08-21 Thread Mikhail Yankelevich
On Thu, 21 Aug 2025 13:30:25 GMT, Weijun Wang wrote: > Will it be slow now that there are so many `@main/othervm` runs? It will be slower, however it will notify if tests are skipped now, rather then before when it would be considered passed even if something is skipped. Also, different `@test

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v2]

2025-08-21 Thread Mikhail Yankelevich
On Thu, 21 Aug 2025 10:07:18 GMT, Daniel Jeliński wrote: >> Mikhail Yankelevich has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update TestPKCS5PaddingError.java >> - cleanup and added id to tests &g

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException [v2]

2025-08-21 Thread Mikhail Yankelevich
hGCM.java > - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipher.java > - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java > - /test/jdk/sun/security/pkcs11/Cipher/ReinitCipher.java > - /test/jdk/sun/security/pkcs11/Cipher/TestRawRSACipher.java > - /t

Re: RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException

2025-08-21 Thread Mikhail Yankelevich
On Thu, 21 Aug 2025 10:00:22 GMT, Daniel Jeliński wrote: >> * cleanup >> * changed tests hiding errors and skips to be different `@test`, so the >> errors could be thrown >> * tests affected: >> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPoly.java >> - /test/jdk/sun/security/pkcs11/Cip

RFR: 8365863: /test/jdk/sun/security/pkcs11/Cipher tests skip without SkippedException

2025-08-21 Thread Mikhail Yankelevich
* cleanup * changed tests hiding errors and skips to be different `@test`, so the errors could be thrown * tests affected: - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPoly.java - /test/jdk/sun/security/pkcs11/Cipher/TestCipherMode.java - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPo

Re: RFR: 8365861: test/jdk/sun/security/pkcs11/Provider/ tests skipped without SkippedException

2025-08-20 Thread Mikhail Yankelevich
On Wed, 20 Aug 2025 15:21:04 GMT, Francesco Andreuzzi wrote: >> * test/jdk/sun/security/pkcs11/Provider/ tests skipped without >> SkippedException: >> - test/jdk/sun/security/pkcs11/Provider/LoginISE.java >> - test/jdk/sun/security/pkcs11/Provider/ConfigShortPath.java >> - test/jdk/sun/se

RFR: 8365861: test/jdk/sun/security/pkcs11/Provider/ tests skipped without SkippedException

2025-08-20 Thread Mikhail Yankelevich
* test/jdk/sun/security/pkcs11/Provider/ tests skipped without SkippedException: - test/jdk/sun/security/pkcs11/Provider/LoginISE.java - test/jdk/sun/security/pkcs11/Provider/ConfigShortPath.java - test/jdk/sun/security/pkcs11/Provider/Absolute.java * cleanup - Commit messages:

Integrated: 8365660: test/jdk/sun/security/pkcs11/KeyAgreement/ tests skipped without SkipExceprion

2025-08-18 Thread Mikhail Yankelevich
On Mon, 18 Aug 2025 08:06:42 GMT, Mikhail Yankelevich wrote: > * Skipped exceptions added > * minor cleanup > > tests changed: > test/jdk/sun/security/pkcs11/KeyAgreement/TestDH.java > test/jdk/sun/security/pkcs11/KeyAgreement/UnsupportedDHKeys.java > test/jdk/sun/securit

Re: RFR: 8365288: PEMDecoder should throw ClassCastException [v2]

2025-08-18 Thread Mikhail Yankelevich
On Tue, 12 Aug 2025 17:43:30 GMT, Anthony Scarpino wrote: >> This bug fix is to change PEMDecoder.decode(..., Class<>) using >> PKCS8EncodedKeySpec and X509EncodedKeySpec will throw an >> IllegalArgumentException when the decoded data does not match. It should be >> ClassCastException. >> >>

Re: RFR: 8365660: test/jdk/sun/security/pkcs11/KeyAgreement/ tests skipped without SkipExceprion [v2]

2025-08-18 Thread Mikhail Yankelevich
On Mon, 18 Aug 2025 08:33:04 GMT, Francesco Andreuzzi wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> exception message > > test/jdk/sun/security/pkcs11/KeyAgreement/Unsupporte

Re: RFR: 8365660: test/jdk/sun/security/pkcs11/KeyAgreement/ tests skipped without SkipExceprion [v2]

2025-08-18 Thread Mikhail Yankelevich
rity/pkcs11/KeyAgreement/SupportedDHKeys.java > test/jdk/sun/security/pkcs11/KeyAgreement/TestInterop.java Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: exception message - Changes: - all: https://git.openj

RFR: 8365660: test/jdk/sun/security/pkcs11/KeyAgreement/ tests skipped without SkipExceprion

2025-08-18 Thread Mikhail Yankelevich
* Skipped exceptions added * minor cleanup tests changed: test/jdk/sun/security/pkcs11/KeyAgreement/TestDH.java test/jdk/sun/security/pkcs11/KeyAgreement/UnsupportedDHKeys.java test/jdk/sun/security/pkcs11/KeyAgreement/TestShort.java test/jdk/sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java

RFR: 8365623: test/jdk/sun/security/pkcs11/tls/ tests skipped without skip exception

2025-08-15 Thread Mikhail Yankelevich
missing skip exceptions: test/jdk/sun/security/pkcs11/tls/TestPRF.java test/jdk/sun/security/pkcs11/tls/TestPremaster.java test/jdk/sun/security/pkcs11/tls/TestMasterSecret.java test/jdk/sun/security/pkcs11/tls/TestKeyMaterialChaCha20.java test/jdk/sun/security/pkcs11/tls/TestKeyMaterial.java test/

RFR: 8365608: Test is skipped without skip exception /test/jdk/security/infra/java/security/cert/CertPathValidator/certification/ValidatePathWithParams.java

2025-08-15 Thread Mikhail Yankelevich
Replaced skip messages with skip exceptions - Commit messages: - JDK-8365608: Test is skipped without skip exception /test/jdk/security/infra/java/security/cert/CertPathValidator/certification/ValidatePathWithParams.java Changes: https://git.openjdk.org/jdk/pull/26804/files Webre

RFR: 8360373: src/java.base/share/classes/sun/security/util/Debug.java implement negative testing

2025-08-15 Thread Mikhail Yankelevich
Please consider my proposal to add some negative testing to the Debug.java. Adding a test, that will automatically convert current test cases into a broken parameters and expecting the successful execution, but without a debug result. This approach should keep the simplicity of adding new test

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v5]

2025-08-14 Thread Mikhail Yankelevich
On Tue, 12 Aug 2025 08:22:48 GMT, Volkan Yazici wrote: >> Mikhail Yankelevich has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull req

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v6]

2025-08-14 Thread Mikhail Yankelevich
> * fully automated the test > * removed the race condition > * client on a thread and server on a thread options are now run together > automatically Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: address

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v8]

2025-08-12 Thread Mikhail Yankelevich
> Moved the sh file logic to jtreg java test. Mikhail Yankelevich has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains five new commits si

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v6]

2025-08-11 Thread Mikhail Yankelevich
> 8351566: Consolidate third party artifacts used in tests Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge branch 'master' into JDK-8351566 - Merge branch 'master' into

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v7]

2025-08-11 Thread Mikhail Yankelevich
> Moved the sh file logic to jtreg java test. Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 2592 additional commits since

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v5]

2025-08-11 Thread Mikhail Yankelevich
> * fully automated the test > * removed the race condition > * client on a thread and server on a thread options are now run together > automatically Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev

Re: RFR: 8346962: Test CRLReadTimeout.java fails with -Xcomp by fstdebug build [v2]

2025-08-11 Thread Mikhail Yankelevich
> - Adjusted timings to prevent timeouts with `Fastdebug` and `-Xcomp` > - Split tests into parallel runs, reducing execution time by almost three-fold > - Replaced wildcard imports > - Specified the loopback address > - Enabled logs for easier debugging Mikhail Yankelevich has u

Integrated: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase

2025-08-01 Thread Mikhail Yankelevich
On Thu, 22 May 2025 12:22:26 GMT, Mikhail Yankelevich wrote: > * added an automated mixed case option > * using multithreading now > * added logs for simpler debug > * added missing -Djava.security.auth.debug coverage This pull request has now been integrated. Changeset: 6d0

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v4]

2025-08-01 Thread Mikhail Yankelevich
On Fri, 1 Aug 2025 14:20:15 GMT, Sean Coffey wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> reverting to have only the mixed case to keep the test more consise and >> still

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v5]

2025-08-01 Thread Mikhail Yankelevich
> * added an automated mixed case option > * using multithreading now > * added logs for simpler debug > * added missing -Djava.security.auth.debug coverage Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8360979: Remove use of Thread.stop in krb5/auto/KDC.java [v2]

2025-07-21 Thread Mikhail Yankelevich
On Mon, 21 Jul 2025 11:54:13 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> breaking the loop when interrupt flag is set > > test/jdk/sun/securit

Re: RFR: 8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures [v2]

2025-07-21 Thread Mikhail Yankelevich
> When the test is run now the reason for the failure will be requested > providing further feedback. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: Matthew's style comments - Changes: -

Re: RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo [v4]

2025-07-21 Thread Mikhail Yankelevich
> sun/security/krb5/config/native/TestDynamicStore.java is commonly run without > sudo, which leads to the access related failure. > Added a ui popup reminding to run the test with sudo, making instructions > clearer and more noticeable Mikhail Yankelevich has updated the

Re: RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo [v3]

2025-07-21 Thread Mikhail Yankelevich
On Mon, 21 Jul 2025 11:46:36 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changing alert to JOptionPane > > test/jdk/sun/security/krb5/config/native

RFR: 8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures

2025-07-21 Thread Mikhail Yankelevich
When the test is run now the reason for the failure will be requested providing further feedback. - Commit messages: - JDK-8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures Changes: https://git.openjdk.org/jdk/pull/26412/files Webrev: https

Re: RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo [v2]

2025-07-18 Thread Mikhail Yankelevich
On Wed, 16 Jul 2025 17:31:41 GMT, Rajan Halade wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> checking for root user automatically > > test/jdk/sun/security/krb5/config/native

Re: RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo [v3]

2025-07-18 Thread Mikhail Yankelevich
> sun/security/krb5/config/native/TestDynamicStore.java is commonly run without > sudo, which leads to the access related failure. > Added a ui popup reminding to run the test with sudo, making instructions > clearer and more noticeable Mikhail Yankelevich has updated the

Withdrawn: 8359340: KRB5 tests should protect themselves against random proxy selection

2025-07-15 Thread Mikhail Yankelevich
On Tue, 1 Jul 2025 09:57:31 GMT, Mikhail Yankelevich wrote: > 1. KRB5 tests is now always selecting NO_PROXY. > 2. test cleanup This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/26061

Re: RFR: 8360979: Remove use of Thread.stop in krb5/auto/KDC.java [v2]

2025-07-15 Thread Mikhail Yankelevich
> Replaced Thread::stop to Thread::interrupt Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: breaking the loop when interrupt flag is set - Changes: - all: https://git.openjdk.org/jdk/pull/26247/files -

Re: RFR: 8360979: Remove use of Thread.stop in krb5/auto/KDC.java [v2]

2025-07-15 Thread Mikhail Yankelevich
On Tue, 15 Jul 2025 11:55:01 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> breaking the loop when interrupt flag is set > > test/jdk/sun/securit

Re: RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo [v2]

2025-07-15 Thread Mikhail Yankelevich
On Tue, 15 Jul 2025 11:35:21 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> checking for root user automatically > > test/jdk/sun/security/krb5/config/nat

Re: RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo [v2]

2025-07-15 Thread Mikhail Yankelevich
> sun/security/krb5/config/native/TestDynamicStore.java is commonly run without > sudo, which leads to the access related failure. > Added a ui popup reminding to run the test with sudo, making instructions > clearer and more noticeable Mikhail Yankelevich has updated the

RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo

2025-07-14 Thread Mikhail Yankelevich
sun/security/krb5/config/native/TestDynamicStore.java is commonly run without sudo, which leads to the access related failure. Added a ui popup reminding to run the test with sudo, making instructions clearer and more noticeable - Commit messages: - JDK-8361894: sun/security/krb5/

RFR: 8360979: Remove use of Thread.stop in krb5/auto/KDC.java

2025-07-10 Thread Mikhail Yankelevich
Replaced Thread::stop to Thread::interrupt - Commit messages: - JDK-8360979: Remove use of Thread.stop in krb5/auto/KDC.java Changes: https://git.openjdk.org/jdk/pull/26247/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26247&range=00 Issue: https://bugs.openjdk.org/brow

Re: RFR: 8346962: Test CRLReadTimeout.java fails with -Xcomp by fstdebug build

2025-07-09 Thread Mikhail Yankelevich
On Wed, 9 Jul 2025 02:51:54 GMT, SendaoYan wrote: >> - Adjusted timings to prevent timeouts with `Fastdebug` and `-Xcomp` >> - Split tests into parallel runs, reducing execution time by almost >> three-fold >> - Replaced wildcard imports >> - Specified the loopback address >> - Enabled logs for

RFR: 8346962: Test CRLReadTimeout.java fails with -Xcomp by fstdebug build

2025-07-08 Thread Mikhail Yankelevich
- Adjusted timings to prevent timeouts with `Fastdebug` and `-Xcomp` - Split tests into parallel runs, reducing execution time by almost three-fold - Replaced wildcard imports - Specified the loopback address - Commit messages: - 8346962: Test CRLReadTimeout.java fails with -Xcomp by

RFR: 8359340: KRB5 tests should protect themselves against random proxy selection

2025-07-01 Thread Mikhail Yankelevich
1. KRB5 tests is now always selecting NO_PROXY. 2. test cleanup - Commit messages: - 8359340: KRB5 tests should protect themselves against random proxy selection - Merge branch 'master' into JDK-8359340 - test cleanup Changes: https://git.openjdk.org/jdk/pull/26061/files Webrev

Re: RFR: 8343395: SSLLogger doesn't work for formatted messages [v2]

2025-06-25 Thread Mikhail Yankelevich
On Tue, 24 Jun 2025 11:44:44 GMT, Sean Coffey wrote: >> SLSLogger is broken when used with with `System.Logger` (-Djavax.net.debug >> mode) >> >> SSL Debug messages don't use format specifiers. As a result, any custom >> format data isn't printed. Proposed solution is to append the SSL custom

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v2]

2025-06-25 Thread Mikhail Yankelevich
On Sat, 21 Jun 2025 23:32:04 GMT, Koushik Muthukrishnan Thirupattur wrote: >> Mikhail Yankelevich has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master'

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v2]

2025-06-25 Thread Mikhail Yankelevich
On Sun, 22 Jun 2025 17:21:17 GMT, Koushik Muthukrishnan Thirupattur wrote: >> Mikhail Yankelevich has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master'

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v4]

2025-06-25 Thread Mikhail Yankelevich
> * added an automated mixed case option > * using multithreading now > * added logs for simpler debug > * added missing -Djava.security.auth.debug coverage Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: rever

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v3]

2025-06-25 Thread Mikhail Yankelevich
On Tue, 24 Jun 2025 10:41:29 GMT, Mikhail Yankelevich wrote: >> * added an automated mixed case option >> * using multithreading now >> * added logs for simpler debug >> * added missing -Djava.security.auth.debug coverage > > Mikhail Yankelevich has updated the p

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v3]

2025-06-24 Thread Mikhail Yankelevich
On Tue, 24 Jun 2025 13:02:45 GMT, Sean Coffey wrote: > As the original contributor of this test case, it's nice to see the speed up > via use of ExecutorService. > > The upper case and lower case property tests are somewhat questionable IMO. > One or two lines of test code would suffice but no

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v2]

2025-06-24 Thread Mikhail Yankelevich
On Sat, 21 Jun 2025 23:18:39 GMT, Koushik Muthukrishnan Thirupattur wrote: >> Mikhail Yankelevich has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master'

  1   2   3   >