[SMW-devel] Problems with SMW_QP_JSONlink.php

2009-08-14 Thread Neil Davies
Hi All, I have a found several bugs in SMW_QP_JSONlink.php. In summary these are: - It produces invalid JSON (the keys are not always enclsoed in quotes) - It fails on certain queries - namely when you specify a query to retrieve certain values from a particular page I've tested it

Re: [SMW-devel] Problems with SMW_QP_JSONlink.php

2009-08-14 Thread Sergey Chernyshev
Here's another useful page on MediaWiki hacking in general: http://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Posting_a_patch Thank you, Sergey -- Sergey Chernyshev http://www.sergeychernyshev.com/ On Fri, Aug 14, 2009 at 11:07 AM, Sergey Chernyshev

Re: [SMW-devel] Problems with SMW_QP_JSONlink.php

2009-08-14 Thread Neil Davies
Thanks, I have created the bug report and attached the patch https://bugzilla.wikimedia.org/show_bug.cgi?id=20241 Neil On Fri, Aug 14, 2009 at 11:09 AM, Sergey Chernyshev sergey.chernys...@gmail.com wrote: Here's another useful page on MediaWiki hacking in general:

Re: [SMW-devel] Problems with SMW_QP_JSONlink.php

2009-08-14 Thread Markus Krötzsch
Neil, thanks a lot! Contributions are very welcome. On Freitag, 14. August 2009, Sergey Chernyshev wrote: Neil, Usually it's done by filing a bug in Bugzilla and attaching a patch. Yes, this is the preferred solution in this case. In particular, there is a reason why the JSON is invalid:

Re: [SMW-devel] Problems with SMW_QP_JSONlink.php

2009-08-14 Thread Markus Krötzsch
On Freitag, 14. August 2009, Neil Davies wrote: Thanks, I have created the bug report and attached the patch https://bugzilla.wikimedia.org/show_bug.cgi?id=20241 Thanks. (I sent my previous mail before seeing this). -- Markus Neil On Fri, Aug 14, 2009 at 11:09 AM, Sergey Chernyshev