[jira] Created: (JAMES-469) Make SMTP message queuing configurable (as an Handler)

2006-04-07 Thread Stefano Bagnara (JIRA)
Make SMTP message queuing configurable (as an Handler) -- Key: JAMES-469 URL: http://issues.apache.org/jira/browse/JAMES-469 Project: James Type: Improvement Components: SMTPServer Versions: 2.3.0a1

svn commit: r392227 - in /james/server/trunk/src: conf/ java/org/apache/james/smtpserver/ test/org/apache/james/smtpserver/ test/org/apache/james/test/util/

2006-04-07 Thread bago
Author: bago Date: Fri Apr 7 02:15:34 2006 New Revision: 392227 URL: http://svn.apache.org/viewcvs?rev=392227view=rev Log: Make SMTP message queuing configurable (as an Handler) (JAMES-469) Added: james/server/trunk/src/java/org/apache/james/smtpserver/SendMailHandler.java Modified:

[jira] Commented: (JAMES-466) java.sql.SQLException: Error reading from InputStream java.io.IOException in current trunk

2006-04-07 Thread Stefano Bagnara (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-466?page=comments#action_12373603 ] Stefano Bagnara commented on JAMES-466: --- Thank you for the tests, unfortunately I'm not able to reproduce it in a test. Can you change the throwException() method of

Re: Latest commits Unit Tests

2006-04-07 Thread Stefano Bagnara
I saw the problem too. I've had no time to investigate on this: the idea to assign them incrementally could work. Please submit a patch if you fix this succesfully! Thank you, Stefano Bernd Fondermann wrote: I made the observation that arbitrary tests seem to fail on random, but rare

[jira] Updated: (JAMES-470) DNSRBLHandler config error

2006-04-07 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-470?page=all ] Norman Maurer updated JAMES-470: Attachment: DNSRBLHandler-config-fix.patch Fix it DNSRBLHandler config error -- Key: JAMES-470 URL:

svn commit: r392245 - /james/server/trunk/src/java/org/apache/james/smtpserver/DNSRBLHandler.java

2006-04-07 Thread bago
Author: bago Date: Fri Apr 7 03:40:01 2006 New Revision: 392245 URL: http://svn.apache.org/viewcvs?rev=392245view=rev Log: DNSRBLHandler config error (JAMES-470) Patch by Norman Maurer Modified: james/server/trunk/src/java/org/apache/james/smtpserver/DNSRBLHandler.java Modified:

[jira] Resolved: (JAMES-469) Make SMTP message queuing configurable (as an Handler)

2006-04-07 Thread Stefano Bagnara (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-469?page=all ] Stefano Bagnara resolved JAMES-469: --- Fix Version: 2.3.0a2 Resolution: Fixed Created the command, updated the default configuration. Upgraded the tests. The handler/chain lifecycle

Re: Coding Template for eclipse

2006-04-07 Thread Stefano Bagnara
IIRC I only changed the newfile template adding the ASL2 license. In the Formatter dialog I chose Java Conventions [built-in]. Stefano Norman Maurer wrote: Hi guys, anyone has a eclipse coding template which can be shared to reflect the coding style of james ? ?xml version=1.0

Re: Maven 2 and XBean

2006-04-07 Thread Stefano Bagnara
Alan D. Cabrera wrote: Stefano Bagnara wrote, On 4/5/2006 3:19 PM: What type of IOC is used by XBeans ? Is it based on the Service Locator pattern like Avalon or Dependency Injection? In the latter case, what DI type? Constructor, Setter or Interface injection? Constructor and Setter DI.

[jira] Created: (JAMES-471) Tarpit support

2006-04-07 Thread Norman Maurer (JIRA)
Tarpit support -- Key: JAMES-471 URL: http://issues.apache.org/jira/browse/JAMES-471 Project: James Type: New Feature Reporter: Norman Maurer Attachments: RcptCmdHandler-tarpit.patch, james-config.xml-tarpit.patch I wrote a patch to support

[jira] Updated: (JAMES-471) Tarpit support

2006-04-07 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-471?page=all ] Norman Maurer updated JAMES-471: Attachment: james-config.xml-tarpit.patch patched Config Tarpit support -- Key: JAMES-471 URL:

[jira] Updated: (JAMES-471) Tarpit support

2006-04-07 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-471?page=all ] Norman Maurer updated JAMES-471: Attachment: RcptCmdHandler-tarpit.patch Patched RcptCmdHandler Tarpit support -- Key: JAMES-471 URL:

Re: Maven 2 and XBean

2006-04-07 Thread Bernd Fondermann
Stefano Bagnara wrote: Alan D. Cabrera wrote: I can't find many informations about what xbean-kernel is and xbean-server is, how to use them, and more. I've just downloaded sources from here: http://svn.xbean.org/trunk/ Is this the current official/updated repository? I see no changes after

Re: Maven 2 and XBean

2006-04-07 Thread Stefano Bagnara
Bernd Fondermann wrote: I've just downloaded sources from here: http://svn.xbean.org/trunk/ Is this the current official/updated repository? I see no changes after february. that must have been the point in time where xbean moved to Apache Geronimo and disappeared from the Codehaus projects

svn commit: r392293 - in /james/server/trunk/src: conf/james-config.xml java/org/apache/james/smtpserver/RcptCmdHandler.java

2006-04-07 Thread bago
Author: bago Date: Fri Apr 7 07:04:10 2006 New Revision: 392293 URL: http://svn.apache.org/viewcvs?rev=392293view=rev Log: Tarpit support (JAMES-471) Feature provided by Norman Maurer Modified: james/server/trunk/src/conf/james-config.xml

[jira] Resolved: (JAMES-471) Tarpit support

2006-04-07 Thread Stefano Bagnara (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-471?page=all ] Stefano Bagnara resolved JAMES-471: --- Fix Version: 2.3.0a2 Resolution: Fixed Assign To: Stefano Bagnara Applied! Thank you for the patch! Tarpit support --

[jira] Commented: (JAMES-471) Tarpit support

2006-04-07 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-471?page=comments#action_12373641 ] Norman Maurer commented on JAMES-471: - I have to add junit tests for that. I think i should do something like check howlong the response take for checking if tarpit is

[jira] Created: (JAMES-472) Add Greylist support

2006-04-07 Thread Norman Maurer (JIRA)
Add Greylist support Key: JAMES-472 URL: http://issues.apache.org/jira/browse/JAMES-472 Project: James Type: New Feature Reporter: Norman Maurer Im working on a patch to add Greylisting support to james. It 90 % done. Im using a dir in

[jira] Commented: (JAMES-472) Add Greylist support

2006-04-07 Thread Noel J. Bergman (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-472?page=comments#action_12373644 ] Noel J. Bergman commented on JAMES-472: --- The next version of JAMES will include Derby, so I believe that you can count on the presence of JDBC in all future versions.

General approach to handlers

2006-04-07 Thread Noel J. Bergman
The intent -- at least from some of us -- for the handler chain was not to keep adding features into core handlers, but to add additional handlers. So far, I keep seeing more optional features added to core handlers. Comments? --- Noel

Tarpitting

2006-04-07 Thread Noel J. Bergman
Tarpitting is used to refer to any of several things, e.g., http://www.merakmailserver.com/Knowledgebase/Merak_Mail_Server/Security/Tarpitting.asp http://www.palomine.net/qmail/tarpit.html We have just added the latter, not the former. I am not sure how effective either of these strategies

[jira] Commented: (JAMES-472) Add Greylist support

2006-04-07 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-472?page=comments#action_12373645 ] Norman Maurer commented on JAMES-472: - I think the main reason for using the filesystem is that it will work on all servers with and without db. Add Greylist support

Re: General approach to handlers

2006-04-07 Thread Norman Maurer
The main reason for adding the features in the handler was that otherwise we have some more handlers to maintain and maybe some duplicate code. So i see no problems with that.. The features are all disabled when no configure value is set. So running installations should not have any comments. But

Re: Tarpitting

2006-04-07 Thread Norman Maurer
im also no big fan of this feature. But we a custumer of us want this feature so i add it. bye Am Freitag, den 07.04.2006, 10:43 -0400 schrieb Noel J. Bergman: Tarpitting is used to refer to any of several things, e.g.,

Re: Maven 2 and XBean

2006-04-07 Thread Bernd Fondermann
Stefano Bagnara wrote: Bernd Fondermann wrote: for example the parent class hiearchie for core components like org.apache.james.James is based on classes like org.apache.avalon.framework.logger.LogEnabled. LogEnabled provides functionality for what is called an 'aspect' today. modern IoC

Re: General approach to handlers

2006-04-07 Thread Stefano Bagnara
Noel J. Bergman wrote: The intent -- at least from some of us -- for the handler chain was not to keep adding features into core handlers, but to add additional handlers. So far, I keep seeing more optional features added to core handlers. Comments? I applied the following patches: 1)

Re: Maven 2 and XBean

2006-04-07 Thread Stefano Bagnara
Bernd Fondermann wrote: by just moving the codebase into the project? what would that change? in my understanding, a class implementing container-specific lifecycle interfaces like Servicable, Configurable, etc. is not a plain POJO anymore. You could think to Startable, Disposable,

Re: General approach to handlers

2006-04-07 Thread Norman Maurer
Maybe it would be a nice thing to have a other subproject which only include custom mailets and matchers and to provide a jar which is builded based on that. After that its possible to add the packagename to the config.xml and add the jar do the apps/james/SAR-INF/lib/ directory. Am Freitag, den

RE: General approach to handlers

2006-04-07 Thread Noel J. Bergman
Stefano Bagnara wrote: Noel J. Bergman wrote: The intent -- at least from some of us -- for the handler chain was not to keep adding features into core handlers, but to add additional handlers. So far, I keep seeing more optional features added to core handlers. Comments? I

Re: General approach to handlers

2006-04-07 Thread Stefano Bagnara
Noel J. Bergman wrote: Agreed on all of the above. As you might notice, I have been reviewing the commits, was not asking for them to be reverted, and was raising a general issue based upon a recent pattern. I'm sorry if my english is not good enough to let you understand my mood ;-) I wanted

Nightly builds (fixed, again) and svn:eol-style

2006-04-07 Thread Noel J. Bergman
I just repaired the nightly builds. Apparently, some recent patches, starting on April 1 (so probably a commit on March 31) created a local conflict on the build server, causing the builds to fail. The specific files were the Helo, Ehlo, Rcpt and Mail handlers, if I recall correctly. I haven't

Re: Maven 2 and XBean

2006-04-07 Thread Alan D. Cabrera
Stefano Bagnara wrote: Alan D. Cabrera wrote: Can XBean split the configuration in 2 multiple files? We currently have assembly.xml to declare how the component dependencies/wiring and config.xml to fill in configurations for that components. I don't think so. I've had some experience w/

Re: Maven 2 and XBean

2006-04-07 Thread Alan D. Cabrera
Bernd Fondermann wrote: wouldn't it be best to POJO-fy _first_ without a specific container in mind (a larger task on its own) and then afterwards look at all the mature containers to integrate with? My thoughts exactly. IMHO, if the container makes you do weird things with your design at

Re: Nightly builds (fixed, again) and svn:eol-style

2006-04-07 Thread Stefano Bagnara
Noel J. Bergman wrote: I have also seen svn notices where far more lines than were changed were marked as changed, and suspect that the lack of the svn:eol-style property on the file is responsible. Stefano appears to be using MS-Windows, and our build process specifically converts line endings

Re: Maven 2 and XBean

2006-04-07 Thread Alan D. Cabrera
Bernd Fondermann wrote: Stefano Bagnara wrote: I currently don't have an opinion on what it is better for us between j2ee, OSGi, XBean, Phoenix, put what you want here, but I think that we should choose one. This is way I'm really interested in pro/cons of XBean. AFAIK, XBean is to become

Re: Maven 2 and XBean

2006-04-07 Thread Stefano Bagnara
Alan D. Cabrera wrote: Bernd Fondermann wrote: wouldn't it be best to POJO-fy _first_ without a specific container in mind (a larger task on its own) and then afterwards look at all the mature containers to integrate with? My thoughts exactly. IMHO, if the container makes you do weird

Re: Maven 2 and XBean

2006-04-07 Thread Stefano Bagnara
Alan D. Cabrera wrote: Can XBean split the configuration in 2 multiple files? We currently have assembly.xml to declare how the component dependencies/wiring and config.xml to fill in configurations for that components. I don't think so. I've had some experience w/ having deps and configs

Re: Maven 2 and XBean

2006-04-07 Thread Stefano Bagnara
Alan D. Cabrera wrote: Bernd Fondermann wrote: Stefano Bagnara wrote: I currently don't have an opinion on what it is better for us between j2ee, OSGi, XBean, Phoenix, put what you want here, but I think that we should choose one. This is way I'm really interested in pro/cons of XBean.

[jira] Created: (JAMES-473) AddHeaderHandler configure bug

2006-04-07 Thread Norman Maurer (JIRA)
AddHeaderHandler configure bug -- Key: JAMES-473 URL: http://issues.apache.org/jira/browse/JAMES-473 Project: James Type: Bug Reporter: Norman Maurer Attachments: AddHeaderHandler-fix.patch There is a bug in configure method.. The

[jira] Updated: (JAMES-473) AddHeaderHandler configure bug

2006-04-07 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-473?page=all ] Norman Maurer updated JAMES-473: Attachment: AddHeaderHandler-fix.patch fixed AddHeaderHandler configure bug -- Key: JAMES-473 URL:

[jira] Commented: (JAMES-468) Limit MaxRcpt per Email

2006-04-07 Thread Steve Short (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-468?page=comments#action_12373663 ] Steve Short commented on JAMES-468: --- This patch returns the wrong status code when the recipient limit is reached. It currently returns 571 but it should return 452. See

svn commit: r392339 - /james/server/trunk/src/java/org/apache/james/smtpserver/AddHeaderHandler.java

2006-04-07 Thread bago
Author: bago Date: Fri Apr 7 10:19:45 2006 New Revision: 392339 URL: http://svn.apache.org/viewcvs?rev=392339view=rev Log: AddHeaderHandler configure bug (JAMES-473) Applied patch by Norman Maurer and added an identical fix to the following call. Modified:

[jira] Commented: (JAMES-468) Limit MaxRcpt per Email

2006-04-07 Thread Steve Short (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-468?page=comments#action_12373665 ] Steve Short commented on JAMES-468: --- I forgot to add this status should prevent the addition of further recipients but should not invalidate the mail, the client must be

[jira] Resolved: (JAMES-473) AddHeaderHandler configure bug

2006-04-07 Thread Stefano Bagnara (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-473?page=all ] Stefano Bagnara resolved JAMES-473: --- Fix Version: 2.3.0a2 Resolution: Fixed Assign To: Stefano Bagnara Applied the patch and fixed the following configuration call.

[jira] Commented: (JAMES-468) Limit MaxRcpt per Email

2006-04-07 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-468?page=comments#action_12373670 ] Norman Maurer commented on JAMES-468: - After have a quick review of some patches for qmail and reading a bit more docs it can also use a 571 code and reject the message

Re: [jira] Commented: (JAMES-468) Limit MaxRcpt per Email

2006-04-07 Thread Stefano Bagnara
Norman Maurer (JIRA) wrote: I will fix it soon.. If I can give you an hint on bugfix workflow: 1) change the tests to check both issues and see them failing 2) fix the involved class 3) rerun tests and see they pass. 4) provide the patch Stefano Limit MaxRcpt per Email

Re: Nightly builds (fixed, again) and svn:eol-style

2006-04-07 Thread Stefano Bagnara
Stefano Bagnara wrote: Noel J. Bergman wrote: I have also seen svn notices where far more lines than were changed were marked as changed, and suspect that the lack of the svn:eol-style property on the file is responsible. Stefano appears to be using MS-Windows, and our build process

[jira] Commented: (JAMES-468) Limit MaxRcpt per Email

2006-04-07 Thread Stefano Bagnara (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-468?page=comments#action_12373674 ] Stefano Bagnara commented on JAMES-468: --- Is this alternative described in an RFC ? If not we should follow the standard behaviour (452 and accept remaining recipients)

[jira] Created: (JAMES-474) NullPointerException and bodymessage lost with weird configurations in message spooling

2006-04-07 Thread Stefano Bagnara (JIRA)
NullPointerException and bodymessage lost with weird configurations in message spooling --- Key: JAMES-474 URL: http://issues.apache.org/jira/browse/JAMES-474 Project: James Type:

svn commit: r392373 - in /james/server/trunk/src: java/org/apache/james/core/ test/org/apache/james/core/

2006-04-07 Thread bago
Author: bago Date: Fri Apr 7 12:50:54 2006 New Revision: 392373 URL: http://svn.apache.org/viewcvs?rev=392373view=rev Log: Test and temporary fix for a rare but critical NPE in MimeMessageWrapper (JAMES-474) Modified:

RE: Maven 2 and XBean

2006-04-07 Thread Steve Brewin
Stefano Bagnara wrote: It seems that if there is one thing that stirs us up it is container issues. At their most basic, containers provides the glue to wire application specific objects together and provide them with the service they require. Application objects are simple POJOs that are both