RE: james-2.3a4

2006-05-30 Thread Norman Maurer
I want also rename the AddHandler and SetHandler before release 2.3. See JAMES-513 for more infos. If we do it before release 2.3 we could deprected the old Handler/Mailet now. bye Norman Ps: please give me your feedbacks Am Dienstag, den 30.05.2006, 23:50 -0400 schrieb Noel J. Bergman: > > I'm

Re: Managing Changes

2006-05-30 Thread Norman Maurer
Am Mittwoch, den 31.05.2006, 01:08 -0400 schrieb Serge Knystautas: > On 5/30/06, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > > Well, I think this explain why I think that this is not a best practice. > > Most James discussions takes weeks and are lost forever with no results. > > This thread has

Re: Managing Changes

2006-05-30 Thread Serge Knystautas
On 5/30/06, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Well, I think this explain why I think that this is not a best practice. Most James discussions takes weeks and are lost forever with no results. This thread has gotten somewhat bitter. My 2 cents... I voted for Stefano as a committer and

Re: Maven2 opinions

2006-05-30 Thread Serge Knystautas
On 5/30/06, Noel J. Bergman <[EMAIL PROTECTED]> wrote: Paranoia is a positive adaptive trait in a security administrator. Especially when you run the code as root! I have no problem understanding the security threat; I just find it FUD. Widespread usage, no publicized attacks, the paranoid th

RE: james-2.3a4

2006-05-30 Thread Noel J. Bergman
> I'm going to try to get Stefano's patch merged in tonight Done, for both branches. Normally, I'd test first, but if necessary we can revert to r410395, even if it is only a partial fix. By the way, Stefano did the harder of the fixes, but possibly the most useful, since it will still force clo

svn commit: r410426 - in /james/server/branches/v2.3/src: conf/ java/org/apache/james/core/ java/org/apache/james/mailrepository/filepair/

2006-05-30 Thread noel
Author: noel Date: Tue May 30 20:49:33 2006 New Revision: 410426 URL: http://svn.apache.org/viewvc?rev=410426&view=rev Log: JAMES-512. Patch by Stefano Bagnara. Remove RepositoryManager, which was holding repositories in memory. Added: james/server/branches/v2.3/src/java/org/apache/james/

svn commit: r410423 - in /james/server/trunk/src: conf/ java/org/apache/james/core/ java/org/apache/james/mailrepository/filepair/

2006-05-30 Thread noel
Author: noel Date: Tue May 30 20:25:29 2006 New Revision: 410423 URL: http://svn.apache.org/viewvc?rev=410423&view=rev Log: JAMES-512. Patch by Stefano Bagnara. Remove RepositoryManager, which was holding repositories in memory. Modified: james/server/trunk/src/conf/james-assembly.xml

RE: james-2.3a4

2006-05-30 Thread Noel J. Bergman
> I'm +1 for fixing first, then releasing. Yes, we had agreed on a beta 1, IIRC. I'm going to try to get Stefano's patch merged in tonight and then go to sleep. Will check e-mail in the morning, and then during the day if I have access from the site. Else tomorrow night. --- Noel ---

RE: svn commit: r410228 - in /james/server/trunk/src/test/org/apache/james: test/mock/mailet/MockMatcherConfig.java transport/matchers/AllTest.java

2006-05-30 Thread Noel J. Bergman
Bernd Fondermann wrote: >> Stefano wrote: >>> Please note that String.contains is Java 1.5+ >>> I don't care that tests are java 1.5, but maybe someone cares. > Well, this is too easy to be made 1.4-compliant to give that > compatibility away, isn't it? If you've got a simple patch, please feel

svn commit: r410422 - in /james/server/branches/v2.3/src/java/org/apache/james: core/AvalonMailStore.xinfo mailrepository/filepair/File_Persistent_Stream_Repository.java

2006-05-30 Thread noel
Author: noel Date: Tue May 30 20:10:29 2006 New Revision: 410422 URL: http://svn.apache.org/viewvc?rev=410422&view=rev Log: remove, prepatory to copying over replacements from trunk. Removed: james/server/branches/v2.3/src/java/org/apache/james/core/AvalonMailStore.xinfo james/server/br

Re: svn commit: r410228 - in /james/server/trunk/src/test/org/apache/james: test/mock/mailet/MockMatcherConfig.java transport/matchers/AllTest.java

2006-05-30 Thread Bernd Fondermann
Noel J. Bergman wrote: Please note that String.contains is Java 1.5+ I don't care that tests are java 1.5, but maybe someone cares. I care for the server, but less so for testing. Anyone else? Well, this is too easy to be made 1.4-compliant to give that compatibility away, isn't it? Be

Re: james-2.3a4

2006-05-30 Thread Bernd Fondermann
Stefano Bagnara wrote: Norman Maurer wrote: Hi guys, when we want to release 2.3a4 ? I don't know if we all agreed on a "beta1" - anyway I uploaded the current 2.3 branch to minotaur, but refrained to post about it because critical JAMES-512 popped up. +1 as soon as possible After fix

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Bernd Fondermann
Noel J. Bergman wrote: Bernd, If you checkout r410395, you'll have just the one change made. But I do not believe that it is sufficient. It will fix one case, but not the case where repositories are written but messages are not removed, at least as far as it appears from reviewing the code. D

Re: [jira] Updated: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Stefano Bagnara
Noel J. Bergman wrote: Stefano Bagnara wrote: Attachment: james-512.patch I would include this in trunk, test it and backport to 2.3 I looked it over. Do you have time to commit this tonight? --- Noel No, too late now. 1am and I'm still at work.. have to eat something and s

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Stefano Bagnara
Noel J. Bergman wrote: File_Persistent_Stream_Repository has been copied by the cornerstone-store project. IIRC, amusingly, they told us to copy/fork the code, because they were going to delete it from Cornerstone. All that files are still included in their last official cornerstone releases

RE: svn commit: r410228 - in /james/server/trunk/src/test/org/apache/james: test/mock/mailet/MockMatcherConfig.java transport/matchers/AllTest.java

2006-05-30 Thread Noel J. Bergman
> Please note that String.contains is Java 1.5+ > I don't care that tests are java 1.5, but maybe someone cares. I care for the server, but less so for testing. Anyone else? --- Noel - To unsubscribe, e-mail: [EMAIL PR

RE: [jira] Updated: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Noel J. Bergman
Stefano Bagnara wrote: >Attachment: james-512.patch > I would include this in trunk, test it and backport to 2.3 I looked it over. Do you have time to commit this tonight? --- Noel - To unsubscribe, e-mail: [EMA

[jira] Updated: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Stefano Bagnara (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=all ] Stefano Bagnara updated JAMES-512: -- Attachment: james-512.patch Here is my proposal to remove RepositoryManager usage and to have fully weak references. Includes the fix for the memory leak in

RE: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Noel J. Bergman
Bernd, If you checkout r410395, you'll have just the one change made. But I do not believe that it is sufficient. It will fix one case, but not the case where repositories are written but messages are not removed, at least as far as it appears from reviewing the code. Do you see it differently?

Re: svn commit: r410228 - in /james/server/trunk/src/test/org/apache/james: test/mock/mailet/MockMatcherConfig.java transport/matchers/AllTest.java

2006-05-30 Thread Stefano Bagnara
Please note that String.contains is Java 1.5+ I don't care that tests are java 1.5, but maybe someone cares.. [EMAIL PROTECTED] wrote: Author: norman Date: Tue May 30 02:26:45 2006 New Revision: 410228 URL: http://svn.apache.org/viewvc?rev=410228&view=rev Log: Correct a bug in MockMatcherConfig

svn commit: r410395 - in /james/server: branches/v2.3/src/java/org/apache/james/mailrepository/filepair/File_Persistent_Stream_Repository.java trunk/src/java/org/apache/james/mailrepository/filepair/F

2006-05-30 Thread noel
Author: noel Date: Tue May 30 15:27:38 2006 New Revision: 410395 URL: http://svn.apache.org/viewvc?rev=410395&view=rev Log: Fix obvious bug in releasing streams. Added: james/server/branches/v2.3/src/java/org/apache/james/mailrepository/filepair/File_Persistent_Stream_Repository.java -

svn commit: r410394 - /james/server/branches/v2.3/src/java/org/apache/james/mailrepository/filepair/File_Persistent_Stream_Repository.java

2006-05-30 Thread noel
Author: noel Date: Tue May 30 15:26:54 2006 New Revision: 410394 URL: http://svn.apache.org/viewvc?rev=410394&view=rev Log: remove; next commit will copy over replacement from trunk. Removed: james/server/branches/v2.3/src/java/org/apache/james/mailrepository/filepair/File_Persistent_Stream_

[jira] Assigned: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Noel J. Bergman (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=all ] Noel J. Bergman reassigned JAMES-512: - Assign To: Noel J. Bergman (was: Bernd Fondermann) > OutOfMemoryError -- object not released. > > >

[jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Noel J. Bergman (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413921 ] Noel J. Bergman commented on JAMES-512: --- ... public synchronized InputStream get( final String key ) { try { final ResettableFileIn

RE: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Noel J. Bergman
Stefano Bagnara wrote: > Bernd Fondermann wrote: > What I am suggesting is restoring the file to its original state. > Then, instead of removing the hashes, only line 156 should be > changed. Then let's see what happens. > From a code review I don't think this will fix the leak I agree with Stef

RE: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Noel J. Bergman
Joachim Draeger wrote: > Noel J. Bergman schrieb: > > This problem sounds related one we've previously documented, but > > not finished fixing. The file-based repositories maintain an > > in-memory list of the e-mails, which grows forever unless you > > remove messages from it. > They hold refer

Re: Managing Changes

2006-05-30 Thread Stefano Bagnara
Steve Brewin wrote: Stefano Bagnara wrote: I also wrote something really clear: "If I understand your words you are: -1 to apply the code for a 2.4 release but you don't apply a veto if the release will be 3.0 or if we add unit tests, is it right? " No reply is not a fast solution. 3 days have

RE: Managing Changes

2006-05-30 Thread Steve Brewin
Stefano Bagnara wrote: > I also wrote something really clear: "If I understand your words you > are: -1 to apply the code for a 2.4 release but you don't > apply a veto > if the release will be 3.0 or if we add unit tests, is it right? " > > No reply is not a fast solution. 3 days have passed and

Re: james-2.3a4

2006-05-30 Thread Stefano Bagnara
Norman Maurer wrote: Hi guys, when we want to release 2.3a4 ? +1 as soon as possible After fixing JAMES-512 ? don't care too much. Better if fixed, but better to have a a4 soon. Stefano - To unsubscribe, e-mail: [EMAIL

RE: james-2.3a4

2006-05-30 Thread Noel J. Bergman
Noel J. Bergman wrote: > What is the consensus on the JAMES-512 status? I believe that we all agree that the fix is to remove the stream cache, and to make sure that streams are properly closed by the code acquiring them in JAMES. --- Noel --

JAMES post-2.3

2006-05-30 Thread Noel J. Bergman
Norman Maurer wrote: > I also not sure if we should release more 2.x releases then the 2.3.0 . > IMMO we should only make bug releases after that and focus on james 3.x > to include IMAP/Maildir support, fastfail etc. Cause this will maybe > need major changes on CORE componets. I think that we h

RE: james-2.3a4

2006-05-30 Thread Noel J. Bergman
> when we want to release 2.3a4 ? I think that I lost track of where we were with that last week. > After fixing JAMES-512 ? I haven't caught up on this afternoon's e-mail regarding it, but IF we have a good fix for it, let's put it in and cut 2.3.0a4. I can do that now. What is the consensus o

Re: Managing Changes

2006-05-30 Thread Stefano Bagnara
Noel J. Bergman wrote: As you suggest, we want development to happen actively within source control, so that people can see the changes as they happen. This has not been my impression: I received "alerts" every time I committed something without discussing first. I always said that we could r

RE: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Noel J. Bergman
Stefano Bagnara wrote: > The File_Persistent_Stream_Repository currently caches every > inputstream and outputstream used and never release them. Correct. It assumes that messages are released by the client code calling the remove operation on the respository. AFAICS, the code is holding on to

RE: Maven2 opinions

2006-05-30 Thread Noel J. Bergman
Serge Knystautas wrote: > Java has survived for 10+ years without such an attack. And for those 10+ years, Java security has been based upon one of two things: location and, more recently, signing. Most jars, e.g., Sun's jars, are not signed. Besides, and not atypically, JAMES does not use Java

Re: Maven2 opinions

2006-05-30 Thread Stefano Bagnara
Noel J. Bergman wrote: 4. It will allow us to split James in subprojects: mailet-api, mailet-impl, core, smtp, pop3, nntp, fetchmail, mailets, spoolmanager having well-defined dependencies between modules. What prevents us from doing that with Ant? What prevents us from doing any of this with

Re: Maven2 opinions

2006-05-30 Thread Stefano Bagnara
Noel J. Bergman wrote: Obviously, we already have some separation, e.g., src/java/.../{component} for major component areas. We could generate separate jars for each. That is what we should do.. Many jars generation will it be easier for people which only depend on a single compenent of us. T

Re: Managing Changes

2006-05-30 Thread Stefano Bagnara
Steve Brewin wrote: What I said about fetchmail holds for Maven 2 too. I'll try this another way. For 2.2.x code, if it ain't broke, don't fix it. Oh, I agree: the difference is in the definition of broken. Imho if it is not good enough for your next step then it is broken. If you have a bike

RE: Managing Changes

2006-05-30 Thread Steve Brewin
Noel J. Bergman wrote: > > Norman Maurer wrote: > > Noel wrote: > > > Stefano wrote: > > > > We can't take weeks and dozen of messages for each > single commit. > > > > > > Depends upon the nature of the change. Weeks and weeks of active > > > discussion? Might be quite useful. Weeks of silence?

[jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Quande Ren (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413891 ] Quande Ren commented on JAMES-512: -- BTW, The old code also sends three emails to a user when the user is specified in "to", "cc" and "bcc". > OutOfMemoryError -- object not r

james-2.3a4

2006-05-30 Thread Norman Maurer
Hi guys, when we want to release 2.3a4 ? After fixing JAMES-512 ? We should focus now to release it! Any features we miss todo it ? I don't think we need much more.. junit tests etc could be include also later in a 2.3.1 release or something like that. I also not sure if we should release more

[jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Quande Ren (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413889 ] Quande Ren commented on JAMES-512: -- Hi, Bernd, I rollbacked to the original code and made the changes as you indicated, the memery still keeps growing up and not get gc'ed.

Re: Maven2 opinions

2006-05-30 Thread Stefano Bagnara
Noel J. Bergman wrote: Norman Maurer wrote: I think that should be focused when alan complete his work on maven2 sandbox. Cause we can so depend on some reports that maven2 generate. The maven reports are really not particularly interesting to me. Why do you like them? Test coverage report

Re: [jira] Created: (JAMES-514) Add Mailet that support jason for spamfiltering

2006-05-30 Thread Norman Maurer
Uff.. I thought it has a bsd license :-( But yeah i whould like to see such a non ASL mailets repository on sf.net.. It could contain also experimental code. bye Norman Am Dienstag, den 30.05.2006, 19:58 +0200 schrieb Stefano Bagnara: > Jasen distribution is licensed under LGPL: > http://www.j

Re: Maven2 opinions

2006-05-30 Thread Stefano Bagnara
Serge Knystautas wrote: On 5/29/06, Noel J. Bergman <[EMAIL PROTECTED]> wrote: team indicates they don't support. Second, and more importantly, they must handle authentication of signed artificts. Without the latter, I would sooner include the necessary jars, or require the user to download t

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Norman Maurer
Am Dienstag, den 30.05.2006, 20:33 +0200 schrieb Stefano Bagnara: > We're probably misunderstading something. > > Does the "O => i" change fix JAMES-512 ? > Or we need anyway the full removal of the cache?? > > I understood that we need the removal of the cache, but maybe I didn't > understand y

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Norman Maurer
Am Dienstag, den 30.05.2006, 20:18 +0200 schrieb Bernd Fondermann: > Stefano Bagnara wrote: > > > > If you look in the svn history of that file you will see that there was > > much worst bug about this. Maybe this was neven called anyway because > > the streams were always correctly closed by Ja

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Stefano Bagnara
Bernd Fondermann wrote: Stefano Bagnara wrote: Bernd Fondermann (JIRA) wrote: [ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413862 ] Bernd Fondermann commented on JAMES-512: Quande, could you please re-test with this cha

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Stefano Bagnara
We're probably misunderstading something. Does the "O => i" change fix JAMES-512 ? Or we need anyway the full removal of the cache?? I understood that we need the removal of the cache, but maybe I didn't understand your tests. I was under the impression that the leak is only fixed removing th

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Bernd Fondermann
Stefano Bagnara wrote: Bernd Fondermann (JIRA) wrote: [ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413862 ] Bernd Fondermann commented on JAMES-512: Quande, could you please re-test with this change (it's in line 156) a

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Bernd Fondermann
Stefano Bagnara wrote: If you look in the svn history of that file you will see that there was much worst bug about this. Maybe this was neven called anyway because the streams were always correctly closed by James. In fact, currently it gets called. I checked with a debugger and we notice

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Stefano Bagnara
Quande Ren (JIRA) wrote: [ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413823 ] Quande Ren commented on JAMES-512: -- The changes I made causes another problem: When an email is send to a user, if the email specify "to", "cc", and "

[jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Quande Ren (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413823 ] Quande Ren commented on JAMES-512: -- The changes I made causes another problem: When an email is send to a user, if the email specify "to", "cc", and "bcc" to the same user, in

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Stefano Bagnara
Bernd Fondermann (JIRA) wrote: [ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413862 ] Bernd Fondermann commented on JAMES-512: Quande, could you please re-test with this change (it's in line 156) and re-run the profiler? T

Re: [jira] Created: (JAMES-514) Add Mailet that support jason for spamfiltering

2006-05-30 Thread Stefano Bagnara
Jasen distribution is licensed under LGPL: http://www.jasen.org/licence.txt The distinction would be between "work that uses the library" and "work based on the library" and James would use that library, btw I think that probably ASF is very conservative about this and internal rules won't all

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Stefano Bagnara
Yes. If you look in the svn history of that file you will see that there was much worst bug about this. Maybe this was neven called anyway because the streams were always correctly closed by James. Imho, the fact that it is (and has been) so buggy is a +1 to remove it and eventually investig

[jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Bernd Fondermann (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413862 ] Bernd Fondermann commented on JAMES-512: Quande, could you please re-test with this change (it's in line 156) and re-run the profiler? Thanks a lot! > OutOfMemoryError

Re: Maven2 opinions

2006-05-30 Thread Norman Maurer
Am Dienstag, den 30.05.2006, 12:35 -0400 schrieb Serge Knystautas: > On 5/29/06, Noel J. Bergman <[EMAIL PROTECTED]> wrote: > > team indicates they don't support. Second, and more importantly, they must > > handle authentication of signed artificts. Without the latter, I would > > sooner include

svn commit: r410322 - in /james/server/trunk/src/test/org/apache/james/transport: mailets/ matchers/

2006-05-30 Thread norman
Author: norman Date: Tue May 30 10:35:25 2006 New Revision: 410322 URL: http://svn.apache.org/viewvc?rev=410322&view=rev Log: -setRecipient() now use MailAddress[] -Add junit test for HostIs matcher Added: james/server/trunk/src/test/org/apache/james/transport/matchers/HostIsTest.java Modifi

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Norman Maurer
The change you suggested seems logic to me. bye Norman Am Dienstag, den 30.05.2006, 17:07 + schrieb Bernd Fondermann (JIRA): > [ > http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413858 > ] > > Bernd Fondermann commented on JAMES-512: > --

RE: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Norman Maurer
Am Dienstag, den 30.05.2006, 11:24 -0400 schrieb Noel J. Bergman: > Re: http://issues.apache.org/jira/browse/JAMES-512 > > This problem sounds related one we've previously documented, but not > finished fixing. The file-based repositories maintain an in-memory list of > the e-mails, which grows f

[jira] Created: (JAMES-514) Add Mailet that support jason for spamfiltering

2006-05-30 Thread Norman Maurer (JIRA)
Add Mailet that support jason for spamfiltering --- Key: JAMES-514 URL: http://issues.apache.org/jira/browse/JAMES-514 Project: James Type: New Feature Reporter: Norman Maurer Assigned to: Norman Maurer We should c

[jira] Assigned: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Bernd Fondermann (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=all ] Bernd Fondermann reassigned JAMES-512: -- Assign To: Bernd Fondermann > OutOfMemoryError -- object not released. > > > Key: JAMES-512 >

[jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Bernd Fondermann (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413858 ] Bernd Fondermann commented on JAMES-512: shouldn't this for( int i = 0; i < size; i++ ) { IOUtil.shutdownStream( (Ou

[jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Bernd Fondermann (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413847 ] Bernd Fondermann commented on JAMES-512: I can confirm that the suggested change (not caching the Streams) removes this acute memory leak. (there may be other leaks lef

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Stefano Bagnara
1) AvalonMailRepository caches *keys* of messages currently stored. 2) The repository itself is *weak* referenced when used as James inbox: it was hard referenced in James 2.2.0. 2b) see below... 3) The File_Persistent_Stream_Repository currently caches every inputstream and outputstream used

Re: Maven2 opinions

2006-05-30 Thread Serge Knystautas
On 5/29/06, Noel J. Bergman <[EMAIL PROTECTED]> wrote: team indicates they don't support. Second, and more importantly, they must handle authentication of signed artificts. Without the latter, I would sooner include the necessary jars, or require the user to download them directly from a vendor

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Joachim Draeger
Noel J. Bergman schrieb: Re: http://issues.apache.org/jira/browse/JAMES-512 This problem sounds related one we've previously documented, but not finished fixing. The file-based repositories maintain an in-memory list of the e-mails, which grows forever unless you remove messages from it. Th

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Bernd Fondermann
Noel J. Bergman wrote: Re: http://issues.apache.org/jira/browse/JAMES-512 This problem sounds related one we've previously documented, but not finished fixing. The file-based repositories maintain an in-memory list of the e-mails, which grows forever unless you remove messages from it. The in-

Re: Managing Changes

2006-05-30 Thread Bernd Fondermann
Noel J. Bergman wrote: Stefano wrote: maybe I should start working on a branch [instead of trunk] At the moment, I don't think so, but in the bigger question, it depends upon what we are doing. Some of the changes being made are going to push release dates for trunk back further and furthe

RE: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Noel J. Bergman
Re: http://issues.apache.org/jira/browse/JAMES-512 This problem sounds related one we've previously documented, but not finished fixing. The file-based repositories maintain an in-memory list of the e-mails, which grows forever unless you remove messages from it. The in-memory message list is in

RE: Maven2 opinions

2006-05-30 Thread Noel J. Bergman
Norman Maurer wrote: > I think that should be focused when alan complete his work on maven2 > sandbox. Cause we can so depend on some reports that maven2 generate. The maven reports are really not particularly interesting to me. Why do you like them? I had a discussion with someone who has been

RE: Maven2 opinions

2006-05-30 Thread Norman Maurer
Am Dienstag, den 30.05.2006, 09:39 -0400 schrieb Noel J. Bergman: > Norman Maurer wrote: > > > > Maven generated web-sites have generally and historically been > > > hugely bloated. Our entire site is 28MB, of which javadocs > > > are 19MB. > > > Really i always feeled nice with maven site.. >

RE: [jira] Commented: (JAMES-512) OutOfMemoryError -- object notreleased.

2006-05-30 Thread Norman Maurer
I don't attach one.. The patch i meaned was the one that is attached on the jira issue. I think bernd understand what i meaned ;-) bye Norman Am Dienstag, den 30.05.2006, 09:39 -0400 schrieb Noel J. Bergman: > > Can you please use the fixed attached version of the Class > > Please don't attach p

RE: [jira] Commented: (JAMES-512) OutOfMemoryError -- object notreleased.

2006-05-30 Thread Noel J. Bergman
> Can you please use the fixed attached version of the Class Please don't attach patches to e-mail. As you've noticed, they get filtered out by the list server. --- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For

RE: Maven2 opinions

2006-05-30 Thread Noel J. Bergman
Norman Maurer wrote: > > Maven generated web-sites have generally and historically been > > hugely bloated. Our entire site is 28MB, of which javadocs > > are 19MB. > Really i always feeled nice with maven site.. I was chatting with Brett Porter last night, who was saying that Maven 2 is substa

svn commit: r410274 - in /james/server/trunk/src/test/org/apache/james/transport: mailets/ matchers/

2006-05-30 Thread norman
Author: norman Date: Tue May 30 06:20:42 2006 New Revision: 410274 URL: http://svn.apache.org/viewvc?rev=410274&view=rev Log: -Fix typo in license -Add junit test for HasMailAttributeWithValue matcher -Add junit test for HasMailAttributeWithValueRegex matcher Added: james/server/trunk/src/te

svn commit: r410245 - in /james/server/trunk/src/test/org/apache/james: test/mock/mailet/MockMail.java transport/matchers/HasMailAttributeTest.java

2006-05-30 Thread norman
Author: norman Date: Tue May 30 04:37:06 2006 New Revision: 410245 URL: http://svn.apache.org/viewvc?rev=410245&view=rev Log: Add junit test for HasMailAttribute and add the unimplementated methods to MockMail class Added: james/server/trunk/src/test/org/apache/james/transport/matchers/HasM

Re: svn commit: r410236 - in /james/server/trunk/src/test/org/apache/james/transport/matchers: AllTest.java FetchedFromTest.java HasHeaderTest.java

2006-05-30 Thread Norman Maurer
Anyone has problems with adding all this junit tests? I think haven 1000th of tests is btter then no test.. So we can really get sure that all work as espected when making changes.. I also will continue this work without reporting to mailling list and commit if noone has problems with this. bye

svn commit: r410236 - in /james/server/trunk/src/test/org/apache/james/transport/matchers: AllTest.java FetchedFromTest.java HasHeaderTest.java

2006-05-30 Thread norman
Author: norman Date: Tue May 30 03:44:56 2006 New Revision: 410236 URL: http://svn.apache.org/viewvc?rev=410236&view=rev Log: -Add junit test for FetchedFrom matcher -use the right Assert methods Added: james/server/trunk/src/test/org/apache/james/transport/matchers/FetchedFromTest.java Modi

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Norman Maurer
I juts want to get sure that you do it ;-) bye Norman Am Dienstag, den 30.05.2006, 11:54 +0200 schrieb Bernd Fondermann: > Well, sure. But first things first :-) > > I am currently running it against the unpatched 2.3 branch. > Then I'll try the patch against 2.3 and test again. > (I will not tr

[jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Bernd Fondermann (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413797 ] Bernd Fondermann commented on JAMES-512: can reproduce against current branch v2.3 > OutOfMemoryError -- object not released. >

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Bernd Fondermann
Well, sure. But first things first :-) I am currently running it against the unpatched 2.3 branch. Then I'll try the patch against 2.3 and test again. (I will not try a patched 2.2.0, maybe someone else wants to...) I think we have to be careful calling it a fix. The OOM exception might be fix

Re: [jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Norman Maurer
Can you please use the fixed attached version of the Class and run it again against postage ? Thx Norman Am Dienstag, den 30.05.2006, 09:08 + schrieb Bernd Fondermann (JIRA): > [ > http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413788 > ] > > Bernd Fondermann

svn commit: r410228 - in /james/server/trunk/src/test/org/apache/james: test/mock/mailet/MockMatcherConfig.java transport/matchers/AllTest.java

2006-05-30 Thread norman
Author: norman Date: Tue May 30 02:26:45 2006 New Revision: 410228 URL: http://svn.apache.org/viewvc?rev=410228&view=rev Log: Correct a bug in MockMatcherConfig and add junit test for All matcher Added: james/server/trunk/src/test/org/apache/james/transport/matchers/AllTest.java Modified:

[jira] Commented: (JAMES-512) OutOfMemoryError -- object not released.

2006-05-30 Thread Bernd Fondermann (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413788 ] Bernd Fondermann commented on JAMES-512: I can reproduce the bug under James 2.2.0 with the following Postage szenario:

[jira] Assigned: (JAMES-513) Rename AddHeader and AddHeaderHandler

2006-05-30 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-513?page=all ] Norman Maurer reassigned JAMES-513: --- Assign To: Norman Maurer > Rename AddHeader and AddHeaderHandler > - > > Key: JAMES-513 > URL: http:/

[jira] Commented: (JAMES-513) Rename AddHeader and AddHeaderHandler

2006-05-30 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-513?page=comments#action_12413785 ] Norman Maurer commented on JAMES-513: - To clarify my position: +1 to deprecate the AddHeader and add a new Set*Header +0.6 to name it SetMimeHeader +0.4 to name it S

[jira] Commented: (JAMES-513) Rename AddHeader and AddHeaderHandler

2006-05-30 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-513?page=comments#action_12413784 ] Norman Maurer commented on JAMES-513: - Maybe we should rename the AddHeader to SetHeader and add new Method which extend on this named AddHeader. This method should be marke

[jira] Commented: (JAMES-513) Rename AddHeader and AddHeaderHandler

2006-05-30 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-513?page=comments#action_12413783 ] Norman Maurer commented on JAMES-513: - when working on junit test for AddHeaderHandler i notice that the AddHeaderHandler use setHeader(String name, String value); . So it n

[jira] Created: (JAMES-513) Rename AddHeader and AddHeaderHandler

2006-05-30 Thread Norman Maurer (JIRA)
Rename AddHeader and AddHeaderHandler - Key: JAMES-513 URL: http://issues.apache.org/jira/browse/JAMES-513 Project: James Type: Task Reporter: Norman Maurer We should rename AddHeader and AddHeaderHandler to represent the fu

svn commit: r410217 - in /james/server/trunk/src/test/org/apache/james: smtpserver/AddHeaderHandlerTest.java test/mock/mailet/MockMail.java transport/mailets/AddHeaderTest.java transport/matchers/HasH

2006-05-30 Thread norman
Author: norman Date: Tue May 30 01:31:53 2006 New Revision: 410217 URL: http://svn.apache.org/viewvc?rev=410217&view=rev Log: Add MockMail class and use this class if a mocked Mail object is needed Added: james/server/trunk/src/test/org/apache/james/test/mock/mailet/MockMail.java Modified:

RE: Maven2 opinions

2006-05-30 Thread Norman Maurer
Am Montag, den 29.05.2006, 14:55 -0400 schrieb Noel J. Bergman: > I don't believe that we need Maven 2. But I am willing to see what effect > it would have on our build systems. Fortunately, Maven and Ant build > structures can exist simultaneously, so we can add Maven and see how we all > like t

RE: Managing Changes

2006-05-30 Thread Norman Maurer
Am Montag, den 29.05.2006, 14:55 -0400 schrieb Noel J. Bergman: > people can see the changes as they happen. The fetchmail > code might have been a good example of when to use a branch, since it > was > relatively isolated, and would have been easy to merge in afterwards. > Steve > wasn't saying t