Re: ACL support plans

2012-04-18 Thread Eric Charles
Hi gazda, I updated and tested trunk. It works fine so far with the minimal scenarii I have run. FetchGroupImpl and PartContentDescriptorImpl have now a nice home in mailbox project. It's about queries and content after all, so not pure imap. So (1), (2) and (3) are done (4) let's leave

Re: ACL support plans

2012-04-18 Thread Eric Charles
Hi gazda, I updated and tested trunk. It works fine so far with the minimal scenarii I have run. FetchGroupImpl and PartContentDescriptorImpl have now a nice home in mailbox project. It's about queries and content after all, so not pure imap. Great work! So (1), (2) and (3) are done (4)

Re: ACL support plans

2012-04-17 Thread Jochen Gazda
Eric, In my wokspace, I have: (1) changed the pom's in that way that that the protocols-imap code is used instead of apache-james-imap. (2) merged apache-james-imap classes and tests into protocols-imap classes and tests. (3) moved FetchGroupImpl and PartContentDescriptorImpl from

Re: ACL support plans

2012-04-17 Thread Eric Charles
Hi Gazda, Thx for sharing the information. (1) and (2) are OK to me, I guess you had fun to find (3) :) (I guess to allow to avoid a dependency between james-server-mailets protocols-api?). Yes, just commit (we do CTR commit then review) assuming you have tested a complete build (app) with

Re: ACL support plans

2012-04-17 Thread Eric Charles
PS: Also take care to keep the SVN history when moving classes between projects (I use eclipse which does a decent job for that, but I always pay double attention doing those kind of operations). On 04/17/2012 05:09 PM, Eric Charles wrote: Hi Gazda, Thx for sharing the information. (1)

Re: ACL support plans

2012-04-17 Thread Jochen Gazda
Commited. Further points to consider before closing PROTOCOLS-73 : (4) How will we make the apache-james-imap code obsolete? Do we want to delete it altogether? Or just annotate somehow? (5) There is some site code under the following directories which does not seem to have any counterpart

Re: ACL support plans

2012-03-16 Thread Jochen Gazda
Eric, I just wanted to merge the ACL code from apache-james-imap to protocols-imap, but I am still seeing the default build run to use the apache-james-imap code. Is there some simple way how I could tell James to switch to the protocols-imap code? Thank you, gazda On Fri, Mar 9, 2012 at 2:14

Re: ACL support plans

2012-03-16 Thread Eric Charles
Hi Gazda, You have to remove in the server's project pom all references to apache-james-imap-* and replace them by the unique protocols-imap (same in app). Doing this, you will have a few compilation failures that should be easily solved by changing the package imports. You can commit for

Re: ACL support plans

2012-03-09 Thread Jochen Gazda
Gentlemen, just reposting my old questions. I would like to proceed with https://issues.apache.org/jira/browse/IMAP-358 Enforce rights required to perform different IMAP4rev1 Commands in IMAP processors. (1) Is there something new with protocols-imap vs. apache-james-imap? (2) Tests: Is there a

Re: ACL support plans

2012-03-09 Thread Eric Charles
Hi Gazda, First of all, thx for pushing this! (1) I would love to see the current activity in protocols-imap. I had to postpone my contribution on the integration (b4 release and many other stuff), but next week should be a good week for me to work on this. I propose you continue your

Re: ACL support plans

2012-03-09 Thread Jochen Gazda
Eric, please see inline. (1) I would love to see the current activity in protocols-imap. I had to postpone my contribution on the integration (b4 release and many other stuff), but next week should be a good week for me to work on this. I propose you continue your implementations in

Re: ACL support plans

2012-03-09 Thread Eric Charles
(snip) I have not started yet. I will have a look at the diffs between protocols-imap and apache-james-imap in the next days and backport all the necessary stuff. Cool! (2) Your tests use mocks and no concrete processor, I think this is the good way to do the unit tests in this case.

Re: ACL support plans

2012-02-22 Thread Eric Charles
Hi, Quick note (no time atm for an answer on your questions, and your planning one is quite dangerous :) : Norman has started the imap port into protocols, and I may next week help with that - the server b4 release (end of next week) will be with apache-james-imap, but the next one with

ACL support plans

2012-02-21 Thread Jochen Gazda
Gentlemen, In the next weeks, I would like to proceed with https://issues.apache.org/jira/browse/IMAP-358 Enforce rights required to perform different IMAP4rev1 Commands in IMAP processors. Just two questions: (1) Is it still OK if I further work under apache-james-imap and not under