Re: IMAP FETCH management

2024-03-22 Thread Benoit TELLIER
Hello all. The streaming approach turned out to be a terrible idea! ChunkStream was doing massive blocking reads on the event loop. InputStream is just not the right abstraction for non blocking reads. Rewriting everything to support something like Flux looks doable but requires a major refa

Re: IMAP FETCH management

2024-03-20 Thread Benoit TELLIER
Hello all, Today I did put together a POC where the following IMAP command     a0 FETCH 1:* (BODY[]) would directly stream content from the S3 storage without storing the full input in a byte array. I did test it a bit manually on top of the S3 AES implementation. Link: https://github.com/a

Re: IMAP and SMTP "Heartbeat" Tests?

2021-09-19 Thread Tung Tran Van
Hello Jerry, Did you use guice health checks? https://james.staged.apache.org/james-project/3.7.0/servers/distributed/operate/webadmin.html#_healthcheck We already have health checks: - Correct application startup - For backend components - For functionalities like email reception. The framewo

Re: IMAP Fetch behavior on not found messages

2021-01-12 Thread Matthieu Baechler
On Tue, 2021-01-12 at 12:42 +0100, Jean Helou wrote: > > > When doing a fetch with some > non existing messages Cyrus will do a best effort and return the > existing messages whereas James will return a BAD response. I would preserve Cyrus's behavior as a defacto standard, not honoring this inc

Re: IMAP Fetch behavior on not found messages

2021-01-12 Thread Jean Helou
> > > When doing a fetch with some > non existing messages Cyrus will do a best effort and return the > existing messages whereas James will return a BAD response. I would preserve Cyrus's behavior as a defacto standard, not honoring this incurs the risk of breaking existing client software which

Re: IMAP Fetch behavior on not found messages

2021-01-12 Thread Jean Helou
> > The discussion can be found here: > https://github.com/linagora/gatling-imap/pull/3 > actually it's here https://github.com/linagora/gatling-imap/pull/37 I think the url got truncated :)

Re: IMAP mailbox error

2016-03-09 Thread Benoit Tellier
Hi Simon, I reproduced your problem by running some integration tests on a distant James server... I did not succeed yet to write unit tests reproducing your problem... I will open a JIRA issue for this. I will also look why this was not covered by MPT tests... And try to find the change-set th

Re: IMAP mailbox error

2016-03-09 Thread Matthieu Baechler
Ok, thank you very much for your effort at describing what you did. We'll have a look. -- Matthieu On 09/03/2016 18:32, Simon Roth wrote: Yes, I built from git master. I'm trying to setup the server on a remote VM. Therefore I copied the generated james-server-app-3.0.0-beta5-SNAPSHOT-app.tar.g

Re: IMAP mailbox error

2016-03-09 Thread Simon Roth
Yes, I built from git master. I'm trying to setup the server on a remote VM. Therefore I copied the generated james-server-app-3.0.0-beta5-SNAPSHOT-app.tar.gz file from my local PC to the VM, extracted it there, replaced the conf folder from the extracted folder with the conf folder in do

Re: IMAP mailbox error

2016-03-09 Thread Matthieu Baechler
Hi Simon, Do you mean you are building from git master ? If so, could you describe your usecase with more details ? What do you mean by "receive en email via IMAP" ? Cheers, -- Matthieu On 09/03/2016 17:45, Simon Roth wrote: I'm trying to setup a James Server built from trunk. Except the p

RE: IMAP and SSL

2015-12-08 Thread roy . james
Hey guys, I think I would like to put in a bug for the behavior I found below? On Fri, Dec 4, 2015 at 11:10 AM, wrote: Thank I found the issue. For certain instances our Message.getBodyContent or getFullContent may return a FileInputStream. In ChannelImapResponseWriter.write if the InputStrea

RE: IMAP and SSL

2015-12-08 Thread roy . james
Hey guys, I think I would like to put in a bug for the behavior I found below? On Fri, Dec 4, 2015 at 11:10 AM, wrote: Thank I found the issue. For certain instances our Message.getBodyContent or getFullContent may return a FileInputStream. In ChannelImapResponseWriter.write if the InputStrea

RE: IMAP and SSL

2015-12-04 Thread roy . james
Thank I found the issue. For certain instances our Message.getBodyContent or getFullContent may return a FileInputStream. In ChannelImapResponseWriter.write if the InputStream of the passed in Literal is instanceof FileInputStream a ChunkedNioFile gets used instead of DefaultFileRegion or Chunk

RE: IMAP and SSL

2015-12-04 Thread roy . james
Thank I found the issue. For certain instances our Message.getBodyContent or getFullContent may return a FileInputStream. In ChannelImapResponseWriter.write if the InputStream of the passed in Literal is instanceof FileInputStream a ChunkedNioFile gets used instead of DefaultFileRegion or Chunk

RE: IMAP and SSL

2015-12-03 Thread roy . james
Hey guys, So I've been looking at the James source code and I still can't figure out what we are doing wrong. If I'm understanding the code correctly outside of the Netty ChannelPipeline having the SslHanndler added to it there are literally no differences in how IMAP commands get handled. Thi

RE: IMAP and SSL

2015-12-03 Thread roy . james
Hey guys, So I've been looking at the James source code and I still can't figure out what we are doing wrong. If I'm understanding the code correctly outside of the Netty ChannelPipeline having the SslHanndler added to it there are literally no differences in how IMAP commands get handled. Thi

Re: IMAP and SSL

2015-12-02 Thread roy . james
Hey guys, So I've been looking at the James source code and I still can't figure out what we are doing wrong. If I'm understanding the code correctly outside of the Netty ChannelPipeline having the SslHanndler added to it there are literally no differences in how IMAP commands get handled. This c

Re: IMAP: multiple literal arguments not working?

2015-10-12 Thread Torstein Tauno Svendsen
On 09. okt. 2015 21:32, Torstein Tauno Svendsen wrote: Hi! I tried using James (3.0.0-beta5-SNAPSHOT) behind a perdition proxy (http://horms.net/projects/perdition/), and noted that this makes IMAP login-requests hang. Seems that when peridtion forwards the "LOGIN" request request it ends up se

Re: IMAP Library question

2015-02-28 Thread Eric Charles
(late reply...) you can use James IMAP as standalone library http://james.apache.org/protocols/imap4.html https://svn.apache.org/repos/asf/james/protocols/trunk/imap/ On 12/04/2014 12:15 PM, David Salvador wrote: > Hello everyone, > > I need to develop a Storage Server that uses IMAP as communica

Re: IMAP: SelectedMailboxImpl performance

2013-07-31 Thread Eric Charles
(see inline) On 07/31/2013 03:37 PM, Jan-Philipp Niewerth | invencom wrote: Dear imap developers, we are using James 3 trunk in production for several weeks now. Great work! The impression we got is that is already very stable at least in our use case. My personal mailbox is also running on tha

Re: IMAP-folder jumps

2012-02-22 Thread l0c4l h0st
Hi, I just posted some more information to the JIRA. On Thu, Feb 9, 2012 at 7:53 PM, Eric Charles wrote: > Hi, > > Which version are you using? > > I didn't have that before with James. > > Now (since a few weeks), it's true that I can have that behavior, but the > messages are consistent: I mean

Re: IMAP-folder jumps

2012-02-10 Thread l0c4l h0st
Created IMAP-360. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org

Re: IMAP-folder jumps

2012-02-09 Thread Eric Charles
Hi, Which version are you using? I didn't have that before with James. Now (since a few weeks), it's true that I can have that behavior, but the messages are consistent: I mean, the newly seen messages are just new ones. This is done thx the IDLE function that we support and also the streami

Re: Imap status

2011-06-12 Thread Robert Burrell Donkin
On Sun, Jun 12, 2011 at 8:53 AM, Ioan Eugen Stan wrote: > 2011/6/11 Eric Charles : >> 0.2.x, of course :) >> I will add a table on the imap web site with the supported extension per >> version. >> >> Sure, we can rely for now on dovecot testsuite. For the "how to test", we >> can simply link for n

Re: Imap status

2011-06-12 Thread Ioan Eugen Stan
2011/6/11 Eric Charles : > 0.2.x, of course :) > I will add a table on the imap web site with the supported extension per > version. > > Sure, we can rely for now on dovecot testsuite. For the "how to test", we > can simply link for now to http://www.imapwiki.org/ImapTest > In the long run, mailbox

Re: Imap status

2011-06-11 Thread Norman Maurer
Thats right. I included the not yet released imap version in the beta to speed up things. thats why I said that we first need to release the imap version . bye Norman Am Sonntag, 12. Juni 2011 schrieb Eric Charles : > Hi, > > I'm a bit lost... > > The vote for imap-0.2.1 is open wich is

Re: Imap status

2011-06-11 Thread Eric Charles
Hi, I'm a bit lost... The vote for imap-0.2.1 is open wich is coherent with [1] (only 0.2 is release) However, the beta1 proposal (I'm running fine now btw) refers and contains a imap-0.2.1 which is not yet released. I must miss something... Tks, - Eric [1] https://repository.apache.org/

Re: Imap status

2011-06-11 Thread Eric Charles
0.2.x, of course :) I will add a table on the imap web site with the supported extension per version. Sure, we can rely for now on dovecot testsuite. For the "how to test", we can simply link for now to http://www.imapwiki.org/ImapTest In the long run, mailbox-integration-tests could be enhan

Re: Imap status

2011-06-11 Thread Norman Maurer
Hi there, first of its 0.2 and 0.2.1 ;) For the rest see inside Am Samstag, 11. Juni 2011 schrieb Eric Charles : > Hi, > > This weekend, I will test server-beta1 (ok so far), imap-2.0.1 and will > update documentation for the releases. > > Is the following correct (Norman was so fast I could

Re: [IMAP] Release Apache James IMAP 0.2.1 ?

2011-06-09 Thread Norman Maurer
Hi there, sorry this is the correct link of changes: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+IMAP+AND+fixVersion+%3D+%220.2.1%22+AND+status+%3D+Resolved+ORDER+BY+priority+DESC&mode=hide Bye, Norman 2011/6/9 Norman Maurer : > Hi there, > > for t

Re: [IMAP] Release Apache James IMAP 0.2.1 ?

2011-06-09 Thread Robert Burrell Donkin
On Thu, Jun 9, 2011 at 10:27 AM, Norman Maurer wrote: >> Release early, release often :-) >> >> Let IMAP 0.3 roll... >> >> Robert > > Just a minor note... I think I will call it 0.2.1 as it needs not API > changes etc. If numbering strategy isn't document, now is probably a good time ;-) Robe

Re: [IMAP] Release Apache James IMAP 0.2.1 ?

2011-06-09 Thread Norman Maurer
Am 09.06.2011 11:13, schrieb Robert Burrell Donkin: On Thu, Jun 9, 2011 at 8:19 AM, Norman Maurer wrote: Hi there, for the next new imap-extensions I plan to write, we need to depend on current mailbox trunk. So we will need to make a new mailbox release before we can release imap later then.

Re: [IMAP] Release Apache James IMAP 0.2.1 ?

2011-06-09 Thread Robert Burrell Donkin
On Thu, Jun 9, 2011 at 8:19 AM, Norman Maurer wrote: > Hi there, > > for the next new imap-extensions I plan to write, we need to depend on > current mailbox trunk. So we will need to make a new mailbox release before > we can release imap later then. > > The current imap-trunk has already a one b

Re: [IMAP] Why parent pom.xml?

2011-02-24 Thread Norman
Hi there, I think have the "extra" parent/pom.xml is a left-over. I think we could move it to the "root pom" without any problems.. Bye, Norman Am 24.02.2011 12:42, schrieb Eric Charles: About the parent poms: 1.- some projects use the root/pom.xml as parent (james server project does that)

Re: [IMAP] Why parent pom.xml?

2011-02-24 Thread Eric Charles
About the parent poms: 1.- some projects use the root/pom.xml as parent (james server project does that) 2. others create a root/parent/pom.xml specific project. I was in favor of the first, now I use the second as default, maybe tomorrow I will use the first again. I looked at your patch w

Re: [IMAP] Why parent pom.xml?

2011-02-24 Thread Felix Knecht
Hi Eric The idea of parent is to have some basic/common definition in it, and let the childs heritate from these (a bit like java classes). This is the way maven works, and james simply uses this feature. I agree. For example, all imap modules have a parent which is located in imap/parent. T

Re: [IMAP] Why parent pom.xml?

2011-02-24 Thread Eric Charles
Hi Felix, The idea of parent is to have some basic/common definition in it, and let the childs heritate from these (a bit like java classes). This is the way maven works, and james simply uses this feature. For example, all imap modules have a parent which is located in imap/parent. This imap/

Re: [IMAP] Why parent pom.xml?

2011-02-23 Thread Felix Knecht
Sorry for reposting, but I thought it got lost somewhere on the way as I haven't seen it after hours ... On 02/24/2011 06:53 AM, Felix Knecht wrote: Hi all Trying to get the module sites generated I'm getting a little bit confused about the usage of pom files. I can't see the need of the modul

Re: IMAP Search and lucene

2011-02-16 Thread Norman Maurer
Good point so maybe upgrading to 2.3 is the way to go for now.. if 2.3 is not ready when we are ready we can just "remove" the shipped jackrabbit. Bye, Norman 2011/2/16 agks mehx : > yes, if we are ready for 3.0 GA but jackrabbit 2.3 is not, we can all > moonlight on jackrabbit code and get it t

Re: IMAP Search and lucene

2011-02-16 Thread agks mehx
yes, if we are ready for 3.0 GA but jackrabbit 2.3 is not, we can all moonlight on jackrabbit code and get it to GA ;-) On Tue, Feb 15, 2011 at 11:44 PM, Eric Charles wrote: > Hi, > > Jackrabbit 2.2.0 has just been released in December 2010. > It may still take time for 2.3.0. > > In the meantim

Re: IMAP Search and lucene

2011-02-16 Thread Eric Charles
Hi, Jackrabbit 2.2.0 has just been released in December 2010. It may still take time for 2.3.0. In the meantime, we can release james milestones with jackrabbit snapshots. JCR-2415 is fixed, and jackrabbit pom parent states lucene 3.0.3. (https://svn.apache.org/repos/asf/jackrabbit/trunk/jackrab

Re: IMAP Search and lucene

2011-02-15 Thread agks mehx
switch to jackrabbit 2.3?? but of course i don't know what are the implications, so this is just a suggestion if it is only a little bit of work On Tue, Feb 15, 2011 at 8:16 AM, Norman Maurer wrote: > Forgot to say that jackrabbit 2.3 will using lucene 3.x. > > See https://issues.apache.org/jir

Re: IMAP Search and lucene

2011-02-15 Thread Norman Maurer
Forgot to say that jackrabbit 2.3 will using lucene 3.x. See https://issues.apache.org/jira/browse/JCR-2415 Bye, Norman 2011/2/15 Norman Maurer : > Hi there, > > I worked on some lucene based solution to provide some high > performance Message search which is needed for IMAP SEARCH command. So >

Re: IMAP does NOT work here

2011-02-03 Thread Barry
on't understand chinese, I will test it on the future fix. >> >> It is very happy to hear about that outlook-office is ok. >> >> Thanks, >> Barry >> >> 2011-02-03 >> >> >> >> Barry Bai >> >> >> >> 发件人: Eric

Re: IMAP does NOT work here

2011-02-03 Thread Norman
> 2011-02-03 > > > > Barry Bai > > > > 发件人: Eric Charles > 发送时间: 2011-02-03 16:29:29 > 收件人: James Developers List > 抄送: > 主题: Re: IMAP does NOT work here > > Hi Barry, > We reproduced it with trunk: see > https://issues.apache.org/jir

Re: Re: IMAP does NOT work here

2011-02-03 Thread Barry Bai
t is correct user, because I just created one user in James. >>> I can read mails correctly via pop3, but imap is not working. I am >>> confusing about this. >>> >>> Thanks for your reply. >>> Barry >>> >>> 2011-02-02 >>>

Re: IMAP does NOT work here

2011-02-03 Thread Eric Charles
just created one user in James. >>> I can read mails correctly via pop3, but imap is not working. I am >>> confusing about this. >>> >>> Thanks for your reply. >>> Barry >>> >>> 2011-02-02 >>> >>> >>> >>

Re: Re: IMAP does NOT work here

2011-02-02 Thread Norman Maurer
Thanks for your reply. >> Barry >> >> 2011-02-02 >> >> >> >> Barry Bai >> >> >> >> 发件人: Eric Charles >> 发送时间: 2011-02-02 15:21:27 >> 收件人: James Developers List >> 抄送: >> 主题: Re: IMAP does NOT work here >> >

Re: Re: IMAP does NOT work here

2011-02-01 Thread Norman Maurer
ot working. I am confusing > about this. > > Thanks for your reply. > Barry > > 2011-02-02 > > > > Barry Bai > > > > 发件人: Eric Charles > 发送时间: 2011-02-02 15:21:27 > 收件人: James Developers List > 抄送: > 主题: Re: IMAP does NOT work here > > Hi, >

Re: Re: IMAP does NOT work here

2011-02-01 Thread Barry Bai
List 抄送: 主题: Re: IMAP does NOT work here Hi, Are you sending to the correct user ? Can you read the mail via pop3 ? Tks - Eric On 2/02/2011 07:28, Barry Bai wrote: > Hi Norman, I have already increased the log level to DEBUG, and the log > content as below: > INFO 14:

Re: IMAP does NOT work here

2011-02-01 Thread Eric Charles
ers List 抄送: 主题: Re: IMAP does NOT work here Hi Barry, what exact version are you using ? Could you increase the logging level to debug in conf/log4j.properties and paste the log content of imapserver.log ? Thx, Norman 2011/2/2 Barry Bai: Hi, I meet a problem that is IMAP does not work correctly an

Re: Re: IMAP does NOT work here

2011-02-01 Thread Barry Bai
ly build james-server-container-spring-3.0-M3-20110202.005511-329-bin.zip. Thanks, Barry 2011-02-02 Barry Bai 发件人: Norman Maurer 发送时间: 2011-02-02 13:52:45 收件人: James Developers List 抄送: 主题: Re: IMAP does NOT work here Hi Barry, what exact version are you using ? Could you incre

Re: IMAP does NOT work here

2011-02-01 Thread Norman Maurer
Hi Barry, what exact version are you using ? Could you increase the logging level to debug in conf/log4j.properties and paste the log content of imapserver.log ? Thx, Norman 2011/2/2 Barry Bai : > Hi, I meet a problem that is IMAP does not work correctly and can't receive > any mail. I can onl

Re: IMAP - Implementing IDLE

2010-12-15 Thread Norman Maurer
Just interested is it this one : http://tools.ietf.org/html/rfc2177 ? Bye, Norman 2010/12/15 Norman Maurer : > Hi Niklas, > > nice to see you got involved in the IMAP code :). In JAMES we follow > the CTR princip, so as you already have write access I think you > should just go ahead and commi

Re: IMAP - Implementing IDLE

2010-12-15 Thread Norman Maurer
Hi Niklas, nice to see you got involved in the IMAP code :). In JAMES we follow the CTR princip, so as you already have write access I think you should just go ahead and commit it. After that just drop an email to the ML. I would be very happy to review your code.. Thx, Norman 2010/12/15 Nikla

Re: IMAP Fetch OOM [WAS: Re: ActiveMQ the cause?]

2010-10-15 Thread Norman Maurer
Thx for the feedback.. I will prepare for M1 then! Bye, Norman 2010/10/15 Eric Charles : > Hi there, > > Today is an excellent step towards a more performant imap channel. > With Norman's last commit, i re-stressed and analyzed the memory dumps (with > eclipse mat), and everything is fine now: v

Re: IMAP Fetch OOM [WAS: Re: ActiveMQ the cause?]

2010-10-15 Thread Eric Charles
Hi there, Today is an excellent step towards a more performant imap channel. With Norman's last commit, i re-stressed and analyzed the memory dumps (with eclipse mat), and everything is fine now: very low memory consumption per mailbox session. The "leaking" listeners (when other mailbox wher

Re: IMAP Fetch OOM [WAS: Re: ActiveMQ the cause?]

2010-10-14 Thread Eric Charles
Total Retained Heap: 341.033.584 where top is OpenJPAMailboxManager: 266.079.320 which references 266.068.064 of DelegatingMailboxListeners. In DelegatingMailboxListerners, there is the MapList> listeners. I can see there the 25 map entries, where - first one is 105.017.544 - second one is 71

Re: IMAP Fetch OOM [WAS: Re: ActiveMQ the cause?]

2010-10-14 Thread Norman
Hi Eric, how big was the memory usage of the Map which holds the MailboxPath ? Just to get an idea if we need to improve it. Bye, Norman Am 14.10.2010 13:35, schrieb Eric Charles: Hi Norman, Yes, it solved oom atm. I was not able to reproduce it while fetching mails from 2 clients. Howeve

Re: IMAP Fetch OOM [WAS: Re: ActiveMQ the cause?]

2010-10-14 Thread Eric Charles
Hi Norman, Yes, it solved oom atm. I was not able to reproduce it while fetching mails from 2 clients. However, I saw very fast fetching at start, slowing down at the end. So, I fear that launching many clients in // to my mailbox would still slow it, and probably give oom (but it's true that I

Re: IMAP Fetch OOM [WAS: Re: ActiveMQ the cause?]

2010-10-14 Thread Norman
Hi Eric, so the patch solves the OOM for you ? Did you have a look at the heap (via jconsole;) ) while do the action ? Would be interesting to see how the GC kicks in.. And yes I think we can have it in M1 ;) Bye Norman Am 14.10.2010 12:10, schrieb Eric Charles: Hi Norman, I tested with

Re: IMAP Fetch OOM [WAS: Re: ActiveMQ the cause?]

2010-10-14 Thread Eric Charles
Hi Norman, I tested with the patch you sent me off-ml, and it rebuilding index on a large index goes 10 ways faster :) I still didn't succeed to get the oom synchronizing. Do you think we could have this patch in the coming imap 0.2-M1 release? For later releases, we could still talk about wa

Re: IMAP Fetch OOM [WAS: Re: ActiveMQ the cause?]

2010-10-12 Thread Eric Charles
- read "raw mail" instead of "raw content" - to have added value, "streaming from store to socket via listener" goes with "store raw mail". On 12/10/2010 10:10, Eric Charles wrote: Hi Norman, Yes, Iterator getMessages(MessageRange set, ...) is really the place where we have to act to reduc

Re: IMAP Fetch OOM [WAS: Re: ActiveMQ the cause?]

2010-10-12 Thread Eric Charles
Hi Norman, Yes, Iterator getMessages(MessageRange set, ...) is really the place where we have to act to reduce the memory consumption. I also though about some ways to better scale. I didn't really think to a batch way, but this can help, even if we will have to go to the repository (databas

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-22 Thread Norman Maurer
Comments inline.. 2010/8/22 Eric Charles : >  one more inline :) > > On 22/08/2010 13:58, Norman Maurer wrote: >> >> Not 100%.. Subscriptions links users to Mailboxes. The users are just >> Strings and nothing more. So its not coupled to james server in any >> way. >> > Yeah, these are "soft links

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-22 Thread Eric Charles
one more inline :) On 22/08/2010 13:58, Norman Maurer wrote: Not 100%.. Subscriptions links users to Mailboxes. The users are just Strings and nothing more. So its not coupled to james server in any way. Yeah, these are "soft links". A "Subscription store" could be different from the "Mailbox

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-22 Thread Norman Maurer
Hi, comments inline again ;) 2010/8/22 Eric Charles : >  See comments after. > Eric > > On 22/08/2010 10:12, Norman Maurer wrote: >>> >>> Which means, not only merge the SubscriptionManager into the >>> MailboxManager like you did, but also the SubscriptionMapper into the >>> MailboxMapper. That

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-22 Thread Eric Charles
See comments after. Eric On 22/08/2010 10:12, Norman Maurer wrote: Which means, not only merge the SubscriptionManager into the MailboxManager like you did, but also the SubscriptionMapper into the MailboxMapper. That would make the separation between .user and .mail superfluous. Does that mak

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-22 Thread Norman Maurer
Hi Eric.. 2010/8/22 Eric Charles : >  Hi, > > So Tim, you was also ok with optin 2 and finally Norman reverted to option 1 > ? (not sure to be in line :) ?) > Seems so.. > I've looked at revision 987821: > - SubscriptionManager is not used anymore in MailboxManager hirerachy > (StoreMailboxMana

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-22 Thread Norman Maurer
Hi Tim, 2010/8/21 Tim-Christian Mundt : > Norman, > > I have not yet reviewed your recent commit. However, I'd like to remark > that I was in favor of your last attempt. I just wanted to > _additionally_: ok :) > >> >>> I think we should also merge them which >> >>> would also simplify the pack

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-22 Thread Eric Charles
Back again. In DefaultProcessorChain, we know have createDefaultChain(chainEndProcessor, mailboxManager, subscriptionManager, statusResponseFactory) so mailbox and subscription can be seen on the same level, each playing role in the different processors. There are now 3 options: 1.- composit

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-21 Thread Eric Charles
Hi, So Tim, you was also ok with optin 2 and finally Norman reverted to option 1 ? (not sure to be in line :) ?) I've looked at revision 987821: - SubscriptionManager is not used anymore in MailboxManager hirerachy (StoreMailboxManager,...) - The 3 delegate methods present in DelegatingMailb

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-21 Thread Tim-Christian Mundt
Norman, I have not yet reviewed your recent commit. However, I'd like to remark that I was in favor of your last attempt. I just wanted to _additionally_: > >>> I think we should also merge them which > >>> would also simplify the package structure because we wouldn't need > >>> the .mail and .us

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-21 Thread Norman Maurer
Ok another attempt was made.. please review changes made in revision 987821 Thx, Norman 2010/8/21 Norman Maurer : > Well I need to revert it ;) I will do so then.. > > Bye, > Norman > > > 2010/8/21 Norman Maurer : >> Hi Tim, >> >> comments inside.. >> >> 2010/8/21 Tim-Christian Mundt : >>> Norman

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-21 Thread Norman Maurer
Well I need to revert it ;) I will do so then.. Bye, Norman 2010/8/21 Norman Maurer : > Hi Tim, > > comments inside.. > > 2010/8/21 Tim-Christian Mundt : >> Norman, >> >> you are right in that it was kinda double, so there should be some >> cleanup. My first attempt would have been to remove the

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-21 Thread Norman Maurer
Hi Tim, comments inside.. 2010/8/21 Tim-Christian Mundt : > Norman, > > you are right in that it was kinda double, so there should be some > cleanup. My first attempt would have been to remove the subscription > stuff from the MailboxManager (your option #1). The reason is that we > always have a

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-21 Thread Tim-Christian Mundt
Norman, you are right in that it was kinda double, so there should be some cleanup. My first attempt would have been to remove the subscription stuff from the MailboxManager (your option #1). The reason is that we always have a manager and its respective mapper. Now we have the MailboxManager with

Re: [IMAP] Remove org.apache.james.imap.store.Subscriper

2010-08-21 Thread Norman Maurer
I just committed the changes.. If anyone thinks its a bad idea we can revert it anyway.. https://issues.apache.org/jira/browse/IMAP-205 Bye, Norman 2010/8/21 Norman Maurer : > Hi there, > > after looking again at the IMAP api I'm in favor of removing the > org.apache.james.imap.store.Subscriper

Re: [IMAP] store api changes

2010-08-20 Thread Norman Maurer
Ok so its seems like you like the proposal_v3 so far (just minor naming changes etc). I will commit it then and try to improve the javadocs a bit etc.. Thx for the review.. Bye, Norman 2010/8/20 Eric Charles : > Hi All, > Comments inside. > Tks, > Eric > > On 08/20/2010 04:53 PM, Tim-Christian M

Re: [IMAP] store api changes

2010-08-20 Thread Eric Charles
Hi All, Comments inside. Tks, Eric On 08/20/2010 04:53 PM, Tim-Christian Mundt wrote: Hi guys, I began looking into the API stuff. I'd like to simplify the Mapper hierarchy, which however will have no direct impact on the API. Will upload a patch tomorrow. Will look at it :) I agree, we shou

Re: [IMAP] store api changes

2010-08-20 Thread Tim-Christian Mundt
Hi guys, I began looking into the API stuff. I'd like to simplify the Mapper hierarchy, which however will have no direct impact on the API. Will upload a patch tomorrow. I agree, we should name the interface MessageManager, that's what I thought. The "proposal_v3" is reasonable, I think. To mak

Re: [IMAP] store api changes

2010-08-20 Thread Eric Charles
Hi Norman, The following hierarchy is obvious and gives services such as create, login, logout, search on *mailboxes*: MailboxManager (interface) /|\ | DelegatingMailboxManagerimpl (abstract) /|\ | StoreMailboxManager (abstract)

Re: [IMAP] store api changes

2010-08-20 Thread Norman Maurer
Comments inline.. 2010/8/20 Eric Charles : >  OK > So AbstractStoreMessageManager doesn't implement MessageMapper (and it was > in your javadoc :) > ... and implements Mailbox (the org.apache.james.imap.mailbox.Mailbox, not > the org.apache.james.imap.store.mail.model.Mailbox...) > yep .. > The

Re: [IMAP] store api changes

2010-08-20 Thread Eric Charles
OK So AbstractStoreMessageManager doesn't implement MessageMapper (and it was in your javadoc :) ... and implements Mailbox (the org.apache.james.imap.mailbox.Mailbox, not the org.apache.james.imap.store.mail.model.Mailbox...) The org.apache.james.imap.mailbox.Mailbox has much too do with Ma

Re: [IMAP] store api changes

2010-08-19 Thread Norman Maurer
Let me try to explain it The idea is to let the MessageMapper untouched, because its API is really easy to understand and use. Its not the most Performant todo but thats the price to pay. So I introduced a new abstract class which can be used if you want to write a custom store which is not f

Re: [IMAP] store api changes

2010-08-19 Thread Eric Charles
Hi Norman, I applied the last uploaded file (proposal_v3.diff): - patch works, which is good :) - I don't see any change on MessageMapper. Probably the modif to return only uid was already committed (IMAP-203,...) ? - You migrated methods from StoreMessageManager to AbstractMessageMapper. S

Re: [IMAP] store api changes

2010-08-19 Thread Norman Maurer
Hi, just added another diff to the issue which show an other attemp to make the api more flexible. I think I like it more then the first one.. please review ;) Bye, Norman 2010/8/19 Norman Maurer : > Hi there, > > I' currently looking for ways to make it easier to create high > performant Mailbo

Re: [IMAP] Projects' structure

2010-08-19 Thread Norman Maurer
Comments inline... 2010/8/19 Eric Charles : >  Hi Everybody > > After splitting the tests from functional to their store projects > (IMAP-187), we could centralize the test infrastructure present in different > projects: > - apache-james-imap-deployment > - apache-james-imap-protocol-tester > All

Re: [IMAP] Proposed store api change (NEXTUID)

2010-08-19 Thread Norman Maurer
I just think we should not force the uidnext to match the next uid of the insert message.. thats all ;) Bye, Norman 2010/8/17 Eric Charles : >  So, kind-of "let the store create the uid (range) and use it as nextuid" > > In current impl, each mail persistence reads in a locking transaction the >

Re: [IMAP] Proposed store api change (NEXTUID)

2010-08-17 Thread Eric Charles
So, kind-of "let the store create the uid (range) and use it as nextuid" In current impl, each mail persistence reads in a locking transaction the persisted "lastUid" (for jpa), consumes it (+1) and re-persists it. Each incoming mail queues for this thanks to the locking transaction, giving pe

Re: [IMAP] Proposed store api change (NEXTUID)

2010-08-17 Thread Norman Maurer
Well, I think its not the generation of the UIDNEXT which is a performance problem. Its how it is used atm. We currently use it as uid for the next message which will get append to the mailbox. It would be more performant to use an auto_increment column in jpa for example. Other backends have othe

Re: [IMAP] Proposed store api change (NEXTUID)

2010-08-17 Thread Tim-Christian Mundt
Eric, you are right about the UIDVALIDITY, the default shouldn't be a random number, but the current timestamp which would guarantee that it won't occur again. I also thought about checking whether the next uid would wrap the uid counter to the negative - which would mean we need to regenerate the

Re: [IMAP] Proposed store api change (NEXTUID)

2010-08-17 Thread Eric Charles
... and one more general point :Should the UID API oblige (or not?) each store to use the UIDNEXT from the memory ? (or "Should the caching UIDNEXT mecanism be an optional utility, meaning that each store could re-implement it in a different way - cached, persistent or not ?"). Tks, Eric On

Re: [IMAP] Proposed store api change (NEXTUID)

2010-08-17 Thread Eric Charles
Hi Norman, I've read the http://www.rfc-editor.org/rfc/rfc3501.txt (section 2.3.1 Message Numbers) and http://www.rfc-editor.org/rfc/rfc2683.txt (section 3.4.3. UIDs and UIDVALIDITY) A first point is RFC talks about backend server not being able to store the UIDs. In this case, the UID are

Re: [IMAP] NamespaceProcessorTest fails

2010-07-10 Thread Norman Maurer
Ok I just fixed it.. I removed a method by mistake :/ Bye, Norman 2010/7/9 Norman Maurer : > Hi Tim, > > I fixed these errors. Now I have failures in the JPA tests.. At the > moment I don't understand why I only see them there and not in JCR / > InMemory.. :( > > Bye, > Norman > > 2010/7/8 Tim-Ch

Re: [IMAP] NamespaceProcessorTest fails

2010-07-09 Thread Norman Maurer
Hi Tim, I fixed these errors. Now I have failures in the JPA tests.. At the moment I don't understand why I only see them there and not in JCR / InMemory.. :( Bye, Norman 2010/7/8 Tim-Christian Mundt : > The error also occurs here but I didn't have the opportuniy to have a > closer look into thi

Re: [IMAP] NamespaceProcessorTest fails

2010-07-08 Thread Tim-Christian Mundt
The error also occurs here but I didn't have the opportuniy to have a closer look into this. Am Donnerstag, den 08.07.2010, 20:44 +0200 schrieb Norman Maurer: > Without > > Just current trunk after checkout... > > Bye > Norman > > 2010/7/8, Tim-Christian Mundt : > > Norman, do you mean with

Re: [IMAP] NamespaceProcessorTest fails

2010-07-08 Thread Norman Maurer
Without Just current trunk after checkout... Bye Norman 2010/7/8, Tim-Christian Mundt : > Norman, do you mean with the MailboxPath or without? > > Am Donnerstag, den 08.07.2010, 20:09 +0200 schrieb Norman Maurer: >> Hi all, >> >> is it just me or is the NamespaceProcessorTest failing ? @Tim

Re: [IMAP] NamespaceProcessorTest fails

2010-07-08 Thread Tim-Christian Mundt
Norman, do you mean with the MailboxPath or without? Am Donnerstag, den 08.07.2010, 20:09 +0200 schrieb Norman Maurer: > Hi all, > > is it just me or is the NamespaceProcessorTest failing ? @Tim could > you check this ? > > Thx, > Norman > > -

Re: [IMAP Maildir] Using absolute path as Key of Mailbox

2010-07-07 Thread Norman Maurer
Hi Tim, not sure if you could get it to work without the id.. Bye, Norman 2010/7/7 Tim-Christian Mundt : > Hi Norman, > > thanks for the hint. That's really valuable. Do we need an ID anyways? JPA > needs one (until now) to build relationships. But besides that? > getMailboxById() is hardly ever

  1   2   3   4   5   6   >