Re: svn commit: r420948 - in /james/server/trunk/src/java/org/apache/james: smtpserver/ transport/ userrepository/ util/connection/

2006-07-16 Thread Serge Knystautas
On 7/12/06, Norman Maurer [EMAIL PROTECTED] wrote: I like the setter stuff you put in there. With setters its also more easy to write junit tests. I allready use them for example in DNSRBLHandlerTest..I don't see any real problem with the setter methods. I like setters too. I'm -1 on creating

Re: svn commit: r420948 - in /james/server/trunk/src/java/org/apache/james: smtpserver/ transport/ userrepository/ util/connection/

2006-07-13 Thread Stefano Bagnara
Noel J. Bergman wrote: Stefano Bagnara wrote: init(Config) where Config contains a Context that in turn contains a mean to retrieve services is just an obfuscated way to use the Avalon serviceLocator pattern (service(ServiceManager s)). Well, you can say obfuscated and I can say that it is

Re: svn commit: r420948 - in /james/server/trunk/src/java/org/apache/james: smtpserver/ transport/ userrepository/ util/connection/

2006-07-13 Thread Vincenzo Gianferrari Pini
Stefano Bagnara wrote: AvalonListserv.java (2 matches) AvalonListservManager.java (2 matches) Obsolete and ready to deprecate, IMO. I love to remove code: can we remove those from trunk? Wait: deprecate != remove. I'm using AvalonListserv and AvalonListservManager quite extensively,

Re: svn commit: r420948 - in /james/server/trunk/src/java/org/apache/james: smtpserver/ transport/ userrepository/ util/connection/

2006-07-13 Thread Stefano Bagnara
Vincenzo Gianferrari Pini wrote: Stefano Bagnara wrote: AvalonListserv.java (2 matches) AvalonListservManager.java (2 matches) Obsolete and ready to deprecate, IMO. I love to remove code: can we remove those from trunk? Wait: deprecate != remove. I'm using AvalonListserv and

RE: svn commit: r420948 - in /james/server/trunk/src/java/org/apache/james: smtpserver/ transport/ userrepository/ util/connection/

2006-07-12 Thread Noel J. Bergman
Stefano Bagnara wrote: init(Config) where Config contains a Context that in turn contains a mean to retrieve services is just an obfuscated way to use the Avalon serviceLocator pattern (service(ServiceManager s)). Well, you can say obfuscated and I can say that it is the commmon mechanism

RE: svn commit: r420948 - in /james/server/trunk/src/java/org/apache/james: smtpserver/ transport/ userrepository/ util/connection/

2006-07-12 Thread Noel J. Bergman
Stefano Bagnara wrote: It used to be kept out of MOST of the Matchers and Mailets. IIRC, at one point it was only in RemoteDelivery, and then I added it (by necessity) to the quota code. Likewise, Mark did evil :-) things with the CommandListServ configuration code. Here is a list of