Re: Request for review (JVMTI spec, small)

2011-05-05 Thread Alex Buckley
Chapter 5 ("Loading, Linking, and Initializing") of the JVM Spec lives in ConstantPool.fm, hence the confusing HTML filename. All this kind of legacy cruft will go away when the JVMS moves to DocBook later in 2011. Alex On 5/5/2011 6:06 PM, David Holmes wrote: Daniel D. Daugherty said the fol

Re: Request for review (JVMTI spec, small)

2011-05-05 Thread David Holmes
Daniel D. Daugherty said the following on 05/06/11 01:15: I think that reference to 5.3.1 is correct. The previous line: Removed incorrect statement in GetClassloaderClasses tends to indicate that this was a class loader issue. So the reference to the BootstapClassLoader is probably right.

hg: jdk7/hotspot-rt/hotspot: 7033669: JVM TI spec has to be changed to not contain URLS to the VM Spec

2011-05-05 Thread keith . mcguigan
Changeset: 1d80a2429f59 Author:kamg Date: 2011-05-05 12:50 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/1d80a2429f59 7033669: JVM TI spec has to be changed to not contain URLS to the VM Spec Summary: Update JVMTI source files to remove hyperlinks and add full le

hg: jdk7/hotspot-rt/hotspot: 2 new changesets

2011-05-05 Thread kevin . walls
Changeset: 277d0f6ca64d Author:kevinw Date: 2011-04-18 08:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/277d0f6ca64d 7005503: Make GuaranteedSafepointInterval a diagnostic flag Reviewed-by: kamg, ysr ! src/share/vm/runtime/globals.hpp Changeset: 52df0980eb50

Re: Request for review (JVMTI spec, small)

2011-05-05 Thread Keith McGuigan
On May 5, 2011, at 11:47 AM, Jim Holmlund wrote: On 5/5/2011 6:21 AM, Keith McGuigan wrote: It's the ™ character. (trademark, if that doesn't come through for some reason on your mail client). Keith, Joe Darcy said that the current way to represent tm in HTML is to use ™ instead of

Re: Request for review (JVMTI spec, small)

2011-05-05 Thread Jim Holmlund
On 5/5/2011 6:21 AM, Keith McGuigan wrote: It's the ™ character. (trademark, if that doesn't come through for some reason on your mail client). Keith, Joe Darcy said that the current way to represent tm in HTML is to use ™ instead of #8482. Can you do that? - jjh Thanks for the revi

Re: Request for review (JVMTI spec, small)

2011-05-05 Thread Daniel D. Daugherty
I think that reference to 5.3.1 is correct. The previous line: Removed incorrect statement in GetClassloaderClasses tends to indicate that this was a class loader issue. So the reference to the BootstapClassLoader is probably right. Dan On 5/5/2011 8:50 AM, Keith McGuigan wrote: This

Re: Request for review (JVMTI spec, small)

2011-05-05 Thread Keith McGuigan
On May 5, 2011, at 9:37 AM, Daniel D. Daugherty wrote: On 5/4/2011 7:10 PM, Keith McGuigan wrote: Hello, There has been a request for us to not link directly to the JVMS from the JVMTI spec (especially using the old location in the java.sun.com domain, which will likely go away someday).

Re: Request for review (JVMTI spec, small)

2011-05-05 Thread Keith McGuigan
This one seems to refer to the wrong Chapter/Section - Constant pool should be 4.4 Actually hold on a sec: The original URL: http://java.sun.com/docs/books/vmspec/2nd-edition/html/ConstantPool.doc.html#79383 Does refer to chapter 5.3.1. Do you think the original URL is wrong? I don't

Re: Request for review (JVMTI spec, small)

2011-05-05 Thread Daniel D. Daugherty
On 5/4/2011 7:10 PM, Keith McGuigan wrote: Hello, There has been a request for us to not link directly to the JVMS from the JVMTI spec (especially using the old location in the java.sun.com domain, which will likely go away someday). This change removes the hyperlinks to the JVMS from the JV

Re: Request for review (JVMTI spec, small)

2011-05-05 Thread Keith McGuigan
It's the ™ character. (trademark, if that doesn't come through for some reason on your mail client). Thanks for the review! -- - Keith On May 5, 2011, at 9:17 AM, Karen Kinnear wrote: Keith, Looks good. Only mismatch I found is the one David already caught. In jvmti.xsl - line 1044 - wha

Re: Request for review (JVMTI spec, small)

2011-05-05 Thread Karen Kinnear
Keith, Looks good. Only mismatch I found is the one David already caught. In jvmti.xsl - line 1044 - what is #8482 for? thanks for doing this, Karen On May 5, 2011, at 8:42 AM, Keith McGuigan wrote: On May 4, 2011, at 11:18 PM, David Holmes wrote: Hi Keith, Keith McGuigan said the followi

Re: Request for review (JVMTI spec, small)

2011-05-05 Thread Keith McGuigan
On May 4, 2011, at 11:18 PM, David Holmes wrote: Hi Keith, Keith McGuigan said the following on 05/05/11 11:10: There has been a request for us to not link directly to the JVMS from the JVMTI spec (especially using the old location in the java.sun.com domain, which will likely go away some