hg: jdk8/tl/jdk: 7162111: TEST_BUG: change tests run in headless mode [macosx] (open)

Changeset: 8970128e040d Author:uta Date: 2012-11-26 15:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8970128e040d 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) Summary: In problem tests detection of AWT headless mode was introduced or AWT

hg: jdk8/tl/jdk: 8003898: X11 toolkit can be chosen as the default toolkit

Changeset: ee6e5b7d5d55 Author:uta Date: 2012-11-23 13:07 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee6e5b7d5d55 8003898: X11 toolkit can be chosen as the default toolkit Summary: XToolkit is not selected for any values of system-wide environment variables (ex.

Official reviewer needed: Review request for fix for 7200297: agent code does not handle multiple dll_dir paths correctly

Have a couple of reviews but still need official reviewer to pass muster. thanks, bill On 11/22/2012 7:51 AM, Dmitry Samersoff wrote: Bill, Looks good for me. -Dmitry On 2012-11-21 23:31, BILL PITTORE wrote: Hi Dmitry, On 11/21/2012 4:56 AM, Dmitry Samersoff wrote: Bill, Few nits:

Re: RFR (XS): 8003879: Duplicate definitions in vmStructs

Looks good. However, it'd be nice to fix the indentation commented by David (use frames to notice it): *vmStructs_cms.hpp*: 68declare_type(AFLBinaryTreeDictionary, FreeBlockDictionaryFreeChunk) *jni.cpp:* 2110declare_type(MetablockTreeDictionary,

Re: RFR (XS): 8003879: Duplicate definitions in vmStructs

Serguei, I'm confused. When I look at the latest webrev (http://cr.openjdk.java.net/~mikael/8003879/webrev.02/) I believe the indentation is correct - correct being defined as aligned on the first letter of the type name. Please clarify what you expect if you do not agree. Thanks, Mikael

Re: RFR (XS): 8003879: Duplicate definitions in vmStructs

Mikael, Sorry for the confusion. I see what you mean. I missed that you made it consistent with the current style in these files. Agree, that is the best you can do. Thanks, Serguei On 11/26/12 2:37 PM, Mikael Vidstedt wrote: Serguei, I'm confused. When I look at the latest webrev

hg: jdk8/tl/jdk: 8001634: Initial set of functional interface types

Changeset: c2e80176a697 Author:mduigou Date: 2012-11-26 15:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2e80176a697 8001634: Initial set of functional interface types Summary: Add the core functional interfaces used by the JSR335 libraries. Reviewed-by: dholmes,

Re: RFR (XS): 8003879: Duplicate definitions in vmStructs

No worries, thanks for clarifying and for the review(s)! Cheers, Mikael On 11/26/2012 3:00 PM, serguei.spit...@oracle.com wrote: Mikael, Sorry for the confusion. I see what you mean. I missed that you made it consistent with the current style in these files. Agree, that is the best you can

Re: Official reviewer needed: Review request for fix for 7200297: agent code does not handle multiple dll_dir paths correctly

Hi Bill, A few minor comments, some of which you've touched on with Dmitry. David -- share/back/debugInit.c 40 #include sys.h Shouldn't that be sys.h ? --- src/share/back/transport.c * Note: Java property sun.boot.library.path contains a single directory. + * Note: