hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-08-27 Thread daniel . daugherty
Changeset: 4a1efab850f4 Author:shade Date: 2013-08-26 17:42 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4a1efab850f4 8023638: Add the regression test for 8006997 Summary: Add the relevant test and proofread the VM messages as well Reviewed-by: coleenp, mseledtso

Re: RFR: 7164841: Improvements to the GC log file rotation

2013-08-27 Thread Bengt Rutisson
Yumin, On 8/26/13 7:01 PM, Yumin Qi wrote: Bengt, Thanks for your comments. Yes, as you said, the purpose of rotating logs is primarily targeted for saving disk space. This bug is supplying customers another option to prevent the previous gc logs from removed by restart app without mak

Re: RFR: 7164841: Improvements to the GC log file rotation

2013-08-27 Thread Kirk Pepperdine
On 2013-08-27, at 10:01 AM, Bengt Rutisson wrote: > > Yumin, > > On 8/26/13 7:01 PM, Yumin Qi wrote: >> Bengt, >> >> Thanks for your comments. >> Yes, as you said, the purpose of rotating logs is primarily targeted for >> saving disk space. This bug is supplying customers another option t

Re: jstack can't attach to JVM (OS X)

2013-08-27 Thread Staffan Larsen
On 26 aug 2013, at 20:19, Martin Traverso wrote: > Great! Thanks for the explanation. > > Just curious, why does running jstack at least once before the code reaches > that method call prevent the problem from happening at all? No idea. :( Can't figure it out. /Staffan > > Martin > > >

RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread Staffan Larsen
The original conversation about this problem is here: http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-August/011318.html In short, setjmp/longjmp on OS X messes up the signal mask and we should use _setjmp/_longjmp instead. This change fixes two occurences in the jdk. There ar

Re: jstack can't attach to JVM (OS X)

2013-08-27 Thread Mikael Gerdin
On 2013-08-27 10:26, Staffan Larsen wrote: On 26 aug 2013, at 20:19, Martin Traverso mailto:mtrave...@gmail.com>> wrote: Great! Thanks for the explanation. Just curious, why does running jstack at least once before the code reaches that method call prevent the problem from happening at all?

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread Staffan Larsen
I have also made a fix for hotspot. I messed up the link in the last email so here are both webrevs. jdk: http://cr.openjdk.java.net/~sla/8023786/webrev.00/ hotspot: http://cr.openjdk.java.net/~sla/8023720/webrev.00/ Thanks, /Staffan On 27 aug 2013, at 10:41, Staffan Larsen wrote: > The orig

Re: jstack can't attach to JVM (OS X)

2013-08-27 Thread Staffan Larsen
Yes, that's it. If one SIGQUIT has been processed, the JVM has already created the necessary handshake file and the attach will proceed regardless of the SIGQUIT reaching the JVM or not. Thanks! /Staffan On 27 aug 2013, at 10:43, Mikael Gerdin wrote: > > > On 2013-08-27 10:26, Staffan Larse

hg: jdk8/tl/jdk: 2 new changesets

2013-08-27 Thread weijun . wang
Changeset: ca53110f1c74 Author:weijun Date: 2013-08-27 17:50 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca53110f1c74 8015669: KerberosPrincipal::equals should ignore name-type Reviewed-by: mullan ! src/share/classes/javax/security/auth/kerberos/KerberosPrincipal.java + t

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

2013-08-27 Thread Staffan Larsen
How about a combination? By default we use -vmoptions/-javaoptions for the debuggee. But if the property jdi.debuggee.VMOptions is specified we will use that instead. This would allow -vmoptions/-javaoptions for simplicity but the property for added control when that is necessary. /Staffan On

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread David Holmes
On 27/08/2013 6:48 PM, Staffan Larsen wrote: I have also made a fix for hotspot. I messed up the link in the last email so here are both webrevs. jdk: http://cr.openjdk.java.net/~sla/8023786/webrev.00/ Seems okay. hotspot: http://cr.openjdk.java.net/~sla/8023720/webrev.00/ ??? You didn't

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread David Holmes
On 27/08/2013 9:41 PM, Staffan Larsen wrote: On 27 aug 2013, at 13:38, David Holmes wrote: On 27/08/2013 6:48 PM, Staffan Larsen wrote: I have also made a fix for hotspot. I messed up the link in the last email so here are both webrevs. jdk: http://cr.openjdk.java.net/~sla/8023786/webrev.0

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-08-27 Thread karen . kinnear
Changeset: 91b93f523ec6 Author:acorn Date: 2013-08-26 11:35 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/91b93f523ec6 8012294: remove generic handling for default methods Reviewed-by: kamg, coleenp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/clas

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread Staffan Larsen
Thanks! On 27 aug 2013, at 13:45, David Holmes wrote: > On 27/08/2013 9:41 PM, Staffan Larsen wrote: >> >> On 27 aug 2013, at 13:38, David Holmes wrote: >> >>> On 27/08/2013 6:48 PM, Staffan Larsen wrote: I have also made a fix for hotspot. I messed up the link in the last email so

Re: RFR: 8023720: setjmp/longjmp changes the process signal mask on OS X

2013-08-27 Thread Staffan Larsen
On 27 aug 2013, at 13:38, David Holmes wrote: > On 27/08/2013 6:48 PM, Staffan Larsen wrote: >> I have also made a fix for hotspot. I messed up the link in the last email >> so here are both webrevs. >> >> jdk: http://cr.openjdk.java.net/~sla/8023786/webrev.00/ > > Seems okay. > >> hotspot:

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

2013-08-27 Thread Daniel D. Daugherty
Sounds like a wonderful plan. Dan On 8/27/13 4:55 AM, Staffan Larsen wrote: How about a combination? By default we use -vmoptions/-javaoptions for the debuggee. But if the property jdi.debuggee.VMOptions is specified we will use that instead. This would allow -vmoptions/-javaoptions for simp

hg: jdk8/tl/nashorn: 10 new changesets

2013-08-27 Thread sundararajan . athijegannathan
Changeset: badc919cd621 Author:lagergren Date: 2013-08-23 14:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/badc919cd621 8023550: -d option was broken for any dir but '.'. Fixed Java warnings. Reviewed-by: jlaskey, sundar ! buildtools/nasgen/src/jdk/nashorn/internal/

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-08-27 Thread jiangli . zhou
Changeset: 6b3ac96bada6 Author:jiangli Date: 2013-08-26 13:32 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6b3ac96bada6 8023477: Invalid CP index when reading ConstantPool. Summary: Need to check for 0 case for InstanceKlass::_generic_signature_index. Reviewed-by

hg: jdk8/tl/jdk: 8023769: JDK-8016850 broke the old build

2013-08-27 Thread sean . mullan
Changeset: 134283a88499 Author:mullan Date: 2013-08-27 10:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/134283a88499 8023769: JDK-8016850 broke the old build Summary: remove files that were moved/removed from com/sun/security/auth/FILES_java.gmk Reviewed-by: chegar, xuel

hg: jdk8/tl/jdk: 2 new changesets

2013-08-27 Thread sean . mullan
Changeset: 6a1bfcde4d4d Author:mullan Date: 2013-08-27 12:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a1bfcde4d4d 8019830: Add com.sun.media.sound to the list of restricted package Reviewed-by: vinnie ! src/share/lib/security/java.security-linux ! src/share/lib/securi

Re: RFR: 7164841: Improvements to the GC log file rotation

2013-08-27 Thread Tao Mao
On 8/27/13 1:01 AM, Bengt Rutisson wrote: Yumin, On 8/26/13 7:01 PM, Yumin Qi wrote: Bengt, Thanks for your comments. Yes, as you said, the purpose of rotating logs is primarily targeted for saving disk space. This bug is supplying customers another option to prevent the previous gc

hg: jdk8/tl/langtools: 7052170: javadoc -charset option generates wrong meta tag

2013-08-27 Thread bhavesh . x . patel
Changeset: 7fb27bc201cc Author:bpatel Date: 2013-08-27 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7fb27bc201cc 7052170: javadoc -charset option generates wrong meta tag Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.j

hg: jdk8/tl/jdk: 8023827: Fix doclint issues in javax.net.ssl

2013-08-27 Thread joe . darcy
Changeset: 51151b440e95 Author:darcy Date: 2013-08-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51151b440e95 8023827: Fix doclint issues in javax.net.ssl Reviewed-by: wetmore, xuelei ! src/share/classes/javax/net/ssl/SNIHostName.java ! src/share/classes/javax/net/

hg: jdk8/tl/jdk: 8023275: Wrapping collections should override default methods

2013-08-27 Thread henry . jen
Changeset: ade440668f94 Author:henryjen Date: 2013-08-26 22:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ade440668f94 8023275: Wrapping collections should override default methods Reviewed-by: mduigou, psandoz ! src/share/classes/java/util/Collections.java + test/java/u

hg: jdk8/tl/langtools: 8023826: Typo in warning about obsolete source / target values

2013-08-27 Thread joe . darcy
Changeset: 662a5188bded Author:darcy Date: 2013-08-27 11:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/662a5188bded 8023826: Typo in warning about obsolete source / target values Reviewed-by: jjg, wmdietl ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.ja

hg: jdk8/tl/jdk: 8023647: "abc1c".matches("(\\w)+1\\1")) returns false

2013-08-27 Thread xueming . shen
Changeset: 3f6777cbfe69 Author:sherman Date: 2013-08-27 12:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f6777cbfe69 8023647: "abc1c".matches("(\\w)+1\\1")) returns false Summary: to correct the wrong GroupCurly group index backoff code Reviewed-by: alanb ! src/share/cl

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-08-27 Thread yumin . qi
Changeset: 7e7dd25666da Author:ccheung Date: 2013-08-26 14:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7e7dd25666da 8020675: invalid jar file in the bootclasspath could lead to jvm fatal error Summary: removed offending EXCEPTION_MARK calls and code cleanup R

hg: hsx/hotspot-rt/hotspot: 3 new changesets

2013-08-27 Thread ioi . lam
Changeset: f462e61bce87 Author:iklam Date: 2013-08-26 21:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f462e61bce87 8020622: create.bat on Windows failed to create project file for Visual Studio 2012 Summary: Treat VS2012 the same as VS2010. Reviewed-by: dcube

Re: RFR: 7164841: Improvements to the GC log file rotation

2013-08-27 Thread Yumin Qi
Hi, Bernd On 8/27/2013 10:27 AM, Bernd Eckenfels wrote: Hello, no matter what you decide (for example configurable pattern like J9 is doing it) please add enough header informatiomn to the logfile that it answers common gc diagnostic questions (version, command line settings, ram/swap size)

Re: RFR: 7164841: Improvements to the GC log file rotation

2013-08-27 Thread Yumin Qi
Hi, Based on the discussion, I updated the webrev, and in this version 1) deleted unused rotatingFileStream constructor, which keep code shorter. 2) removed reformat_filename in previous version. 3) still keep original design, that if no rotation, just use file name given by -Xloggc:. Others

hg: jdk8/tl/jdk: 8023528: Rename Comparator combinators to disambiguate overloading methods

2013-08-27 Thread henry . jen
Changeset: be2d25a277a7 Author:henryjen Date: 2013-08-21 20:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be2d25a277a7 8023528: Rename Comparator combinators to disambiguate overloading methods Reviewed-by: mduigou, smarks ! src/share/classes/java/util/Comparator.java !