Changeset: c13305cf8528
Author:jlahoda
Date: 2013-10-04 08:29 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c13305cf8528
8025118: Annotation processing api returns default modifier for interface
without default methods
Summary: TypeElement.getModifiers() should not co
On 3/10/2013 1:32 AM, Daniel D. Daugherty wrote:
David,
Thanks for the thorough review (as always)!
It will take me a while to process all the comments, but another
reply will be forthcoming.
Don't bother with the minimal VM build attempt, you won't even get
started. The files don't exist fo
On 2/10/2013 12:11 AM, Yasumasa Suenaga wrote:
Hi David,
Other than printing a message on the console it pretends that the init
has succeeded!
No.
signal_thread_entry() @ hotspot/src/share/vm/runtime/os.cpp
250 case SIGBREAK: {
251 // Check if the signal
On 10/3/2013 7:01 PM, Daniel D. Daugherty wrote:
On 10/3/13 4:56 PM, Coleen Phillmore wrote:
Thanks Dan -
On 10/3/2013 4:07 PM, Daniel D. Daugherty wrote:
> http://cr.openjdk.java.net/~coleenp/8025238/
src/share/vm/classfile/javaClasses.cpp
1804 if (method == NULL) {
1805 // l
On 10/3/2013 3:29 PM, Staffan Larsen wrote:
Looks good! (Obviously I would think so for the testcase :-) )
Thanks for the testcase!
Coleen
Thanks for fixing,
/Staffan
On 3 okt 2013, at 20:02, Coleen Phillimore wrote:
Summary: Redefined class in stack trace may not be found by method_idn
Thanks Serguei!
Coleen
On 10/3/2013 3:50 PM, serguei.spit...@oracle.com wrote:
Coleen,
The fix looks good.
It is nice you've come up with this.
Thanks,
Serguei
On 10/3/13 11:02 AM, Coleen Phillimore wrote:
Summary: Redefined class in stack trace may not be found by
method_idnum so handle nul
On 10/3/13 4:56 PM, Coleen Phillmore wrote:
Thanks Dan -
On 10/3/2013 4:07 PM, Daniel D. Daugherty wrote:
> http://cr.openjdk.java.net/~coleenp/8025238/
src/share/vm/classfile/javaClasses.cpp
1804 if (method == NULL) {
1805 // leave name and fileName null
1806 java_lang_Stac
Thanks Dan -
On 10/3/2013 4:07 PM, Daniel D. Daugherty wrote:
> http://cr.openjdk.java.net/~coleenp/8025238/
src/share/vm/classfile/javaClasses.cpp
1804 if (method == NULL) {
1805 // leave name and fileName null
1806 java_lang_StackTraceElement::set_lineNumber(element(), -1);
Thanks Dan -
On 10/3/2013 4:28 PM, Daniel D. Daugherty wrote:
> open webrev at http://cr.openjdk.java.net/~coleenp/8025238_jdk
test/java/lang/instrument/RedefineMethodInBacktrace.sh
No comments.
test/java/lang/instrument/RedefineMethodInBacktraceApp.java
line 78: t.setDaemon(t
Changeset: fdfbc5f0c4ed
Author:jjg
Date: 2013-09-17 14:17 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/fdfbc5f0c4ed
8024538: -Xdoclint + -Xprefer:source + incremental compilation == FAIL
Reviewed-by: darcy
! src/share/classes/com/sun/tools/doclint/DocLint.java
Changeset: 1971c2d770ae
Author:sundar
Date: 2013-09-18 13:06 +0530
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1971c2d770ae
8024972: for (LeftHandSideExpression in Expression) crashes the compiler
Reviewed-by: lagergren, hannesw
! src/jdk/nashorn/internal/codegen/Cod
Changeset: 85c1c94e7235
Author:katleman
Date: 2013-10-02 13:26 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/85c1c94e7235
Added tag jdk8-b110 for changeset 3d2b7ce93c5c
! .hgtags
Changeset: 17ee0d3e97fd
Author:katleman
Date: 2013-10-02 13:26 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/17ee0d3e97fd
Added tag jdk8-b110 for changeset 4c84c5b447b0
! .hgtags
Changeset: 5ec3c4948863
Author:ksrini
Date: 2013-09-27 16:27 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/5ec3c4948863
8023495: [infra] create 64-bit solaris bits with symlinks
Reviewed-by: ihse, tbell, erikj
! common/makefiles/Jprt.gmk
! common/makefiles/Main.gmk
Chan
Changeset: 32edc7a2c866
Author:katleman
Date: 2013-10-02 13:26 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/32edc7a2c866
Added tag jdk8-b110 for changeset cc682329886b
! .hgtags
> open webrev at http://cr.openjdk.java.net/~coleenp/8025238_jdk
test/java/lang/instrument/RedefineMethodInBacktrace.sh
No comments.
test/java/lang/instrument/RedefineMethodInBacktraceApp.java
line 78: t.setDaemon(true);
Why make the target thread a daemon? Wouldn't it be
Changeset: 01b8604e8268
Author:rriggs
Date: 2013-08-22 10:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01b8604e8268
8024896: Refactor java.time serialization tests into separate subpackage
Summary: Move serialization tests to .serial subpackage
Reviewed-by: sherman
Contr
> http://cr.openjdk.java.net/~coleenp/8025238/
src/share/vm/classfile/javaClasses.cpp
1804 if (method == NULL) {
1805 // leave name and fileName null
1806 java_lang_StackTraceElement::set_lineNumber(element(), -1);
Is it possible to set the name and fileName to something
Coleen,
The fix looks good.
It is nice you've come up with this.
Thanks,
Serguei
On 10/3/13 11:02 AM, Coleen Phillimore wrote:
Summary: Redefined class in stack trace may not be found by
method_idnum so handle null.
This is a simple change. I had another change to save the method name
(as
Looks good! (Obviously I would think so for the testcase :-) )
Thanks for fixing,
/Staffan
On 3 okt 2013, at 20:02, Coleen Phillimore wrote:
> Summary: Redefined class in stack trace may not be found by method_idnum so
> handle null.
>
> This is a simple change. I had another change to save
Jaroslav,
Behevior of mulitple loopback is not specified clearly[1] and is up to
OS developers or more precise - kernel setup.
Common practice is to assign 127.*.*.* to interfaces like tun, to be
able to use some socket-related calls ever if it is not connected to peer.
Other common situation -
Changeset: 1b3616c4a836
Author:rfield
Date: 2013-10-03 11:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b3616c4a836
8020849: jdk/lambda/vm/DefaultMethodsTest.java
Summary: Bridge generation has been removed from the VM. Fix is to remove tests
that no longer make sense.
Summary: Redefined class in stack trace may not be found by method_idnum
so handle null.
This is a simple change. I had another change to save the method name
(as u2) in the backtrace, but it's not worth the extra footprint in
backtraces for this rare case.
The root problem was that we save
Changeset: 8d8b809dd294
Author:rfield
Date: 2013-10-03 10:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d8b809dd294
8010433: Remove lambda metafactory work-around to JDK-8005119
Summary: Restore invokespecial to lambda metafactory
Reviewed-by: ksrini
! src/share/classes
On 10/03/2013 04:37 PM, Jaroslav Bachorik wrote:
On 3.10.2013 17:29, Chris Hegarty wrote:
On 10/03/2013 04:02 PM, Jaroslav Bachorik wrote:
...
But it might hardly matter - it seems that the main culprit for this
test to fail on this particular configuration was the fact that
127.0.0.1 was
On 3.10.2013 17:29, Chris Hegarty wrote:
On 10/03/2013 04:02 PM, Jaroslav Bachorik wrote:
...
But it might hardly matter - it seems that the main culprit for this
test to fail on this particular configuration was the fact that
127.0.0.1 was *NOT* detected as a loopback IP. This is pretty w
On 10/03/2013 04:02 PM, Jaroslav Bachorik wrote:
...
But it might hardly matter - it seems that the main culprit for this
test to fail on this particular configuration was the fact that
127.0.0.1 was *NOT* detected as a loopback IP. This is pretty weird and
I have not looked at the specif
Hi Mandy,
On 10/03/2013 06:50 PM, Mandy Chung wrote:
> What other command-line options are missing besides
> -server/-client/-d32/-d64?
These four were problematic "in the wild". I didn't see any other
options that are problematic, but does not mean there is none other.
> RuntimeMXBean.getVmName
On 2.10.2013 16:11, Dmitry Samersoff wrote:
Jaroslav,
As a far as loopback address could be resolved to any of 127.0.0.0/8
client and server have to use the same loopback address.
AFAIK, all the IPs 127.*.*.* equally designate the loopback interface.
This might start breaking when you have mo
On 10/3/2013 6:40 AM, Aleksey Shipilev wrote:
Hi,
Please take a look at the potential fix for:
https://bugs.openjdk.java.net/browse/JDK-8025700
The webrev is here:
http://cr.openjdk.java.net/~shade/8025700/webrev.01/
Rationale: when doing the Java tools which need to replicate the VM
la
Hello!
May I please have a review for a simple fix of the shell regtest?
Bash seems to accept both = and == comparisons, but sh accepts only =.
http://bugs.sun.com/view_bug.do?bug_id=8025886 (not yet visible.)
Sincerely yours,
Ivan
--- a/test/sun/management/jmxremote/bootstrap/GeneratePropert
Hi,
Please take a look at the potential fix for:
https://bugs.openjdk.java.net/browse/JDK-8025700
The webrev is here:
http://cr.openjdk.java.net/~shade/8025700/webrev.01/
Rationale: when doing the Java tools which need to replicate the VM
launch, e.g. fork the JVM with the same set of comman
Changeset: 9c32a9490eac
Author:kizune
Date: 2013-10-03 17:40 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c32a9490eac
8025738: locale related test fails on langtools mac 10.7 test host
Reviewed-by: ksrini
! test/tools/launcher/DiacriticTest.java
Changeset: 5d6dc0cba08f
Author:dsamersoff
Date: 2013-10-03 16:54 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d6dc0cba08f
8009213: sun/management/jdp/JdpTest.sh fails with exit code 1
Summary: There's no guarantee that the java process has executed far enough to
be found
Changeset: faff125a1ead
Author:dsamersoff
Date: 2013-10-03 12:39 +0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/faff125a1ead
8022616: u4 should not be used as a type for thread_id
Summary: Usage of u4 as a type for thread_id cause a compilation error on
platform,
Changeset: 811c35a6a58f
Author:psandoz
Date: 2013-10-02 16:34 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/811c35a6a58f
8025534: Unsafe typecast in java.util.stream.Streams.Nodes
8025538: Unsafe typecast in java.util.stream.SpinedBuffer
8025533: Unsafe typecast in
java.uti
Hi Frederik,
Will review this tomorrow.
Sorry for the latency, was busy with other things.
In general, I do not like the idea to skip the synchronization.
Also, it is important to keep the information from JVMTI consistent.
The data returned by the getLoadedClasses and getClassLoaderClasses
sho
Hi,
Revisiting this after further testing, and marking the flag as
experimental as Karen suggested (usage will be
-XX:+UnlockExperimentalVMOptions -XX:SymbolTableSize=...).
After removing an unnecessary method in the SA SymbolTable.java and
further testing, here's a webrev:
http://cr.openj
38 matches
Mail list logo
