Serguei,
1. Historically JDI test-suite had no tests for failed transport
initialization behavior and invalid parameters handling.
2. As a part of JDWP hardening work I added couple of such tests to
OptionTest.java - these tests pass invalid parameters to dt_socket
transport to make sure that
Ok.
Thank you for the explanation!
Serguei
On 8/20/14 1:01 AM, Dmitry Samersoff wrote:
Serguei,
1. Historically JDI test-suite had no tests for failed transport
initialization behavior and invalid parameters handling.
2. As a part of JDWP hardening work I added couple of such tests to
Greetings,
Kindly asking for review for this very small change.
Bug: https://bugs.openjdk.java.net/browse/JDK-8055662
Webrev: http://cr.openjdk.java.net/~mgronlun/8055662/webrev01/
Thanks
Markus
Looks good!
Thanks,
/Staffan
On 20 aug 2014, at 12:27, Markus Grönlund markus.gronl...@oracle.com wrote:
Greetings,
Kindly asking for review for this very small change.
Bug: https://bugs.openjdk.java.net/browse/JDK-8055662
Webrev: http://cr.openjdk.java.net/~mgronlun/8055662/webrev01/
Looks good
Markus Grönlund skrev 20/08/14 12:27:
Greetings,
Kindly asking for review for this very small change.
Bug: https://bugs.openjdk.java.net/browse/JDK-8055662
Webrev: http://cr.openjdk.java.net/~mgronlun/8055662/webrev01/
http://cr.openjdk.java.net/%7Emgronlun/8055662/webrev01/
All,
Running something like:
jtreg -javaoption:-Xmixed jdk/test/com/sun/jdi/RedefineStep.sh
Will print an error message:
test/com/sun/jdi/ShellScaffold.sh: line 885: -Xmixed: command not found
The test will not fail, but the -javaoption argument will be ignored.
The fix is to add
Dan,
Thanks for taking the time to review this!
On 8/19/14, 5:39 PM, Daniel D. Daugherty wrote:
On 8/15/14 2:18 PM, Coleen Phillimore wrote:
Summary: Use scratch_class to find EMCP methods for breakpoints if
the old methods are still running
See bug for more details. This fix also includes
Hi, it appears that my code is wrong and maybe the existing code is
wrong also. I have a spec question below.
On 8/19/14, 7:52 PM, serguei.spit...@oracle.com wrote:
On 8/19/14 3:53 PM, Daniel D. Daugherty wrote:
On 8/19/14 3:39 PM, Daniel D. Daugherty wrote:
On 8/15/14 2:18 PM, Coleen
Serguei,
After some additional testing I changed the fix a bit. Please take a
look at new version.
http://cr.openjdk.java.net/~dsamersoff/JDK-8049226/webrev.02/
New version reports JVMTI error to stderr.
Also jniFatalError is not referenced any more so I remove it.
-Dmitry
On 2014-08-20
Hello everyone!
Here's the third version of the webrev:
http://cr.openjdk.java.net/~igerasim/8055338/2/webrev/
The control build of the previous one was causing a lot of test failures.
This one seems to be innocent enough: no new test failures so far.
Additionally, this version keeps the
On 8/20/14 8:54 AM, Coleen Phillimore wrote:
Hi, it appears that my code is wrong and maybe the existing code is
wrong also. I have a spec question below.
On 8/19/14, 7:52 PM, serguei.spit...@oracle.com wrote:
On 8/19/14 3:53 PM, Daniel D. Daugherty wrote:
On 8/19/14 3:39 PM, Daniel D.
On 8/20/14, 3:49 PM, serguei.spit...@oracle.com wrote:
If an EMCP method is not running, should we save it on a previous
version list anyway so that we can make it obsolete if it's redefined
and made obsolete?
I hope, Dan will catch me if I'm wrong...
I think, we should not.
An EMCP
On 8/20/14 9:29 AM, Coleen Phillimore wrote:
Dan,
Thanks for taking the time to review this!
No problem. More responses below...
On 8/19/14, 5:39 PM, Daniel D. Daugherty wrote:
On 8/15/14 2:18 PM, Coleen Phillimore wrote:
Summary: Use scratch_class to find EMCP methods for breakpoints if
On 8/20/14 9:54 AM, Coleen Phillimore wrote:
Hi, it appears that my code is wrong and maybe the existing code is
wrong also. I have a spec question below.
Rely embedded below...
On 8/19/14, 7:52 PM, serguei.spit...@oracle.com wrote:
On 8/19/14 3:53 PM, Daniel D. Daugherty wrote:
On
On 8/20/14 2:01 PM, Coleen Phillimore wrote:
On 8/20/14, 3:49 PM, serguei.spit...@oracle.com wrote:
If an EMCP method is not running, should we save it on a previous
version list anyway so that we can make it obsolete if it's
redefined and made obsolete?
I hope, Dan will catch me if I'm
On 8/20/14, 6:37 PM, Daniel D. Daugherty wrote:
On 8/20/14 9:54 AM, Coleen Phillimore wrote:
Hi, it appears that my code is wrong and maybe the existing code is
wrong also. I have a spec question below.
Rely embedded below...
Also embedded reply but I cut some stuff out.
...
If an EMCP
On 8/20/14, 6:45 PM, Daniel D. Daugherty wrote:
On 8/20/14 2:01 PM, Coleen Phillimore wrote:
On 8/20/14, 3:49 PM, serguei.spit...@oracle.com wrote:
If an EMCP method is not running, should we save it on a previous
version list anyway so that we can make it obsolete if it's
redefined and
Looks good to me. Let’s see what it uncovers.
/Staffan
On 20 aug 2014, at 21:36, Ivan Gerasimov ivan.gerasi...@oracle.com wrote:
Hello everyone!
Here's the third version of the webrev:
http://cr.openjdk.java.net/~igerasim/8055338/2/webrev/
The control build of the previous one was
18 matches
Mail list logo
